From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Michael Ernst Newsgroups: gmane.emacs.bugs Subject: `list-load-path-shadows' ignores more directories than it should Date: Mon, 25 Mar 2002 17:38:04 -0500 Sender: bug-gnu-emacs-admin@gnu.org Message-ID: <200203252238.RAA16991@meoptiplex.lcs.mit.edu> NNTP-Posting-Host: localhost.gmane.org X-Trace: main.gmane.org 1017095973 20534 127.0.0.1 (25 Mar 2002 22:39:33 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Mon, 25 Mar 2002 22:39:33 +0000 (UTC) Original-Received: from fencepost.gnu.org ([199.232.76.164]) by main.gmane.org with esmtp (Exim 3.33 #1 (Debian)) id 16pd7k-0005Ky-00 for ; Mon, 25 Mar 2002 23:39:32 +0100 Original-Received: from localhost ([127.0.0.1] helo=fencepost.gnu.org) by fencepost.gnu.org with esmtp (Exim 3.34 #1 (Debian)) id 16pd7j-0000p8-00; Mon, 25 Mar 2002 17:39:31 -0500 Original-Received: from geyer.lcs.mit.edu ([18.26.3.21]) by fencepost.gnu.org with esmtp (Exim 3.34 #1 (Debian)) id 16pd6L-0000lT-00 for ; Mon, 25 Mar 2002 17:38:05 -0500 Original-Received: from meoptiplex.lcs.mit.edu (meoptiplex.lcs.mit.edu [18.26.3.32]) by geyer.lcs.mit.edu (8.9.3/8.9.3) with ESMTP id RAA09806; Mon, 25 Mar 2002 17:38:04 -0500 Original-Received: (from mernst@localhost) by meoptiplex.lcs.mit.edu (8.9.3/8.9.1) id RAA16991; Mon, 25 Mar 2002 17:38:04 -0500 Original-To: bug-gnu-emacs@gnu.org Errors-To: bug-gnu-emacs-admin@gnu.org X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.0.5 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Bug reports for GNU Emacs, the Swiss army knife of text editors List-Unsubscribe: , List-Archive: Xref: main.gmane.org gmane.emacs.bugs:172 X-Report-Spam: http://spam.gmane.org/gmane.emacs.bugs:172 In Emacs 21.2, list-load-path-shadows cuts off the search at the second directory containing "simple.el". I believe it should cut off at the last directory containing "simple.el", the better to detect conflicts arising from having multiple versions of lisp/ (for instance, from two different Emacs installations) in one's path. The below path accomplishes this. Alternately, one could check that all versions of simple.el that are being cut off are identical. ChangeLog entry: 2002-03-25 Michael Ernst * emacs-lisp/shadow.el (list-load-path-shadows): Only ignore last copy of "simple.el", etc. *** /g2/users/mernst/tmp/emacs-21.2/lisp/emacs-lisp/shadow.el Mon Jul 16 08:22:59 2001 --- - Sat Mar 23 21:41:02 2002 *************** *** 215,222 **** (if (> (length toplevs) 1) ;; Cut off our copy of load-path right before ! ;; the second directory which has simple.el in it. ;; This avoids loads of duplications between the source dir ;; and the dir where these files were copied by installation. ! (let ((break (nth (- (length toplevs) 2) toplevs))) (setq tem path) (while tem --- 215,222 ---- (if (> (length toplevs) 1) ;; Cut off our copy of load-path right before ! ;; the last directory that has simple.el in it. ;; This avoids loads of duplications between the source dir ;; and the dir where these files were copied by installation. ! (let ((break (car toplevs))) (setq tem path) (while tem