From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Ryan C. Thompson" Newsgroups: gmane.emacs.bugs Subject: bug#19412: 24.3; ido-write-file sometimes writes to a different directory than, it says it will Date: Mon, 11 Jan 2021 13:50:46 -0500 Message-ID: <1fc3637a-ef93-0f68-0dfb-a37a575ecbe3@thompsonclan.org> References: <0a0e748b-e809-d1e9-e52a-a3d846635fe6@thompsonclan.org> <2c4460c3-ad84-b706-189e-07429a3b2500@thompsonclan.org> <1f98bdf5-2da4-10b6-57f0-bdc0964a6df9@thompsonclan.org> <877dojimqt.fsf@gnus.org> <87o8hvco12.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26937"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 Cc: 19412@debbugs.gnu.org, Stefan Kangas To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 11 19:51:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kz2HW-0006s4-LU for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 11 Jan 2021 19:51:10 +0100 Original-Received: from localhost ([::1]:44650 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kz2HV-000401-8o for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 11 Jan 2021 13:51:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44106) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kz2HO-0003zg-C1 for bug-gnu-emacs@gnu.org; Mon, 11 Jan 2021 13:51:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46701) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kz2HO-0004r1-4j for bug-gnu-emacs@gnu.org; Mon, 11 Jan 2021 13:51:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kz2HO-0002CK-1k for bug-gnu-emacs@gnu.org; Mon, 11 Jan 2021 13:51:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Ryan C. Thompson" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Jan 2021 18:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19412 X-GNU-PR-Package: emacs Original-Received: via spool by 19412-submit@debbugs.gnu.org id=B19412.16103910598437 (code B ref 19412); Mon, 11 Jan 2021 18:51:01 +0000 Original-Received: (at 19412) by debbugs.gnu.org; 11 Jan 2021 18:50:59 +0000 Original-Received: from localhost ([127.0.0.1]:58247 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kz2HL-0002C0-5S for submit@debbugs.gnu.org; Mon, 11 Jan 2021 13:50:59 -0500 Original-Received: from mail-il1-f176.google.com ([209.85.166.176]:39606) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kz2HH-0002Bi-V5 for 19412@debbugs.gnu.org; Mon, 11 Jan 2021 13:50:58 -0500 Original-Received: by mail-il1-f176.google.com with SMTP id q1so146922ilt.6 for <19412@debbugs.gnu.org>; Mon, 11 Jan 2021 10:50:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thompsonclan-org.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=FNf/7XKajH8DqwaP8KlhRIO+Omt800M+2kpIZ/B3zfs=; b=QE2cZCPjJSM0b4FvFvgEIDv/Sm12O1/7q8F7O2OuhQrqpa+SHHKtvsrzj0qy7Ek5Da XD4f0lZsRQRnblMTiBeyl2uLfjKpO6BHSwOOYv8Upc0ujfrQa9aG+e87aeJ4RRZh5Awy eB4uXKq7oVLz5o2Ru6tekqbKqw2F1ZqhwSIp2AnmNWTDEsevqGH9G9mYevY8W65tZuB0 AW7TI2D1oQjysYfo74EioV/eaQGB1UtJJInXaoNTuewqzbOoSgWBhuTiJqtqmBAAnEBI xKhD3RVy4fxs5r0woDwuVQqIEAX8pery1bZl4zqH2TOASxaEEIsCjiCfl2qaCUNLdFj+ +ExA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=FNf/7XKajH8DqwaP8KlhRIO+Omt800M+2kpIZ/B3zfs=; b=L4Y9q9jaI1mUHR0JkO84nDdsfaO8P1ZggdjvdvWFpiUcCeWak05YaRFxKqjcN33tr2 IVhvENt9ahW9UL2U+NMpejNyaQ+a2JIn8xIjdGR8l7aXdGpufBvIbpDfs3bX8ewhcZFh TLNgXgV+iPw8D9VbnLlrHtTpX4izs74ckcgdivnhkl1YjHTJef0uTZ57dRmRvwGZGDry Yc8ArHCscd7KBnqO8SFbSb6fGnlMK0OgqOd4BUpj+SKNx7/pYEFWSoXRztjpz14Y1Cp3 uxyZK+gBhx1u6J21hCzjJuO41knXMwu5i0mmpZL/Q8VzdICZDRIVfehoteneEA/8fK93 L5cQ== X-Gm-Message-State: AOAM530gF30Uw20o3hyIFwk3rVFoh4Vj4iC45aB0/kwUK72obF+WMRZk kpmo+lw6GfQ8oK/Ar+TAJey+COsZdJU8qkd8 X-Google-Smtp-Source: ABdhPJyJjl8spXeN2U/8Y4cSV5IUSrfeKhVOS9r9nztHqLwDpNBZ0PpMOGaaJxyHEWWGNf7oxe0RkQ== X-Received: by 2002:a92:5a4a:: with SMTP id o71mr528897ilb.150.1610391049944; Mon, 11 Jan 2021 10:50:49 -0800 (PST) Original-Received: from urania.local (c-76-116-193-120.hsd1.nj.comcast.net. [76.116.193.120]) by smtp.gmail.com with ESMTPSA id r9sm261996ill.72.2021.01.11.10.50.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Jan 2021 10:50:49 -0800 (PST) In-Reply-To: <87o8hvco12.fsf@gnus.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:197734 Archived-At: On 1/11/21 1:43 PM, Lars Ingebrigtsen wrote: > "Ryan C. Thompson" writes: > >> And to do that, we need to preserve the user's current input >> verbatim when falling back. > Sounds reasonable, but who knows what people are doing in the setup > hooks there? So I worry about making a change like this, perhaps overly > much. > > I guess the only way to find out whether it breaks a lot of stuff or > not is to try it out and get feedback. > Yes, it's definitely an invasive change, and more properly characterized as a work-around than a true fix, so the worry isn't unwarranted. I'm pretty sure the code is correct (or as close to correct as possible given the "API" limitations we're working with), but it's always possible there's some edge case I haven't anticipated.