From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Ryan C. Thompson" Newsgroups: gmane.emacs.bugs Subject: bug#19412: 24.3; ido-write-file sometimes writes to a different directory than, it says it will Date: Sun, 10 Jan 2021 18:12:20 -0500 Message-ID: <1f98bdf5-2da4-10b6-57f0-bdc0964a6df9@thompsonclan.org> References: <0a0e748b-e809-d1e9-e52a-a3d846635fe6@thompsonclan.org> <2c4460c3-ad84-b706-189e-07429a3b2500@thompsonclan.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2544"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 Cc: 19412@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 11 00:13:09 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kyjtV-0000Z7-MA for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 11 Jan 2021 00:13:09 +0100 Original-Received: from localhost ([::1]:50942 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kyjtU-0006TV-Of for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 10 Jan 2021 18:13:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38826) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kyjtO-0006TO-Iy for bug-gnu-emacs@gnu.org; Sun, 10 Jan 2021 18:13:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43584) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kyjtO-0008Tn-C1 for bug-gnu-emacs@gnu.org; Sun, 10 Jan 2021 18:13:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kyjtO-0003zx-7N for bug-gnu-emacs@gnu.org; Sun, 10 Jan 2021 18:13:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Ryan C. Thompson" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Jan 2021 23:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19412 X-GNU-PR-Package: emacs Original-Received: via spool by 19412-submit@debbugs.gnu.org id=B19412.161032035115226 (code B ref 19412); Sun, 10 Jan 2021 23:13:02 +0000 Original-Received: (at 19412) by debbugs.gnu.org; 10 Jan 2021 23:12:31 +0000 Original-Received: from localhost ([127.0.0.1]:55128 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kyjst-0003xW-Ct for submit@debbugs.gnu.org; Sun, 10 Jan 2021 18:12:31 -0500 Original-Received: from mail-il1-f169.google.com ([209.85.166.169]:42896) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kyjsq-0003x1-Tv for 19412@debbugs.gnu.org; Sun, 10 Jan 2021 18:12:29 -0500 Original-Received: by mail-il1-f169.google.com with SMTP id t3so12414639ilh.9 for <19412@debbugs.gnu.org>; Sun, 10 Jan 2021 15:12:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thompsonclan-org.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=xyOIIKfRkLDQ7NX2Vv5Z1nFbDGoswqRUmSKIjCfnq4Q=; b=l9N1EFq6PI3HObsBCrMTqa5qctIcBokz7pHll4je6euv/3DpfZDmcVEtmM+0w3UoIu 7u9lW03mvUDdH7aYUDd5TIa9qGoH2BKaLK4QxZCO9OqGman1Z26QhIO0LI+LnmXI1omU p245y86x9G7bEbRSDPP2ok4MgCtbu4rDy4MA/qkrv+2fa2VV1Y4X9QomrSk5X+rR9d9b z2LxRapnVU8bm/B42T8ivtYldAm26T3ORROaK5g+pisSMoCUM14m9MMCkyoGNDOfZozq oMU9uXRfiAxv7+Dj8zuB9wKRYUYPwXAv2VHPG6gfHSyYsEm3JxR8/tFVPWge6VKIG2XA TPaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=xyOIIKfRkLDQ7NX2Vv5Z1nFbDGoswqRUmSKIjCfnq4Q=; b=X3ZHcGshBRFQzl0gRng2UPo60DzUmc3bLUSgr05J/T+Sqt3q8vwq1W1utzYaz5yoTv 06q0ik7t/feSDZPVe9p6Y0bhoc/y5GxrRO7T4OlBCwPngioLkMv+1bvFdz20+bm9QA/0 9UODr65v6Cwus9qYmQYSOM8rGi7iEvAklXpjufnRWOR4DbGth30JdIh0k7bYki5a2vi4 20191z0xpIvo7wnK3cIxMkKuVpzq3OWNhhswOLfKYqVP9P6B7AaVpJUi4V/1tevJOvcb WX4UXDooyG/Mvluu9Qh35N75RCT3Tp07tKmZrsdQptrnnn/YnJw6GPoAOD4sMVQE2RBW rVcw== X-Gm-Message-State: AOAM530sRd4/gTynZCSAKbxi4lv+cTajoClUoZ0IH+YgJVKLnLg3LKn6 aA2P+of3O4171V7MSVijP1gwe7bGnCSGAqwO X-Google-Smtp-Source: ABdhPJx/pPUw4UOjHf2aatAvLvwbWu8Ea97zBwxBmhn4IM3Tl49I943yVRBxsMyxySZA211bXFCCxA== X-Received: by 2002:a92:603:: with SMTP id x3mr12843497ilg.107.1610320343148; Sun, 10 Jan 2021 15:12:23 -0800 (PST) Original-Received: from urania.local (c-76-116-193-120.hsd1.nj.comcast.net. [76.116.193.120]) by smtp.gmail.com with ESMTPSA id y13sm10164993iop.14.2021.01.10.15.12.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 10 Jan 2021 15:12:22 -0800 (PST) In-Reply-To: Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:197670 Archived-At: Hi Stefan, It's been a while, but I've fixed up my patch and given it some testing, and it seems to work on for me. However, in the meantime, this issue has recently been "fixed" by special-casing write-file in ido.el, as seen in #28513. So if you want to install my patch now, you'll need to install the version attached to that thread. That version reverts the other fix, since of course they are not compatible, and would be redundant even if they were. Regards, Ryan Thompson On 8/12/20 12:44 PM, Stefan Kangas wrote: > "Ryan C. Thompson" writes: > >> Ok, I think I have a working patch for this issue. I patched ido-file-internal, >> ido-read-file-name, and ido-read-directory-name, and I think that's all the code >> paths that need to be fixed. Now the test case described in the original report >> produces the correct result for me: writing to /tmp/mumble.frotz. >> >> However, I should note that this is still relatively untested. I will test it >> out and try to make sure it doesn't cause any unexpected issues before I >> recommend merging it. > Any updates here? Did you give it more testing? > > Best regards, > Stefan Kangas