From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#51497: 29.0.50; (vc-print-log) broken over TRAMP Date: Sun, 7 Nov 2021 03:11:43 +0300 Message-ID: <1f17978c-0498-a19b-6bb0-6f316a536f8e@yandex.ru> References: <877ddv9ue0.fsf@jpl.nasa.gov> <87tugyptju.fsf@gnus.org> <87tugy8h3a.fsf@secretsauce.net> <87pmrl8yhy.fsf@secretsauce.net> <60fea707-a9b2-d9f4-cc45-ffd4539887b6@yandex.ru> <87o87253sv.fsf@secretsauce.net> <60af7952-d702-d40f-928e-1320e6d9520f@yandex.ru> <83f40a2a-ae5a-2c6c-cf6a-44ff7c933d16@yandex.ru> <831r3tb7un.fsf@gnu.org> <7e04f090-81de-d5bd-746c-7f09ed0c38b0@yandex.ru> <83lf219i3u.fsf@gnu.org> <86r1btvsso.fsf@gmail.com> <86ilx4x4xv.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33237"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 To: Andy Moreton , 51497@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 07 01:12:17 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mjVnE-0008T3-EC for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 07 Nov 2021 01:12:16 +0100 Original-Received: from localhost ([::1]:46686 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mjVnC-0005La-Hj for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 Nov 2021 20:12:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49510) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mjVn1-0005LO-2B for bug-gnu-emacs@gnu.org; Sat, 06 Nov 2021 20:12:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39646) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mjVn0-0002cM-Ej for bug-gnu-emacs@gnu.org; Sat, 06 Nov 2021 20:12:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mjVn0-0001Rq-8I for bug-gnu-emacs@gnu.org; Sat, 06 Nov 2021 20:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Nov 2021 00:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51497 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 51497-submit@debbugs.gnu.org id=B51497.16362439185554 (code B ref 51497); Sun, 07 Nov 2021 00:12:02 +0000 Original-Received: (at 51497) by debbugs.gnu.org; 7 Nov 2021 00:11:58 +0000 Original-Received: from localhost ([127.0.0.1]:51192 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjVmv-0001RW-SK for submit@debbugs.gnu.org; Sat, 06 Nov 2021 20:11:58 -0400 Original-Received: from mail-lf1-f52.google.com ([209.85.167.52]:33503) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjVmt-0001RI-D1 for 51497@debbugs.gnu.org; Sat, 06 Nov 2021 20:11:57 -0400 Original-Received: by mail-lf1-f52.google.com with SMTP id bu18so27189619lfb.0 for <51497@debbugs.gnu.org>; Sat, 06 Nov 2021 17:11:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=at0++wIQvbVaHvjNa7dRNtidvqziicB3c2ZDP2zwiFQ=; b=RyBWEP7mLiP2zCtxnq0PpqMVoVrTBRYpWoAjdatHLkAqj+ouWPJGRoa8OOunwmlYYB kzXdZIm5uo4dUAxDsfzoHKca1LkCGyS/2+Du8wQ8FN8FZhNQgpHES1m4A+eL5EZKHecT w9lbLl7b4fq4uyj/KSEVR9Ji2/qYz9wOEDijOF2T2AH5reBPLoHUs1kAL7CQ3Wuk+JPX da8trlymgpKcWV8ppfSZ2Q15YP9RBLaQJTUdXjuR9pAzZ/7g9+Warvx0Cp/Y5F8s8GH+ 9V8sWpW5xX2Jd90zNK9wgYONnyC6XnIQVqa2lW3WYjFIVUiCmUaTE5+ZYAWmuAzb5Ty3 9KWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=at0++wIQvbVaHvjNa7dRNtidvqziicB3c2ZDP2zwiFQ=; b=h1YmmbOSutopn57jwcqj9tYMKKLAgh3cLM5VRBSGnnSz6m/O3NLkL7Q4qBsrbINFYs fuEX8kz7SALpaTq4Xism1qdRJ3ze12fiU+RK+7iLMfyEfEJgQNkRGFUwopyBM8J7ZFVu gOhm318yvZo8WnD/f9WpnXSMyXeoUo/fod0DvN/pFGgYvzVusJZ4yiVgz3KLbrcRnXIM Rp+RUXm61pwjuz0c/TgjePfXX5nvIWK1EpK3GQrDvFWmH9Y/wMdWOA1FkfTFqK/11lYZ 2ep+KZugW/Y+ZAb6lzJpPTqAu5ri0AAlcrGdlvCe6ScIbD4ouM/WJfIZCK5fMZDMA/+2 Xu2w== X-Gm-Message-State: AOAM531to2bLDp7AnZFhNsR5IJs4ghFCX24ZZp/6JqswOxP0D/AOGC6K EPiw35mXXREb0Td2Go/5H/g8hT86V8Y= X-Google-Smtp-Source: ABdhPJwPuRMMRWKhcfHr4nKAKqCuCPQUl8BadAeecRRg7EWEQkPuLCg1kwq4uUYM2GzHoAP9u0Ov0Q== X-Received: by 2002:a05:6512:2182:: with SMTP id b2mr22181648lft.311.1636243909120; Sat, 06 Nov 2021 17:11:49 -0700 (PDT) Original-Received: from [192.168.0.103] ([5.18.235.131]) by smtp.googlemail.com with ESMTPSA id o12sm1299747lfo.183.2021.11.06.17.11.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 06 Nov 2021 17:11:48 -0700 (PDT) In-Reply-To: <86ilx4x4xv.fsf@gmail.com> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:219174 Archived-At: On 07.11.2021 02:03, Andy Moreton wrote: > On Sun 07 Nov 2021, Dmitry Gutov wrote: > >> On 07.11.2021 01:11, Andy Moreton wrote: >>> That workaround is still needed for me. Without that, nothing in vc-git >>> works in my environment (64bit minw64 build on win10, using cygwin bash >>> and git together with cygwin-mount.el from emacs wiki). >> >> Does that environment also have an old version of Git? Or is there another >> reason why it's broken? > > I have git 2.33 in cygwin and MSYS2, so git is not old. I'll look at > this again now that the changes have stablised. It would have been nice to receive this feedback before the emacs-28 branch was cut, when we had more freedom to alter the implementation. >>> While I realise my setup is somewhat non-standard, other users may also >>> find that the literal pathspec code also misbehaves. >> >> I would like to fix it for all users, but debugging would fall on your >> shoulders, I'm afraid. > > My note was more to warn that adding this to emacs-28 may bring > problems. Adding what? The literal pathspec stuff is already there. > Looking at this again, Trying "C-x v l" for INSTALL in the repo master > branch gives (rewrapped for clarity): > > fatal: :(literal)c:/emacs/git/emacs/master/nt/INSTALL: > 'c:/emacs/git/emacs/master/nt/INSTALL' is outside repository at > '/c/emacs/git/emacs/master' > > This appears to be due to the translation between win32 and cygwin > (posix) filenames. It might be fixable inside vc-git--literal-pathspec. Is there some other more general path conversion function we should use instead of 'file-local-name' there? A tested patch would help a lot. Failing that, I think we'll need to change the "literal pathspecs" implementation to yet another approach (adding --literl-pathspecs flag instead of manipulating file names). It comes with the same general drawbacks as the env var (which is used under the hood), but the explicit approach of specifying it in every command would avoid the problem of my original fix for that bug.