From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#62333: 30.0.50; Issue with tree-sitter syntax tree during certain changes Date: Sun, 26 Mar 2023 01:29:58 +0200 Message-ID: <1ef42ce9-e7a5-5a21-e4a4-f8affb45541d@yandex.ru> References: <87fs9yur7r.fsf@gmail.com> <09539C5E-23DA-4B00-A3F6-873A41D6A2CE@gmail.com> <83h6uc549z.fsf@gnu.org> <665745A2-FDC8-45DE-BFF5-2F688FC85431@gmail.com> <491b788f-c3c3-4877-daa0-f515be9f3a17@yandex.ru> <83sfduelab.fsf@gnu.org> <8FC25A01-6934-43BB-899C-CA5926BEA3CF@gmail.com> <83jzz5c8ml.fsf@gnu.org> <83edpdc6sn.fsf@gnu.org> <1ca302bf-99dc-7f9e-8544-063064a1cb21@yandex.ru> <831qlcdisi.fsf@gnu.org> <398721ad-79b0-3f6d-97b3-4902d9bfbe39@yandex.ru> <83wn34c2qa.fsf@gnu.org> <3b3d82d1-f0f6-a768-a5db-8dc9386a5a34@yandex.ru> <83r0tcbz8g.fsf@gnu.org> <1967361679760225@umbzx4hqxrw5qxo7.sas.yp-c.yandex.net> <83mt40bxzd.fsf@gnu.org> <83jzz4bugh.fsf@gnu.org> <35322CB1-DF75-47C1-9B66-21260C437006@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21645"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Cc: Wilhelm Kirschbaum , 62333@debbugs.gnu.org To: Yuan Fu , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 26 00:31:35 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pgDMF-0005QB-Fj for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 26 Mar 2023 00:31:35 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pgDLx-0006nv-Um; Sat, 25 Mar 2023 19:31:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pgDLr-0006n4-Cn for bug-gnu-emacs@gnu.org; Sat, 25 Mar 2023 19:31:13 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pgDLj-0003FI-32 for bug-gnu-emacs@gnu.org; Sat, 25 Mar 2023 19:31:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pgDLh-0000L9-O8 for bug-gnu-emacs@gnu.org; Sat, 25 Mar 2023 19:31:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Mar 2023 23:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62333 X-GNU-PR-Package: emacs Original-Received: via spool by 62333-submit@debbugs.gnu.org id=B62333.16797870081245 (code B ref 62333); Sat, 25 Mar 2023 23:31:01 +0000 Original-Received: (at 62333) by debbugs.gnu.org; 25 Mar 2023 23:30:08 +0000 Original-Received: from localhost ([127.0.0.1]:43650 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgDKp-0000K1-R7 for submit@debbugs.gnu.org; Sat, 25 Mar 2023 19:30:08 -0400 Original-Received: from mail-wr1-f48.google.com ([209.85.221.48]:41476) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgDKo-0000Hw-NQ for 62333@debbugs.gnu.org; Sat, 25 Mar 2023 19:30:07 -0400 Original-Received: by mail-wr1-f48.google.com with SMTP id h17so5139473wrt.8 for <62333@debbugs.gnu.org>; Sat, 25 Mar 2023 16:30:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679787001; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=rhYN1Go4wxuNKyTlqiQyAhRjPFKRM02o0HgYocdZqWA=; b=ePHPKdWU3kM2TqhkXOwWBLD/N3mLhwwNonhNlZpgg4/L39nlAEryt2SAQ4uamBqGD4 njFdeDzzOD1u8mhHRrK6GCQXUH2C8fGe+leoUAmqsngNM/N5a72kBj1pVEn3uscML+f+ QZbr57MviyQFVH471Z673vMCjRth5Vh8DegO+Z0SO6gJLXnejg2t1E2//RkxV5j8nCns kAlTpFpsuZJYX33raCmCeQgVRuEoBOaqtdvQv/dHKzDtNp80JBVBqd+Lu0EC1vGRgoLg J7i6QBs/+YmvXjtdSNY2Jo/xHlqAD1WMS39lGDFiW3oT+FFJRb/wI+Ymc/VlpSuZpiQK y+Rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679787001; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rhYN1Go4wxuNKyTlqiQyAhRjPFKRM02o0HgYocdZqWA=; b=Av3tMpejB37izHyPN3YTzjBlH/WxjbyAYMevEdF5ZAb/R3abwGlp/HxqD+XUTOe385 zn24sZGfyGt50j5lYhtwdBe5JRG7X4CSz7md2NUu2EiUwS8tFkE0EGwrEdcNR2jbimvm SOMVp0PqCbkjNlAvJlKZeFljmkTdwxq+CqjtonvgHel8UX1dK7qqSjhwsP7xTzXYlZ5j hwQdo/Yxznx2+lQtTdvNwMDCAufejbFef3225JvuDrsxHDTZ4rxIFCYjGjjgInx4CS2X 5XWWTPbPQ/k1xYoYKWW34hZpq89xOlF4Z+dkf496zyGIeutkBmBwjMlVnwCibAf4H/oc Fv6Q== X-Gm-Message-State: AAQBX9cN14NRceAqpH7QpbL4mBXRrCybEvwyv8pKOgWMpKxKHFZR99LI Hc8wF+As+DexpgSEiqkEHEM= X-Google-Smtp-Source: AKy350YGv4DE2xGKiyt6VnePfH2wpT4RTW0ZFdX8R1bah2P+vH7vfLhUeiMyCiAarC7is6ZNZ2BkXg== X-Received: by 2002:adf:f34b:0:b0:2cf:e956:9740 with SMTP id e11-20020adff34b000000b002cfe9569740mr8314294wrp.6.1679787000687; Sat, 25 Mar 2023 16:30:00 -0700 (PDT) Original-Received: from [192.168.0.2] ([85.132.229.92]) by smtp.googlemail.com with ESMTPSA id o6-20020adfeac6000000b002c71a32394dsm21572771wrn.64.2023.03.25.16.29.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 25 Mar 2023 16:30:00 -0700 (PDT) Content-Language: en-US In-Reply-To: <35322CB1-DF75-47C1-9B66-21260C437006@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258637 Archived-At: On 25/03/2023 21:31, Yuan Fu wrote: > > I don’t think we should blindly widen in tree-sitter sexp functions, but not because of mmm-mode—tree-sitter ranges should have that mostly covered. My primary concern is that what if narrowing is intended by the caller? Yes. > But I don’t have any good idea for blink-matching right now. show-paren-mode has show-paren-data-function (which treesit should also plug into, I think). Since we're looking for ad-hoc solutions, we could add a similar extension point for blink-matching-paren. Or even try to reuse show-paren-data-function: just specialize in a limited number of cases - check that (nth 1 data) matches point, and then take the elements 3,4 and perform the existing checks on them. There might be some differences in behavior, but probably nothing some checks using 'syntax-after' couldn't handle.