From: Martin Kletzander <nert.pinx@gmail.com>
To: 32723@debbugs.gnu.org
Subject: bug#32723: [PATCH] Fix erc-autojoin for same channel names on multiple servers
Date: Wed, 12 Sep 2018 17:44:29 +0200 [thread overview]
Message-ID: <1ea700cd1f4f6a80dd1315c8192361bd09d1eadd.1536767069.git.nert.pinx@gmail.com> (raw)
When auto-joining channel with the same name on
multiple channels the auto-join will go over the
list of channels and for each one it checks if
there is a buffer and alive server process.
However it does not check if the server process
matches the server being currently processed for
auto-joining.
This happens since commit "Don't join erc channels
doubly"
Fix it by checking if the currently processed
server matches the erc process name of the already
joined channel.
* lisp/erc/erc-join.el (erc-autojoin-channels):
Join channels with the same name on different
servers.
Copyright-paperwork-exempt: yes
---
lisp/erc/erc-join.el | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lisp/erc/erc-join.el b/lisp/erc/erc-join.el
index a6bf6518ea86..567a4cc27e19 100644
--- a/lisp/erc/erc-join.el
+++ b/lisp/erc/erc-join.el
@@ -161,6 +161,9 @@ This function is run from `erc-nickserv-identified-hook'."
;; Only auto-join the channels that we aren't already in
;; using a different nick.
(when (or (not buffer)
+ ;; If the same channel is joined on another
+ ;; server the best-effort is to just join
+ (not (string-match (car l) (process-name erc-server-process)))
(not (with-current-buffer buffer
(erc-server-process-alive))))
(erc-server-join-channel server chan))))))))
--
2.18.0
next reply other threads:[~2018-09-12 15:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-12 15:44 Martin Kletzander [this message]
2019-06-23 21:53 ` bug#32723: [PATCH] Fix erc-autojoin for same channel names on multiple servers Lars Ingebrigtsen
2020-05-10 19:45 ` Kevin Brubeck Unhammer
[not found] ` <87ftc7h9gp.fsf@fsfe.org>
2020-05-11 15:06 ` Martin Kletzander
2020-05-19 18:25 ` Martin Kletzander
2020-05-19 18:40 ` Kevin Brubeck Unhammer
2020-05-19 20:32 ` Corwin Brust
2020-06-09 14:52 ` Martin Kletzander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ea700cd1f4f6a80dd1315c8192361bd09d1eadd.1536767069.git.nert.pinx@gmail.com \
--to=nert.pinx@gmail.com \
--cc=32723@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).