unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Andreas Röhler" <andreas.roehler@easy-emacs.de>
To: Mauro Aranda <maurooaranda@gmail.com>,
	Lars Ingebrigtsen <larsi@gnus.org>
Cc: 15485@debbugs.gnu.org
Subject: bug#15485: add-abbrev: don't use hard-coded forward-word
Date: Thu, 15 Aug 2019 16:37:16 +0200	[thread overview]
Message-ID: <1e93bdc1-a85a-b189-8a15-ab5b4441fcf9@easy-emacs.de> (raw)
In-Reply-To: <CABczVwfPWM0gWoCvrv2+yM28rCef6GGXggsOB12tcypte_Lz8Q@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1943 bytes --]

Hi all,

On 15.08.19 14:41, Mauro Aranda wrote:
> Hello Lars.
>
> Lars Ingebrigtsen <larsi@gnus.org <mailto:larsi@gnus.org>> writes:
>
> > Andreas Röhler <andreas.roehler@easy-emacs.de 
> <mailto:andreas.roehler@easy-emacs.de>> writes:
> >
> >> add-abbrev uses forward-word to catch the expansion, which isn't good
> >> for programming code.
> >>
> >> See
> >>
> >> 
> http://stackoverflow.com/questions/19073674/how-can-i-add-my-personal-abbreviation-to-emmet-mode-in-emacs/19079683#19079683
> >>
> >> Suggest to use forward-symbol instead, or still better to make if 
> customizable:
> >
> > `add-abbrev' doesn't have a doc string itself, but as all the in-tree
> > callers of this function says:
> >
> > ---
> > Don't use this function in a Lisp program; use `define-abbrev' instead.
> > ---
> >
> > So you probably shouldn't use this programmatically, either.
>
> I don't think the OP wanted to use `add-abbrev' in a Lisp program.  What
> I understand is that the problem reported arises when someone wants to
> add an abbrev for a programming construct (in the example: "<?php ?>")
> it is likely that `add-abbrev' won't give the entire desired
> expansion.
>
> With that being said, at least in current Emacs it is easy to add that
> abbrev, by setting the mark and point properly and calling
> `add-mode-abbrev' with a 0 prefix argument.
>
> > However, it's possible that the `forward-word' should perhaps be
> > changed, but on the other hand, abbrev.el will probably be deprecated
> > any year now in favour of nabbrev.el, so I don't think it's a good idea
>
> What is nabbrev.el?  I did a search in what I believe are usual places,
> but didn't found anything.


The idea was to get rid of the restriction only word-syntax chars might 
compose an abbreviation.

After all, when playing with a patched Emacs allowing all chars, it 
turned out word-chars are much more easy to type, so didn't use 
symbol-composed abbrevs finally.


[-- Attachment #2: Type: text/html, Size: 3334 bytes --]

  reply	other threads:[~2019-08-15 14:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-29 15:40 bug#15485: add-abbrev: don't use hard-coded forward-word Andreas Röhler
2019-08-15  3:29 ` Lars Ingebrigtsen
2019-08-15 12:41   ` Mauro Aranda
2019-08-15 14:37     ` Andreas Röhler [this message]
2019-08-15 23:50     ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1e93bdc1-a85a-b189-8a15-ab5b4441fcf9@easy-emacs.de \
    --to=andreas.roehler@easy-emacs.de \
    --cc=15485@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=maurooaranda@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).