From: Dmitry Gutov <dmitry@gutov.dev>
To: Randy Taylor <dev@rjt.dev>
Cc: 70260-done@debbugs.gnu.org
Subject: bug#70260: [PATCH] Flymake support for rust-ts-mode (clippy-driver)
Date: Tue, 9 Apr 2024 22:41:58 +0300 [thread overview]
Message-ID: <1e63d72e-ee49-47a2-8b7a-7f5b04cd43b9@gutov.dev> (raw)
In-Reply-To: <m9tFLZ_hGBqGa5aAIujpYBz5pXrsHBQDOKOJ8KG4l2KJdSkXgICPUj8tgxeeGEPlMgsawCDnHlDS_-NjLbSN0n4Qc8kLPVedqtgFGsOe8Cc=@rjt.dev>
Version: 30.1
On 09/04/2024 05:42, Randy Taylor wrote:
> On Sunday, April 7th, 2024 at 20:26, Dmitry Gutov <dmitry@gutov.dev> wrote:
>>
>>
>> Minor fix and a TODO comment for the "cargo clippy" case.
>>
>> On 07/04/2024 19:42, Dmitry Gutov wrote:
>>
>>> X-Debbugs-Cc: Randy Taylor dev@rjt.dev
>>>
>>> Hi Randy and others,
>>>
>>> Here's a patch adding rust-ts-mode <-> flymake-mode integration using
>>> clippy.
>>>
>>> Feedback welcome.
>
> Thanks for working on this.
Thanks for taking a look.
I imagine it won't be used for larger projects, edited assisted by LSP -
LSP clients have their own Flymake integration. But I found it useful a
few months ago when doing some leetcode exercises.
> I'm not really familiar with flymake integration, but this
> looks good to me. I have a few nits below.
>
> +(defcustom rust-ts-flymake-command '("clippy-driver" "-")
> + "The external tool that will be used to perform the syntax check.
> ^^^^^^^^^^^^^^^^
> maybe just "the check"?
> Or something similar, since more is being done than just syntax checking.
>
> +This is a non empty list of strings, the checker tool possibly followed
> ^^^^^^^^^ ^
> non-empty? A colon would work well here.
Thank you. This was actually copied from some exiting flymake backends,
but they could use such edits as well.
> +(defvar rust-ts--flymake-proc nil)
> Should this be defvar-local?
Not necessarily - there would usually be only one simultaneous check
running, and the pointer to the associated buffer is stored in the closure.
> + ;; Flymake
> ^
> A period at the end would make me happy :).
Sure.
Pushed to master as ccced8c3e43, closing.
prev parent reply other threads:[~2024-04-09 19:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-07 16:42 bug#70260: [PATCH] Flymake support for rust-ts-mode (clippy-driver) Dmitry Gutov
2024-04-08 0:26 ` Dmitry Gutov
2024-04-09 2:42 ` Randy Taylor
2024-04-09 19:41 ` Dmitry Gutov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e63d72e-ee49-47a2-8b7a-7f5b04cd43b9@gutov.dev \
--to=dmitry@gutov.dev \
--cc=70260-done@debbugs.gnu.org \
--cc=dev@rjt.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).