From: Dmitry Gutov <dmitry@gutov.dev>
To: Eli Zaretskii <eliz@gnu.org>
Cc: ams@gnu.org, 66211@debbugs.gnu.org
Subject: bug#66211: 30.0.50; C-x v v in vc-diff does not work with lesser versionf of patch
Date: Fri, 29 Sep 2023 20:27:21 +0300 [thread overview]
Message-ID: <1e1f0e18-1fe2-4bb4-38f3-1c49de831abc@gutov.dev> (raw)
In-Reply-To: <835y3typge.fsf@gnu.org>
On 29/09/2023 18:22, Eli Zaretskii wrote:
>> Date: Fri, 29 Sep 2023 13:22:39 +0300
>> Cc: 66211@debbugs.gnu.org
>> From: Dmitry Gutov <dmitry@gutov.dev>
>>
>> On 29/09/2023 10:05, Eli Zaretskii wrote:
>>>> From: "Alfred M. Szmidt"<ams@gnu.org>
>>>> Date: Tue, 26 Sep 2023 08:17:27 -0400
>>>>
>>>>
>>>> The C-x v v command in a*vc-diff* buffer does not work if you have a
>>>> lesser version of patch, e.g., the one on OpenBSD:
>>>>
>>>> user-error: Patch failed: patch: unknown option -- no-backup-if-mismatch
>>>> usage: patch [-bCcEeflNnRstuv] [-B backup-prefix] [-D symbol] [-d directory]
>>>> [-F max-fuzz] [-i patchfile] [-o out-file] [-p strip-count]
>>>> [-r rej-name] [-V t | nil | never] [-x number] [-z backup-ext]
>>>> [--posix] [origfile [patchfile]]
>>>> patch <patchfile
>>> I don't understand: does "git apply" invoke Patch? AFAICT, "C-x v v"
>>> in a*vc-diff* buffer runs "git apply FILE", where FILE is a temporary
>>> patch file created from the diffs to be applied. What am I missing?
>>
>> vc-default-checkin-patch calls 'patch'. It's for other backends.
>
> Why do we call Patch if we have a way to apply hunks in Lisp? Wasn't
> that just discussed in the other thread?
https://lists.gnu.org/archive/html/emacs-devel/2022-10/msg01353.html
Anyway, it doesn't seem like 'patch' itself is the problem in this case:
the alternative flags should work for BSD Patch as well. Though I'm
still waiting for confirmation.
next prev parent reply other threads:[~2023-09-29 17:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-26 12:17 bug#66211: 30.0.50; C-x v v in vc-diff does not work with lesser versionf of patch Alfred M. Szmidt
2023-09-26 12:38 ` Dmitry Gutov
2023-09-26 12:43 ` Alfred M. Szmidt
2023-09-26 13:38 ` Dmitry Gutov
2023-09-26 15:08 ` Alfred M. Szmidt
2023-09-26 16:30 ` Dmitry Gutov
2023-09-26 16:51 ` Alfred M. Szmidt
2023-10-07 22:33 ` Dmitry Gutov
2023-10-08 5:01 ` Eli Zaretskii
2023-10-14 17:10 ` Dmitry Gutov
2023-09-29 7:05 ` Eli Zaretskii
2023-09-29 10:22 ` Dmitry Gutov
2023-09-29 15:22 ` Eli Zaretskii
2023-09-29 17:27 ` Dmitry Gutov [this message]
2023-09-29 17:40 ` Eli Zaretskii
2023-09-29 18:11 ` Dmitry Gutov
2023-09-29 18:36 ` Alfred M. Szmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e1f0e18-1fe2-4bb4-38f3-1c49de831abc@gutov.dev \
--to=dmitry@gutov.dev \
--cc=66211@debbugs.gnu.org \
--cc=ams@gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).