From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#69993: Wrap window buffers while cycling Date: Thu, 25 Apr 2024 10:31:47 +0200 Message-ID: <1e0dd4b7-5866-4645-a0a5-57850861dd71@gmx.at> References: <86h6gug41x.fsf@mail.linkov.net> <8a131d8b-1330-4d82-92f6-309f499e9c15@gmx.at> <86h6gi49zw.fsf@mail.linkov.net> <1e50bd70-8cbb-46f9-9078-dd0e6226da63@gmx.at> <861q7k8gms.fsf@mail.linkov.net> <2d3f0d14-e39b-4399-be30-03f11725c505@gmx.at> <86ttkf6a8r.fsf@mail.linkov.net> <86jzlajpqq.fsf@mail.linkov.net> <85109880-3370-47e0-b7c9-6c5a32cfaafa@gmx.at> <86le5nhwqy.fsf@mail.linkov.net> <864jcajzxi.fsf@mail.linkov.net> <86o7ahglre.fsf@mail.linkov.net> <28a8149b-283a-4b08-9df5-f1139a0fccbe@gmx.at> <86ttk7m7ir.fsf@mail.linkov.net> <1b38c78c-6697-4c6b-81cf-5a72fdd3ba8d@gmx.at> <868r1i8si0.fsf@mail.linkov.net> <867ch09bx6.fsf@mail.linkov.net> <867cgxn7lx.fsf@mail.linkov.net> <86zftrlvo4.fsf@mail.linkov.net> <86zftivhnn.fsf@mail.linkov.net> Reply-To: martin rudalics Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13473"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: 69993@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 25 10:33:12 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rzuXY-0003I6-4X for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 25 Apr 2024 10:33:12 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rzuXJ-0003BN-L2; Thu, 25 Apr 2024 04:32:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rzuXH-0003Ar-OJ for bug-gnu-emacs@gnu.org; Thu, 25 Apr 2024 04:32:55 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rzuXH-0006Yd-Fp for bug-gnu-emacs@gnu.org; Thu, 25 Apr 2024 04:32:55 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rzuXX-0003sc-UP for bug-gnu-emacs@gnu.org; Thu, 25 Apr 2024 04:33:12 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Apr 2024 08:33:10 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69993 X-GNU-PR-Package: emacs Original-Received: via spool by 69993-submit@debbugs.gnu.org id=B69993.171403394614465 (code B ref 69993); Thu, 25 Apr 2024 08:33:10 +0000 Original-Received: (at 69993) by debbugs.gnu.org; 25 Apr 2024 08:32:26 +0000 Original-Received: from localhost ([127.0.0.1]:60476 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzuWj-0003kf-5h for submit@debbugs.gnu.org; Thu, 25 Apr 2024 04:32:24 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]:43429) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzuWa-0003i8-Vm for 69993@debbugs.gnu.org; Thu, 25 Apr 2024 04:32:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.at; s=s31663417; t=1714033908; x=1714638708; i=rudalics@gmx.at; bh=UF5KeyHkuO0PMPUBBM4h9e7EXd7JCTOwRKAyH8PWEQE=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:Subject:To:Cc: References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=CgEvYabu82/hDSfZK39hxA+nmDvh2JVARom9nEZWoSqbX9cXqbNJRPE7e7xAOtPN v5+rLyqWODkk6SHWP3yqCAwVI8rbtl9fR2LAvW5BOXXTnPgrdRsg0HLcAuJIcIaZq Af2Q6v3VnTPEomq4MOuinbJE7/b1F9swJzCXcHo3f1G6vWcMUesTUT1MwMhYmBDOq OebQ73+iMDKVv7+rDwEDQYNsVyExCieFloLO3fL/NG0K2OYWFa7WJUsyw0e5D27A9 7zwDemsqDqMYqQdIsinPOzYnG7ZiPekS9kd68vq55ps6KiErZMFuUUcHK2NbaGabS lK3VTKnp9eMg6l04DQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from [192.168.31.113] ([213.142.97.4]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MFbVu-1rtste2cFK-00H3LI; Thu, 25 Apr 2024 10:31:48 +0200 Content-Language: en-US In-Reply-To: <86zftivhnn.fsf@mail.linkov.net> X-Provags-ID: V03:K1:1wmXBFEsl6cZVnFSVkFaa4JRQDQM1kqJDA71uxVSp3c9fqsevoU AnCLbiCjGKU4JoIt7dSjNn2EiAAZoTGMfpfBXkFHImjwg405BYkmSzhNOJT/7ILcN3vJd4A t8HpTFOp2cdQfFRgRSMIEaR+jQ7wVt24k+jk8ngiWzkMqJ1q7JzT2AHzJKCVxaHTsn1kQQW nBQrpgcNiUs4sVBAOwklg== UI-OutboundReport: notjunk:1;M01:P0:rcOzrYBN7cs=;GzorXZG3DsNObz2AhEMo1RpoxFO a4I68M5dZ8GhRK+RKiaAiWJRM3muBLBcOdxnh3PDeBIi+nJhsmreH5kvgd2saj4g5ZR38uSDR ZYK7OYLGjv41EKk3cEboMdmCz8gi03VxVesGdgn149vN+LWu/s3yMFi5wXLIjqBvqzznXP0mG xEJsjqRze+ky5K6KCnGj4Ez4B4uxO46y5njPLaQ98IWURjKuAHC3wwfqlVQsu3mUiMbYUpCex b7j02m1VS0iUIl8jmoDjZgz4i2OssQ7VD0EpQg3PZiyu40p3ZNNwb87IErdfYn4pmE9pbLLG5 GWv/3I3TgyW5LAkGHDjHioEuBOAFcHX5/scSO1jM2+duQ+enA4xcP75MkPhIwvH5v4TtacvL+ IuSMvuWvYsIFyJgAWav+Rwx3HBofxj5njgEcjp3Ajmvfsi+1ux1T9AlwVvJMIF2IJ5A2hvjiK 38Ef0TfQYEYUbKQsxKYZ4OORvXj3sbbVJWsNZRjAAJ9YcSndRcIngxYkKpKgsUs5LPlot3cD/ lA9zCr0vTPeZAQpe/6u5uPXRm6I/miG7q3b3nnggHkxnASNaZXq0U2ZlJqegO9IHS63kgB4pp c95Vlwj80IYDlP9snj0soqAfnOryKPkSOlJ3vP64w3NtZ48CicACMM/7HoudE2vXGSJ8/m4/K GLR872rsKEOUkajfDKN6HyMyNVOsTJ6AZB6v7rqYsWco17h0ah0uuAqQmJOpPFnASltV5Rx0I hsU0a+kFjH0oiOmbojjgQjrKFuItZGC+oVcvvutp2KLnJNnKfzB5IvNJ3+arlsREOhLvCcrQ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:283940 Archived-At: > There is one problem with this line: > > (add-to-list 'window-persistent-parameters '(tab-line-buffers . writable)) > > This line is needed to be able to use 'window-swap-states' > because window-state-get/window-state-put should move the window > parameter 'tab-line-buffers' to the swapped window. Why does it have to be "writable"? 'window-swap-states' doesn't care about "writability". If you really want something writable too, add a second parameter, say 'tab-line-buffer-names', with the names in it. > A third solution would be to support a lambda in > 'window-persistent-parameters' that will process > the parameter before saving. For example: > > (add-to-list 'window-persistent-parameters > '(tab-line-buffers . (lambda (p) (mapcar #'buffer-name p)))) > > Maybe this is the best thing to do? You would call that function in window.el here (when (and pers (or (not writable) (eq pers 'writable))) (setq list (cons (cons (car par) (cdr par)) list))))) iff WRITABLE is non-nil and you would not call it here in window.c /* If the window has a value for the parameter, save it. */ p->window_parameters = Fcons (Fcons (XCAR (par), XCDR (par)), p->window_parameters); I suppose. martin