unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 39380-done@debbugs.gnu.org, Wolfgang.Scherer@gmx.de
Subject: bug#39380: 26.3: Opening files in vc-dir-mode with differing root and working dir fails
Date: Wed, 12 Feb 2020 00:36:15 +0200	[thread overview]
Message-ID: <1d6bc78f-fddd-8b9e-cf3a-296b87a422f7@yandex.ru> (raw)
In-Reply-To: <837e0xe6d5.fsf@gnu.org>

Version: 27.1

On 08.02.2020 12:11, Eli Zaretskii wrote:
>> Cc: 39380@debbugs.gnu.org, Wolfgang.Scherer@gmx.de
>> From: Dmitry Gutov <dgutov@yandex.ru>
>> Date: Sat, 8 Feb 2020 12:36:46 +0300
>>
>>> If I say "hg status" in a subdirectory, I by default get file names
>>> relative to the root.  Wouldn't Mercurial users be surprised that
>>> Emacs produces a different display?  (I understand that there's a
>>> recent tendency to make it easier to produce relative file names, and
>>> there's even a config option to make that the default, but I'm asking
>>> whether we should force this behavior on users even if their
>>> preference is not to.)
>>
>> VC is intended to provide a unified interface across backends, even if
>> it's at times different from the "native" behaviors.
>>
>> Anyway, it's very easy to get the names against the root anyway: just
>> open VC-Dir there. And it's the default input: M-x vc-dir RET.
> 
> OK.

Taking this as the approval of the patch, pushed.

Using "re:" adds a bit of a performance overhead, but it's probably not 
really noticeable on small-to-medium projects (and on a big one it was 
~100ms where without it dir-status-files takes ~1s).





  reply	other threads:[~2020-02-11 22:36 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-01  0:13 bug#39380: 26.3: Opening files in vc-dir-mode with differing root and working dir fails Wolfgang Scherer
2020-02-01  7:20 ` Dmitry Gutov
2020-02-02 22:35   ` Wolfgang Scherer
2020-02-03 13:11     ` Dmitry Gutov
2020-02-04 16:04       ` Wolfgang Scherer
2020-02-05 15:56         ` Dmitry Gutov
2020-02-06 13:25           ` Wolfgang Scherer
2020-02-06 13:38             ` Dmitry Gutov
2020-02-07  9:53               ` Eli Zaretskii
2020-02-07 11:03                 ` Dmitry Gutov
2020-02-07 14:00                   ` Eli Zaretskii
2020-02-08  1:20                     ` Dmitry Gutov
2020-02-08  8:04                       ` Eli Zaretskii
2020-02-08  9:36                         ` Dmitry Gutov
2020-02-08 10:11                           ` Eli Zaretskii
2020-02-11 22:36                             ` Dmitry Gutov [this message]
2020-02-01  7:20 ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1d6bc78f-fddd-8b9e-cf3a-296b87a422f7@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=39380-done@debbugs.gnu.org \
    --cc=Wolfgang.Scherer@gmx.de \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).