From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: David Ponce via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#70093: *** SPAM *** bug#70093: Remove unnecessary `image-tests--map-equal' Date: Sat, 30 Mar 2024 23:04:28 +0100 Message-ID: <1d1367e3-d888-4a00-8204-1bb6c3607801@orange.fr> References: <877chjcxfg.fsf@breatheoutbreathe.in> Reply-To: David Ponce Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3140"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: Eli Zaretskii To: Joseph Turner , 70093@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 30 23:05:16 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rqgpA-0000bF-86 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 30 Mar 2024 23:05:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rqgow-0000BI-Vc; Sat, 30 Mar 2024 18:05:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rqgou-0000Aj-HW for bug-gnu-emacs@gnu.org; Sat, 30 Mar 2024 18:05:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rqgou-0008Vi-18 for bug-gnu-emacs@gnu.org; Sat, 30 Mar 2024 18:05:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rqgov-0001Nk-TN for bug-gnu-emacs@gnu.org; Sat, 30 Mar 2024 18:05:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: David Ponce Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 30 Mar 2024 22:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70093 X-GNU-PR-Package: emacs Original-Received: via spool by 70093-submit@debbugs.gnu.org id=B70093.17118362785234 (code B ref 70093); Sat, 30 Mar 2024 22:05:01 +0000 Original-Received: (at 70093) by debbugs.gnu.org; 30 Mar 2024 22:04:38 +0000 Original-Received: from localhost ([127.0.0.1]:46267 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rqgoY-0001ML-06 for submit@debbugs.gnu.org; Sat, 30 Mar 2024 18:04:38 -0400 Original-Received: from msa-210.smtpout.orange.fr ([193.252.23.210]:61085 helo=msa.smtpout.orange.fr) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rqgoT-0001Le-97 for 70093@debbugs.gnu.org; Sat, 30 Mar 2024 18:04:36 -0400 Original-Received: from [192.168.1.15] ([2.7.71.181]) by smtp.orange.fr with ESMTPA id qgoOrzfTX3JsoqgoOrlaSe; Sat, 30 Mar 2024 23:04:29 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.fr; s=t20230301; t=1711836269; bh=z+dZECgXy1BRoXCvaCT/8Ry2qTN+v9vjQr3Qi/L3dbY=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=rfTggW3La61zDbwwfw4oo/+wN5rVUMobHwUEDkXo/cTVQfhgIxXFv6LEhMI6HmrqM DvFWJxUueG6H5hUa704MSYj1XO4n23GIW/Ov/Vhq7rf5Vp35iL5jEe2v111QXiTrxQ w9U3vn60x0VO00HfH18I6ypkBPxoxEBzZsOvQTqTY7bfEj0OdIxWB1Yc5v8uqvydGS jhpEB/iMGF7T3TSjdtliWU/+aLy8A5RGUIbbLBNHOXqQhXS9jfHSvcORlPon2w6G8j INdBTEpKp44NfTaUKrAsabbxJHWFIDsahV22D/EN+C9SBBm7SfRtLpUHwGXXuuypw7 WgbpPbMKR3YKA== X-ME-Helo: [192.168.1.15] X-ME-Auth: ZGFfdmlkQHdhbmFkb28uZnI= X-ME-Date: Sat, 30 Mar 2024 23:04:29 +0100 X-ME-IP: 2.7.71.181 Content-Language: fr, en-US In-Reply-To: <877chjcxfg.fsf@breatheoutbreathe.in> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:282400 Archived-At: On 30/03/2024 20:44, Joseph Turner wrote: > With the resolution of bug#69992, it may be possible to remove the > `image-tests--map-equal' equality predicate from lisp/image-tests.el. > > Eli and David, would you please apply the attached patch and then run > the tests to see if we still need to allow for tolerances in > `image--compute-map-and-original-map'? > > The tests pass for me, but then again, they never failed on my machine... > > Thank you!! I'm grateful for this fun collaboration. :) > > Joseph > > Hi Joseph, Did you forget to attach the patch? I cannot find it. Anyway, I don't think the resolution of bug#69992 changed anything regarding the test `image--compute-map-and-original-map'. And to be honest I don't understand why it gives a different result on our configurations. To test, I also eval the following simple code in *scratch* buffer, which gives me consistent results on my laptop: (let* ((svg (svg-create 200 100)) (omap `(((rect . ((0 . 0) . (50 . 50))) rect-test (help-echo "rect-test")) ((circle . ((85 . 55) . 25)) circle-test (help-echo "circle-test")) ((poly . [100 0 125 0 170 50 125 50]) poly-test (help-echo "poly-test"))))) (svg-rectangle svg 0 0 50 50 :stroke-width 0 :fill "red") (svg-circle svg 85 55 25 :stroke-width 0 :fill "green") (svg-polyline svg '((100 . 0) (125 . 0) (170 . 50) (125 . 50)) :stroke-width 0 :fill "blue") (let ((image (svg-image svg :original-map omap :scale nil ;; vary scale test :rotation nil ;; vary rotation test :flip nil ;; vary flip test ))) ;; Must see the pointer and help-echo change when mouse hovers the ;; rect, circle and poly hot spots. (insert-image image) (insert ?\n) ;; Must see the same original map. (image--compute-original-map image))) Thanks!