From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#38457: 27.0.50; dabbrev-expand regression due to message change Date: Sat, 18 Jan 2020 04:00:30 +0300 Message-ID: <1ce4fada-b608-359e-b2cc-34fb8b229cf4@yandex.ru> References: <8736e3vve8.fsf@gmx.net> <87d0cubfxx.fsf@mail.linkov.net> <83a77y9k35.fsf@gnu.org> <87eex9jf14.fsf@mail.linkov.net> <83d0cs8uw8.fsf@gnu.org> <87a77uh5a5.fsf@mail.linkov.net> <83r21561qd.fsf@gnu.org> <878snd2liu.fsf@mail.linkov.net> <8336dk5k1p.fsf@gnu.org> <87a77rgajf.fsf@mail.linkov.net> <83immf3pba.fsf@gnu.org> <87y2vawly3.fsf@mail.linkov.net> <83tv5x38kq.fsf@gnu.org> <87d0clxjaq.fsf@mail.linkov.net> <83y2v81g5s.fsf@gnu.org> <87fthgdkq9.fsf@mail.linkov.net> <37de1822-26c5-b45a-e5b9-3ab492507b97@yandex.ru> <87tv5tfiao.fsf@mail.linkov.net> <393793a7-236f-dfce-edc7-100472ad9be2@yandex.ru> <874kxqpsse.fsf@mail.linkov.net> <416b122a-287e-5c47-8979-feb22b2bba81@yandex.ru> <87sgl9p9q3.fsf@mail.linkov.net> <858f4dc2-a955-9ce5-6cf7-aa2c00c2f01d@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="113059"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 Cc: 38457@debbugs.gnu.org, Juri Linkov To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 18 02:01:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iscUD-000TMp-7w for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 18 Jan 2020 02:01:13 +0100 Original-Received: from localhost ([::1]:36024 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iscUC-0006BY-Aa for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 17 Jan 2020 20:01:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40497) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iscU4-0006BS-Bs for bug-gnu-emacs@gnu.org; Fri, 17 Jan 2020 20:01:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iscU2-0005Bk-Dd for bug-gnu-emacs@gnu.org; Fri, 17 Jan 2020 20:01:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34358) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iscU1-0005B6-L9 for bug-gnu-emacs@gnu.org; Fri, 17 Jan 2020 20:01:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iscU1-0001yC-K6 for bug-gnu-emacs@gnu.org; Fri, 17 Jan 2020 20:01:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Jan 2020 01:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38457 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 38457-submit@debbugs.gnu.org id=B38457.15793092437531 (code B ref 38457); Sat, 18 Jan 2020 01:01:01 +0000 Original-Received: (at 38457) by debbugs.gnu.org; 18 Jan 2020 01:00:43 +0000 Original-Received: from localhost ([127.0.0.1]:40331 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iscTi-0001xP-Tc for submit@debbugs.gnu.org; Fri, 17 Jan 2020 20:00:43 -0500 Original-Received: from mail-lf1-f43.google.com ([209.85.167.43]:46083) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iscTd-0001x9-H8 for 38457@debbugs.gnu.org; Fri, 17 Jan 2020 20:00:41 -0500 Original-Received: by mail-lf1-f43.google.com with SMTP id f15so19683323lfl.13 for <38457@debbugs.gnu.org>; Fri, 17 Jan 2020 17:00:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=j3dPF1039iyFmjiHYbIY7fsY7TU7UpQqfv9j+DzPBFQ=; b=SyRj91KB93r7hmQuAtsZweOWQ1W6tI8SVe/0qpbqPG3qw1hbp1Y8R/3IbZCUnRL/IU zTbJUVQhwZaGej7/gQw78UIbvTXQbRfQR8R8bfRscF2aMMFjlcBPY+Ixmw1xs8NrhYfd pQYXVw3ZmTIjmSwDOCNpv94CC5Jcaj3vHq9FClqysFQGD30KvDxyeTWZxoPQGf3C57EH otUSCkVTPNQFkNZep2j8Ndkdn47mPGqzUMbiGwUe2DOPW7SAmQdEz/JCrCR7lTtP+W2G 57YVmszJfRWNwdmMZMd7RL6DcmEIedLGyLFdrukhsQ85iAvwVqQykxXypTNV0+bTCZO/ L/ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:from:to:cc:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=j3dPF1039iyFmjiHYbIY7fsY7TU7UpQqfv9j+DzPBFQ=; b=Ecm+akV7i9bf3gi4tJova/OZ0k1emCPzIafMy1t4VfeKIpR7nXmZj36Wb8AiZZBeGG DKQSxUTNGesJhmGQ6efqEsdjyN+75axwBBVxFurkNZcgbGORXkh/qUjBsvMy8y84PNS4 agDvroDJqP74kyurWQZuoJl3Orp6op2ZRKB228nL4Z6KexGFVHp6Z6AIe/v86tDAPwBc o9FDTNh2EGaIFedp/7vDjHXI4VVZUeVF/O4CtbFrO5HF09UP8Bk3JbR/o2Sn82xwn57B GPXg+C2UqA2Nv1pprDWtzL+lF84cIgyc7kSj0AlWiWvYRAd5x5lGJGizgFffBv3obpNs Ra1g== X-Gm-Message-State: APjAAAUoRpreKY+EWnmMdLrLrJvEBXk9KmVyne9OeY0ia/44xc4TmQjt HWUyJbjCv2gHyGeLTgjpB1aGniFq6V0= X-Google-Smtp-Source: APXvYqxwaxsXnktdkLkuWkBBVvvQpAhFsswnaIQX0aJqwtkl0xPHxbq7zqWBu4zwal/8lATZCK1jow== X-Received: by 2002:a19:ac43:: with SMTP id r3mr7230335lfc.156.1579309231087; Fri, 17 Jan 2020 17:00:31 -0800 (PST) Original-Received: from [192.168.1.142] ([178.252.127.239]) by smtp.googlemail.com with ESMTPSA id o10sm12975384lfn.20.2020.01.17.17.00.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 17 Jan 2020 17:00:30 -0800 (PST) In-Reply-To: <858f4dc2-a955-9ce5-6cf7-aa2c00c2f01d@yandex.ru> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:174781 Archived-At: Eli, don't you think we should iron out this new feature's interaction with icomplete and ido before the release? On 25.12.2019 19:30, Dmitry Gutov wrote: > >> Could ido-mode use an overlay the same way as it's used in icomplete >> that plays nicely with the set-minibuffer-message overlay? > > This seems to work, but it needs more testing: > > diff --git a/lisp/ido.el b/lisp/ido.el > index 79f259b819..d47450fc40 100644 > --- a/lisp/ido.el > +++ b/lisp/ido.el > @@ -4492,6 +4492,8 @@ ido-initiate-auto-merge >      (ido-tidy)) >        (throw 'ido contents)))) > > +(defvar ido--overlay nil) > + >  (defun ido-exhibit () >    "Post command hook for Ido." >    ;; Find matching files and display a list in the minibuffer. > @@ -4726,7 +4728,12 @@ ido-exhibit >      (let ((inf (ido-completions contents))) >        (setq ido-show-confirm-message nil) >        (ido-trace "inf" inf) > -      (insert inf)) > +          (when ido--overlay > +            (delete-overlay ido--overlay)) > +          (let ((o (make-overlay (point-max) (point-max) nil t t))) > +            (when (> (length inf) 0) > +              (put-text-property 0 1 'cursor t inf)) > +            (overlay-put o 'after-string inf) > +            (setq ido--overlay o))) >      )))) > >  (defun ido-completions (name)