From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus Date: Mon, 13 Dec 2021 10:13:28 -0800 Message-ID: <1cc8a566-717a-e391-e9f4-98cd6ad81eac@gmail.com> References: <86tufn5jn9.fsf@mail.linkov.net> <86pmqa14fc.fsf@mail.linkov.net> <15eebcb1-b67a-8363-bc23-cf113913856f@gmail.com> <86h7bkhlo7.fsf@mail.linkov.net> <37047ada-fa33-88dd-5237-769611fec61b@gmail.com> <83wnkfw8ud.fsf@gnu.org> <86ilvysyq3.fsf@mail.linkov.net> <834k7ix4ij.fsf@gnu.org> <86pmq6taeb.fsf@mail.linkov.net> <83czm6unfs.fsf@gnu.org> <414be477-34d4-c777-f623-3e0e59c0dd08@gmail.com> <83o85mpaqb.fsf@gnu.org> <83tufdmu4d.fsf@gnu.org> <83pmq0n16d.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20992"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 52293@debbugs.gnu.org, juri@linkov.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 13 19:14:20 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mwpq8-0005Ah-3K for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 13 Dec 2021 19:14:20 +0100 Original-Received: from localhost ([::1]:32954 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mwpq6-00077h-Mc for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 13 Dec 2021 13:14:18 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:47910) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mwppq-00075j-Cs for bug-gnu-emacs@gnu.org; Mon, 13 Dec 2021 13:14:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45173) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mwppq-0002uE-0B for bug-gnu-emacs@gnu.org; Mon, 13 Dec 2021 13:14:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mwppp-0000rM-L4 for bug-gnu-emacs@gnu.org; Mon, 13 Dec 2021 13:14:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 13 Dec 2021 18:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.16394192203256 (code B ref 52293); Mon, 13 Dec 2021 18:14:01 +0000 Original-Received: (at 52293) by debbugs.gnu.org; 13 Dec 2021 18:13:40 +0000 Original-Received: from localhost ([127.0.0.1]:56716 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwppT-0000qR-JE for submit@debbugs.gnu.org; Mon, 13 Dec 2021 13:13:39 -0500 Original-Received: from mail-pj1-f54.google.com ([209.85.216.54]:52787) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwppR-0000qD-3U for 52293@debbugs.gnu.org; Mon, 13 Dec 2021 13:13:38 -0500 Original-Received: by mail-pj1-f54.google.com with SMTP id h24so12462574pjq.2 for <52293@debbugs.gnu.org>; Mon, 13 Dec 2021 10:13:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=9I9oKu/CQY+TcgND4YyJOsMrLFPjIBbyIERUHimf3tI=; b=ZVvZny39f1BGzFzsRNfHtKL2o+ScK+gxnfjYLtBNuzPSFOLLKRIxcA8MMenfXDxcJk X+8n1Oa/2ErbCV0RViuAZNByviIrWMdApV5ZiKt2/G94EOk/F3RUnvAYsFQhYezFfCJY /hlbNh12rhh70/hWmdrHoEOMab23prYx6K2O8FD1PNXBvske5koI0HpC5H5B1ocLdOJY /kYrsPcNqwzYUcXidRcGzozN5at6xaZSNLvk5lvN5V8SHkAaBg72BTCBZIapDCeqtz40 GXRhvLonMY18f/9tBy4omKJfLPpWpCqW2lGP/5+M5sO3JmNjPE6G+Ks2NGlUoI1jpWsX aJKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=9I9oKu/CQY+TcgND4YyJOsMrLFPjIBbyIERUHimf3tI=; b=lrxkebjPowS7zFpNxPsFeEMyF4Fde1kJXZGqvO8lvMsCwODM2wL1scmU5O25HkPeM0 li07m6fcO8Gh8OehBySlo+tq21ZHF18c3PdndiiHnZDJu6IVBSYuj4itFrO6By7ET2Pb b9A7DKDqf1BooFkUsP5OBBbniwV27c33y1qilAUyrdUM4O3D9hh44kNiLEkWKcrUPWbo t4wkswjv+kGGJFa6J+0MuzhXZQlbd0ddmeQsIJGCShuknwF8kBkgXBAypG0X5y667fHR Oh/AWKdBaqbwyWTUO/yh0nw6oS8wO0TcfkRB2iGg8yOIlo5gsKuk4BzxsnoYYKX8ei1s ejIQ== X-Gm-Message-State: AOAM530e8MWnMXvzX4SlKxIH0ZPKsG426zAMmrP8lHoDcG4+OWsSZYl2 CmB+Yun4/ZQ+XjZryF2sttE= X-Google-Smtp-Source: ABdhPJzrVxeAExSXYHInvqWvzBVxo2F4n96ghFNlCrDrAoA7j3f+3D//L6Z/ZzfViw2Vrby1+P9Gsg== X-Received: by 2002:a17:90a:6b44:: with SMTP id x4mr32515pjl.27.1639419211321; Mon, 13 Dec 2021 10:13:31 -0800 (PST) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id z2sm13864925pfh.188.2021.12.13.10.13.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Dec 2021 10:13:30 -0800 (PST) In-Reply-To: <83pmq0n16d.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:222333 Archived-At: On 12/13/2021 4:23 AM, Eli Zaretskii wrote: >> Cc: 52293@debbugs.gnu.org, juri@linkov.net >> From: Jim Porter >> Date: Sun, 12 Dec 2021 13:59:16 -0800 >> >> On 12/12/2021 12:43 PM, Eli Zaretskii wrote: >>>> Cc: 52293@debbugs.gnu.org, juri@linkov.net >>>> From: Jim Porter >>>> Date: Sun, 12 Dec 2021 12:27:34 -0800 >>>> >>>> On 12/11/2021 11:02 PM, Eli Zaretskii wrote: >>>>> Are you saying that we will be recommending a convention for separator >>>>> names only for menus popped up in context-menu-mode? Does it make >>>>> sense to have such a specialized convention? Isn't it possible to >>>>> show context menus outside of the context-menu-mode? >>>> >>>> No, I think this convention should be recommended for separators used >>>> anywhere in Emacs going forward. >>> >>> Ok, so then the effect of this change is wide, as I envisioned, and >>> compatibility considerations still apply. >> >> I'm also ok with applying this naming convention *only* to context menus >> and not treating this as a general guideline; that would still make it >> easier to remember the names of each context menu separator without >> having to double-check the source code. > > I don't think this would make sense, and I said that above. I don't really have a preference about what we recommend in the documentation. We don't need to recommend anything at all. Above, I was just referring to changing the separator names within context-menu-mode functions to use a single style (`foo-separator'), not necessarily documenting/recommending it. Even the code change I only have a very slight preference for. I was just reading through the context-menu code to understand it, saw that some separators were named `foo-separator' and others named `separator-foo', and thought that was a bit odd. The only "problem" (and it's barely a problem) is that programmers writing code referring to these separators later (e.g. with `define-key-after') might get the names mixed up if they're not paying attention. Since I came across it, I thought I'd submit a patch in case the maintainers wanted it. However, if it's controversial (or just too late in the release cycle to make a small compatibility break), I don't have a problem with closing bug#52286 as wontfix. It's such a minor issue that I really don't see any major downside to wontfixing the bug if there's any hesitation about it.