From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#38406: 27.0.50; post-self-insert-hook does not hold its contract in cc-mode derived modes Date: Thu, 5 Dec 2019 22:44:55 +0200 Message-ID: <1c3dea25-5606-76d5-b35d-2486583b8f38@yandex.ru> References: <20191130143638.GA6716@ACM> <20191201150738.GB5085@ACM> <83imn0lyed.fsf@gnu.org> <20191201192709.GE5085@ACM> <83blsrn58a.fsf@gnu.org> <20191204204159.GA7587@ACM> <798bda88-41a7-361c-c01b-22ca4d6138e0@yandex.ru> <20191205191459.GB6252@ACM> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="222908"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 Cc: yyoncho@gmail.com, 38406@debbugs.gnu.org To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 05 21:46:29 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1icy16-000vq3-IS for geb-bug-gnu-emacs@m.gmane.org; Thu, 05 Dec 2019 21:46:28 +0100 Original-Received: from localhost ([::1]:60838 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1icy15-0003M4-4E for geb-bug-gnu-emacs@m.gmane.org; Thu, 05 Dec 2019 15:46:27 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47651) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1icy0q-0003L3-9J for bug-gnu-emacs@gnu.org; Thu, 05 Dec 2019 15:46:13 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1icy0k-0001c3-Dl for bug-gnu-emacs@gnu.org; Thu, 05 Dec 2019 15:46:07 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39367) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1icy0f-0001XJ-Vn for bug-gnu-emacs@gnu.org; Thu, 05 Dec 2019 15:46:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1icy0f-0006jQ-Tm for bug-gnu-emacs@gnu.org; Thu, 05 Dec 2019 15:46:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Dec 2019 20:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38406 X-GNU-PR-Package: emacs Original-Received: via spool by 38406-submit@debbugs.gnu.org id=B38406.157557871723412 (code B ref 38406); Thu, 05 Dec 2019 20:46:01 +0000 Original-Received: (at 38406) by debbugs.gnu.org; 5 Dec 2019 20:45:17 +0000 Original-Received: from localhost ([127.0.0.1]:45340 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1icxzx-00065J-90 for submit@debbugs.gnu.org; Thu, 05 Dec 2019 15:45:17 -0500 Original-Received: from mail-wm1-f66.google.com ([209.85.128.66]:39657) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1icxzv-0005zT-Uc for 38406@debbugs.gnu.org; Thu, 05 Dec 2019 15:45:16 -0500 Original-Received: by mail-wm1-f66.google.com with SMTP id s14so5144561wmh.4 for <38406@debbugs.gnu.org>; Thu, 05 Dec 2019 12:45:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=udX4OWfgyPohGBMpWeBfrY+GeW3IsXXZq3DEc1scEHY=; b=I7JSuIquTUZoQ5ctlZrrjL678RtfgVvqA6sI4J2pEY5YJw7Fpaw96NjzLbO0U8PrxP irgauWI9uhlIJ3Y214K6OHxVqOPNla8/kiZa09n5NE1h9tmNatczGGg/Q99ymX7da5hJ HNjOUcHrWBeq2F7oD8XznywB+PDWuHaqBlt2q980Dty5cDobNJbsnAnv1mv8CcByfw12 tU1yeO6qa8dlRuAnPEQOJbv49IDuhTagYscRqNf7yU5QRK8X956UMaBFfd7kvgrgOGgJ +8bn0EqNWbOcJ/nEsgVSCGs3APBEgoJh2+izDElBqHR00KbjTxxuSt7hwWCAvezE2Qba 36JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=udX4OWfgyPohGBMpWeBfrY+GeW3IsXXZq3DEc1scEHY=; b=ItSCgNL3X8s9X3zWY+7DArfQM5SzvPO1kyoEdLqefz45DwOgp2aiS/u3+MAiLSPZ9v R9g2VF1sITskuxncBGK2+9tOtSmLJZH0OD/QS2Bgzyu3eDaLUFAvNRt6aEOhsUaoH2nT SVywOJlQG+Zd6gslvak0xRbiTd6HQ0UhYyUupyKINqz4deg1t4KvdLDLGa/xtqZy8yKQ t3YCvsnDjK58CCIwhVD6qVvtTTU0lVqvw841tP/C2V9RLfxvAGX5mR8XLYCnJxMVeVQK UB9eoSnOZXpqJrhi9Hok2c2nnT0NODi5oPGitSUZQlDBJo2oLaouf5NTAXkCLkGywLmJ Jeeg== X-Gm-Message-State: APjAAAUDRz8yXFHA4LVnOtW+a3OYfI7uaXoOfDoOi/1+a1d1eht3zcJh VC75QlwtbheBrSRFI4G38GRCRd1H X-Google-Smtp-Source: APXvYqzAo8bIGqCSR0vBD1byymR3Ybfbwj1cut6FUDxy7iUo4pp6sHMwa1Slqh3/q6MwH39FKt+gAQ== X-Received: by 2002:a05:600c:2283:: with SMTP id 3mr7172081wmf.100.1575578709853; Thu, 05 Dec 2019 12:45:09 -0800 (PST) Original-Received: from [192.168.0.5] ([212.50.117.215]) by smtp.googlemail.com with ESMTPSA id c72sm1129988wmd.11.2019.12.05.12.45.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Dec 2019 12:45:08 -0800 (PST) In-Reply-To: <20191205191459.GB6252@ACM> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172934 Archived-At: On 05.12.2019 21:14, Alan Mackenzie wrote: > On Wed, Dec 04, 2019 at 23:04:27 +0200, Dmitry Gutov wrote: >> On 04.12.2019 22:41, Alan Mackenzie wrote: >>> +(defvar c--unsafe-post-self-insert-hook-functions >>> + '(smie-blink-matching-open >>> + electric-pair-post-self-insert-function >>> + blink-paren-post-self-insert-function >>> + electric-indent-post-self-insert-function >>> + electric-layout-post-self-insert-function >>> + electric-quote-post-self-insert-function) >>> + "Known unsafe functions when members of `post-self-insert-hook' in CC Mode") > >> I don't see how filtering out a bunch of popular consumers of >> post-self-insert-hook can make it "act as per its contract again". > > Think of it more as "filtering in" all functions on > post-self-insert-hook _except_ the ones mentioned, which are harmful in > CC Mode. blink-paren is harmful for CC Mode? Or is it reimplemented, like other features (e.g. electric-*), inside CC Mode? In the latter case, I think CC Mode should just disable the respective minor modes/variables locally and call it a day (the hook won't be used them, so no need for filtering). Of course, ideally users of recent enough Emacs would be able to disable these built-in features and switch on the generic ones instead.