From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#20148: 24.4: function `bookmark-get-bookmark' Date: Thu, 19 Mar 2015 22:04:42 -0700 (PDT) Message-ID: <1c3990cf-d1db-45e5-8b31-9055cdab20bd@default> References: <550BA52D.1080805@gmx.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1426827932 21613 80.91.229.3 (20 Mar 2015 05:05:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 20 Mar 2015 05:05:32 +0000 (UTC) To: Boruch Baum , 20148@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Mar 20 06:05:13 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YYp7Q-000723-DR for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Mar 2015 06:05:12 +0100 Original-Received: from localhost ([::1]:42363 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYp7P-0003VA-Pe for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Mar 2015 01:05:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41642) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYp7M-0003So-94 for bug-gnu-emacs@gnu.org; Fri, 20 Mar 2015 01:05:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYp7H-0001YJ-9d for bug-gnu-emacs@gnu.org; Fri, 20 Mar 2015 01:05:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:40713) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYp7H-0001Xu-5q for bug-gnu-emacs@gnu.org; Fri, 20 Mar 2015 01:05:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YYp7G-0000tF-Qi for bug-gnu-emacs@gnu.org; Fri, 20 Mar 2015 01:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Mar 2015 05:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20148 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20148-submit@debbugs.gnu.org id=B20148.14268278933404 (code B ref 20148); Fri, 20 Mar 2015 05:05:02 +0000 Original-Received: (at 20148) by debbugs.gnu.org; 20 Mar 2015 05:04:53 +0000 Original-Received: from localhost ([127.0.0.1]:58722 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YYp77-0000sq-1Y for submit@debbugs.gnu.org; Fri, 20 Mar 2015 01:04:53 -0400 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:48582) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YYp74-0000sc-Nh for 20148@debbugs.gnu.org; Fri, 20 Mar 2015 01:04:51 -0400 Original-Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id t2K54h30029806 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 20 Mar 2015 05:04:44 GMT Original-Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id t2K54hun024591 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 20 Mar 2015 05:04:43 GMT Original-Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by aserv0121.oracle.com (8.13.8/8.13.8) with ESMTP id t2K54h2p021774; Fri, 20 Mar 2015 05:04:43 GMT In-Reply-To: <550BA52D.1080805@gmx.com> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8.2 (807160) [OL 12.0.6691.5000 (x86)] X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:100681 Archived-At: > Function `bookmark-get-bookmark' ... >=20 > 1] tests for the existence of a bookmark by checking whether the input > string matches a cons cell. This casts a net much wider than desirable, > and might better be (assoc bookmark-name-or-record bookmark-alist). See the actual code. > 2] returns only a string value on error, without passing nil back to the > calling function. >=20 > My usage case is that I was scripting a function to find org-mode files > in a directory tree, and add them to a bookmark list if they aren't > already bookmarked according to my naming convention. Originally, I had > tried checking for the existence of a bookmark using a few of the > bookmark.el functions, such as bookmark-get-bookmark, but that looked > inconvenient because they returned string values on failure. See the actual code. The doc string neglects to mention the optional argument. It should say something like this (taken from Bookmark+): Non-nil optional arg NOERROR means return nil if BOOKMARK is not a valid bookmark. If NOERROR is nil then raise an error in this case.