From: Drew Adams <drew.adams@oracle.com>
To: Boruch Baum <boruch_baum@gmx.com>, 20148@debbugs.gnu.org
Subject: bug#20148: 24.4: function `bookmark-get-bookmark'
Date: Thu, 19 Mar 2015 22:04:42 -0700 (PDT) [thread overview]
Message-ID: <1c3990cf-d1db-45e5-8b31-9055cdab20bd@default> (raw)
In-Reply-To: <550BA52D.1080805@gmx.com>
> Function `bookmark-get-bookmark' ...
>
> 1] tests for the existence of a bookmark by checking whether the input
> string matches a cons cell. This casts a net much wider than desirable,
> and might better be (assoc bookmark-name-or-record bookmark-alist).
See the actual code.
> 2] returns only a string value on error, without passing nil back to the
> calling function.
>
> My usage case is that I was scripting a function to find org-mode files
> in a directory tree, and add them to a bookmark list if they aren't
> already bookmarked according to my naming convention. Originally, I had
> tried checking for the existence of a bookmark using a few of the
> bookmark.el functions, such as bookmark-get-bookmark, but that looked
> inconvenient because they returned string values on failure.
See the actual code.
The doc string neglects to mention the optional argument. It should
say something like this (taken from Bookmark+):
Non-nil optional arg NOERROR means return nil if BOOKMARK is not a
valid bookmark. If NOERROR is nil then raise an error in this case.
next prev parent reply other threads:[~2015-03-20 5:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 4:42 bug#20148: 24.4: function `bookmark-get-bookmark' Boruch Baum
2015-03-20 5:04 ` Drew Adams [this message]
2015-03-20 11:04 ` Boruch Baum
2015-03-20 14:31 ` Stefan Monnier
2015-03-20 14:44 ` Boruch Baum
2019-05-26 10:12 ` Stefan Kangas
2019-05-30 12:38 ` Basil L. Contovounesios
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c3990cf-d1db-45e5-8b31-9055cdab20bd@default \
--to=drew.adams@oracle.com \
--cc=20148@debbugs.gnu.org \
--cc=boruch_baum@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).