From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Phil Sainty Newsgroups: gmane.emacs.bugs Subject: bug#33601: 26; Add macro `with-hook-added' Date: Tue, 04 Dec 2018 12:13:55 +1300 Message-ID: <1c26ed105b9c1262e1688018d32d4957@webmail.orcon.net.nz> References: <6871371f-5c46-46f2-9a92-b1c154ec5a73@default> <0b15a9be-6f19-4569-93fd-1a09a6456b25@default> <06d76795115ae2a95f56694a904100ba@webmail.orcon.net.nz> <9bda9cb4-42bb-4e89-b73e-fb0b62443b6c@default> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1543878727 29994 195.159.176.226 (3 Dec 2018 23:12:07 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 3 Dec 2018 23:12:07 +0000 (UTC) User-Agent: Orcon Webmail Cc: 33601@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Dec 04 00:12:03 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gTxNi-0007iN-TY for geb-bug-gnu-emacs@m.gmane.org; Tue, 04 Dec 2018 00:12:03 +0100 Original-Received: from localhost ([::1]:53279 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gTxPp-0006hR-D6 for geb-bug-gnu-emacs@m.gmane.org; Mon, 03 Dec 2018 18:14:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38061) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gTxPh-0006gA-N6 for bug-gnu-emacs@gnu.org; Mon, 03 Dec 2018 18:14:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gTxPe-0002bn-94 for bug-gnu-emacs@gnu.org; Mon, 03 Dec 2018 18:14:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55310) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gTxPe-0002bN-2y for bug-gnu-emacs@gnu.org; Mon, 03 Dec 2018 18:14:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gTxPd-0003Gf-Mx for bug-gnu-emacs@gnu.org; Mon, 03 Dec 2018 18:14:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Phil Sainty Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 03 Dec 2018 23:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33601 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33601-submit@debbugs.gnu.org id=B33601.154387883912546 (code B ref 33601); Mon, 03 Dec 2018 23:14:01 +0000 Original-Received: (at 33601) by debbugs.gnu.org; 3 Dec 2018 23:13:59 +0000 Original-Received: from localhost ([127.0.0.1]:59568 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gTxPb-0003GI-JJ for submit@debbugs.gnu.org; Mon, 03 Dec 2018 18:13:59 -0500 Original-Received: from smtp-2.orcon.net.nz ([60.234.4.43]:52342) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gTxPZ-0003G8-HQ for 33601@debbugs.gnu.org; Mon, 03 Dec 2018 18:13:58 -0500 Original-Received: from [10.253.37.70] (port=34272 helo=webmail.orcon.net.nz) by smtp-2.orcon.net.nz with esmtpa (Exim 4.86_2) (envelope-from ) id 1gTxPX-0006CM-9w; Tue, 04 Dec 2018 12:13:55 +1300 Original-Received: from wlgwil-nat-office.catalyst.net.nz ([202.78.240.7]) via [10.253.37.253] by webmail.orcon.net.nz with HTTP (HTTP/1.1 POST); Tue, 04 Dec 2018 12:13:55 +1300 In-Reply-To: <9bda9cb4-42bb-4e89-b73e-fb0b62443b6c@default> X-Sender: psainty@orcon.net.nz X-GeoIP: -- X-Spam_score: -2.9 X-Spam_score_int: -28 X-Spam_bar: -- X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:153040 Archived-At: On 2018-12-04 11:50, Drew Adams wrote: > The real question is whether such a macro is useful. > I think it can be. I gave a couple examples in bug > #33595. It was those examples that made me think > such a macro might be useful. I certainly think it can be useful. On a couple of occasions I've used code which does a similar thing with advice -- adding temporary advice, running a body, and removing the advice again. In both cases one could argue for a more persistent hook or advice which performs its own check to see whether it should do things, but that might also entail writing a new wrapper to perform the test, so there's appeal in a with-* approach (particularly for things which are wanted only very occasionally). -Phil