From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#52293: [External] : bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus Date: Mon, 13 Dec 2021 21:41:06 -0800 Message-ID: <1c1995a2-c033-51c8-4aa6-7458ad07c75c@gmail.com> References: <86tufn5jn9.fsf@mail.linkov.net> <86pmqa14fc.fsf@mail.linkov.net> <15eebcb1-b67a-8363-bc23-cf113913856f@gmail.com> <86h7bkhlo7.fsf@mail.linkov.net> <37047ada-fa33-88dd-5237-769611fec61b@gmail.com> <83wnkfw8ud.fsf@gnu.org> <86ilvysyq3.fsf@mail.linkov.net> <834k7ix4ij.fsf@gnu.org> <86pmq6taeb.fsf@mail.linkov.net> <83czm6unfs.fsf@gnu.org> <414be477-34d4-c777-f623-3e0e59c0dd08@gmail.com> <83o85mpaqb.fsf@gnu.org> <8e9b29cd-8700-1a60-1d91-b6995d8f433a@gmail.com> <86czm0eue5.fsf@mail.linkov.net> <8c440269-262a-ba78-6630-d3f90c2fcc19@gmail.com> <86fsqwmig7.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6617"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "52293@debbugs.gnu.org" <52293@debbugs.gnu.org> To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 14 06:42:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mx0Zn-0001XL-TI for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 14 Dec 2021 06:42:11 +0100 Original-Received: from localhost ([::1]:44566 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mx0Zm-0000aG-AN for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 14 Dec 2021 00:42:10 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:37500) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mx0Ze-0000a8-CD for bug-gnu-emacs@gnu.org; Tue, 14 Dec 2021 00:42:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45785) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mx0Ze-0008Tz-3d for bug-gnu-emacs@gnu.org; Tue, 14 Dec 2021 00:42:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mx0Zd-0005DK-Li for bug-gnu-emacs@gnu.org; Tue, 14 Dec 2021 00:42:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 Dec 2021 05:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.163946047619988 (code B ref 52293); Tue, 14 Dec 2021 05:42:01 +0000 Original-Received: (at 52293) by debbugs.gnu.org; 14 Dec 2021 05:41:16 +0000 Original-Received: from localhost ([127.0.0.1]:57331 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mx0Yu-0005CJ-HO for submit@debbugs.gnu.org; Tue, 14 Dec 2021 00:41:16 -0500 Original-Received: from mail-pj1-f49.google.com ([209.85.216.49]:51012) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mx0Yq-0005C4-Lc for 52293@debbugs.gnu.org; Tue, 14 Dec 2021 00:41:15 -0500 Original-Received: by mail-pj1-f49.google.com with SMTP id x7so13542742pjn.0 for <52293@debbugs.gnu.org>; Mon, 13 Dec 2021 21:41:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=hxN1MqMCHIhmzZ9AoU8rNrZpha2n+Y2YOgmBDYbVwYM=; b=CnPZthMwMF+G8KOZ3wu7MYuX9dvtbA9CLFGflIpyXs/HPvwssLQA9cVrYIP+y6ui2S RntaAL0ZUModeHax1EItOqSBrH0Okcr5vD6BTWK2e1VIjRo+kUSH3rmC8UMT2p388vNH V4Bdmy6zYZ6EMT0ZlWei+XKf7roiUzclhRLYn1qjB0BLxPCHe/+cKuipcUXKViCUw47W gbtY8lz6YmVbXh/YvKueGXF/b5v+rnbkld2qS317I73rSFx1G0qel1PgSwki2TqCFcAR QiP112DjdP8UK8M8fbUtJHHUagaeOmPblFazlQHAK8KoKCx5LeTeKRAu0JhUD3axnXe3 21ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=hxN1MqMCHIhmzZ9AoU8rNrZpha2n+Y2YOgmBDYbVwYM=; b=AJDNPA73VFS74gLIDC7Fu0ka1r1SG5liT9kg5jDaqW9M4KZqGksLeXs2+M2iqsGT4I ee4qpDUWdXKUkL9ZYrpBR4Kmw/CzDFfCvtQ/WNyGLJA3XEZr9pH/sm8W3fCydEtR0VPc y1MluWbRzXH32aiLdZ5RN7/ZE2DqtXEAvcpizo2LdsLoyaAUAOnVYMS26fvwL29vWpBh L4++7XBuCkoaMH34r/Rn86HM6/PYQe7Pj3Roman+/Al0+NqMOvqH9ik9BwyQ/NnMbNaD 3U/DoHgUg2q7z/wX2mo7F5ofgqHKOjUZeGo5KIRWDg7oLLASLmVCxidZ4qWbiNasTcUD vW5A== X-Gm-Message-State: AOAM530oCldExmK/UZvNvHWlomPUBx2YkAC7coD9Ed3VVF+e8Rabqr0V BqTkcgHLGed7CmwDG7rx/DAErjbGQgg= X-Google-Smtp-Source: ABdhPJyD/5Z+1t/7EZjqPgbpEOZLW862MLDSVu5THxZ1EhEtQoeR8vW//Sf92zWIMaf/I3rpJUuJ+A== X-Received: by 2002:a17:903:22c4:b0:141:deda:a744 with SMTP id y4-20020a17090322c400b00141dedaa744mr3136709plg.25.1639460466663; Mon, 13 Dec 2021 21:41:06 -0800 (PST) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id d9sm1086849pjs.2.2021.12.13.21.41.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Dec 2021 21:41:06 -0800 (PST) In-Reply-To: <86fsqwmig7.fsf@mail.linkov.net> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:222354 Archived-At: On 12/13/2021 10:58 AM, Juri Linkov wrote: > I agree that using an extend-format separator is a good idea, > especially if we'll provide a special variable that will contain it. > But I don't understand why opt-in. I think opt-out would be better > since most of the time the users want to have de-duplicated menus. One benefit to this being opt-in would be that it would be possible to (eventually) support the de-duplication behavior for *all* menus without us having to worry about breaking compatibility for other menus[1]. If we provide a constant for people to use like in your earlier example[2], it would be still be reasonably simple to use. I think it would be nice to (again, eventually) support this for all menus, since it's probably useful in some other places, and it would keep the differences between specific menus' behaviors to a minimum. > Maybe better first to try fixing the problem using the separators? > When this doesn't help, only then we could consider alternatives. Ok, let's stick with deduplication then. I'll try to write a patch that doesn't require `top-separator', since that's easy for programmers to forget about (no other menu requires doing that to put items at the beginning). [1] It's not *likely* that people want consecutive separators in other menus, but I think it's good to be on the safe side and not break compatibility for anyone who does want that. [2] https://lists.gnu.org/archive/html/bug-gnu-emacs/2021-12/msg01100.html