From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Phil Sainty Newsgroups: gmane.emacs.bugs Subject: bug#35351: 27.0.50; Enable derived modes to run their own very-early 'change-major-mode-hook' code Date: Tue, 23 Apr 2019 15:52:18 +1200 Message-ID: <1c020e77-3a71-4b84-c15d-752062b8b8db@orcon.net.nz> References: <85237c18-768d-089b-221a-fe70b0ba4379@orcon.net.nz> <7db75b50-1925-8c1e-acc5-c393b701e6a3@orcon.net.nz> <3a0b9268-4800-1513-8422-065a74bb6b36@orcon.net.nz> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="181629"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 Cc: 35351@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Apr 23 05:53:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hImUZ-000l86-Mw for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Apr 2019 05:53:11 +0200 Original-Received: from localhost ([127.0.0.1]:47606 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hImUY-00065Y-LR for geb-bug-gnu-emacs@m.gmane.org; Mon, 22 Apr 2019 23:53:10 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:54429) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hImUS-00065I-ID for bug-gnu-emacs@gnu.org; Mon, 22 Apr 2019 23:53:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hImUQ-0002ZB-LB for bug-gnu-emacs@gnu.org; Mon, 22 Apr 2019 23:53:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38586) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hImUQ-0002Yk-HJ for bug-gnu-emacs@gnu.org; Mon, 22 Apr 2019 23:53:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hImUQ-0005j3-BS for bug-gnu-emacs@gnu.org; Mon, 22 Apr 2019 23:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Phil Sainty Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Apr 2019 03:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35351 X-GNU-PR-Package: emacs Original-Received: via spool by 35351-submit@debbugs.gnu.org id=B35351.155599154421941 (code B ref 35351); Tue, 23 Apr 2019 03:53:02 +0000 Original-Received: (at 35351) by debbugs.gnu.org; 23 Apr 2019 03:52:24 +0000 Original-Received: from localhost ([127.0.0.1]:52130 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hImTo-0005ho-IS for submit@debbugs.gnu.org; Mon, 22 Apr 2019 23:52:24 -0400 Original-Received: from smtp-2.orcon.net.nz ([60.234.4.43]:53735) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hImTm-0005hf-1z for 35351@debbugs.gnu.org; Mon, 22 Apr 2019 23:52:22 -0400 Original-Received: from [150.107.172.17] (port=33682 helo=[192.168.20.103]) by smtp-2.orcon.net.nz with esmtpa (Exim 4.86_2) (envelope-from ) id 1hImTi-0006ZO-N3; Tue, 23 Apr 2019 15:52:18 +1200 In-Reply-To: Content-Language: en-GB X-GeoIP: NZ X-Spam_score: -2.9 X-Spam_score_int: -28 X-Spam_bar: -- X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158099 Archived-At: On 23/04/19 2:08 PM, Stefan Monnier wrote: >>> Oh, you're absolutely right, it's called ":after-hook" because it >>> runs after the mode-hook. >> Which means :before-hook definitely isn't a good name for the new >> keyword. > > It's run before the before-change-mode-hook, so the name isn't > completely wrong (and the description of :before-hook makes this > connection clear). > >> Should I go with :eval-before ? > > I'd prefer we avoid "eval" since that would suggest to quote the form. > IOW, I think `:before-hook` is fine. Point taken re: eval (although at minimum we have `with-eval-after-load' which does not require quoting), but I'm also not terribly happy with "before-hook", as I now feel it's quite ambiguous. Running a derived mode involves all of the following hooks: * change-major-mode-hook * change-major-mode-after-body-hook * *-mode-hook(s) * after-change-major-mode-hook * delayed-after-hook-functions So "before hook" (and "after hook") are pretty vague. Especially when the "hook" in question is different in each case. The documentation would indeed clarify, but I think it's sensible to choose a name which gives a clearer idea from the outset. My other suggestion of :before-change still seems reasonable to me. -Phil