From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lucas Werkmeister Newsgroups: gmane.emacs.bugs Subject: bug#43215: [PATCH] Mark sgml-basic-offset as safe for integers Date: Sat, 5 Sep 2020 15:11:06 +0200 Message-ID: <1bd8c36a-516f-14cd-115e-53f26542dafe@lucaswerkmeister.de> References: <20200905094445.504012-1-mail@lucaswerkmeister.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31515"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 Cc: 43215@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 05 15:12:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kEXzF-00083P-7i for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 05 Sep 2020 15:12:09 +0200 Original-Received: from localhost ([::1]:43112 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kEXzE-0002oT-A3 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 05 Sep 2020 09:12:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46682) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kEXz8-0002oH-Pj for bug-gnu-emacs@gnu.org; Sat, 05 Sep 2020 09:12:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58524) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kEXz8-0003wV-H6 for bug-gnu-emacs@gnu.org; Sat, 05 Sep 2020 09:12:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kEXz8-0006e4-DA for bug-gnu-emacs@gnu.org; Sat, 05 Sep 2020 09:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lucas Werkmeister Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 05 Sep 2020 13:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43215 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 43215-submit@debbugs.gnu.org id=B43215.159931147125485 (code B ref 43215); Sat, 05 Sep 2020 13:12:02 +0000 Original-Received: (at 43215) by debbugs.gnu.org; 5 Sep 2020 13:11:11 +0000 Original-Received: from localhost ([127.0.0.1]:41836 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEXyJ-0006cz-FD for submit@debbugs.gnu.org; Sat, 05 Sep 2020 09:11:11 -0400 Original-Received: from lucaswerkmeister.de ([94.130.58.99]:43810) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEXyG-0006cp-LW for 43215@debbugs.gnu.org; Sat, 05 Sep 2020 09:11:10 -0400 Original-Received: from [192.168.178.21] (pd9f48a72.dip0.t-ipconnect.de [217.244.138.114]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: mail@lucaswerkmeister.de) by lucaswerkmeister.de (Postfix) with ESMTPSA id 65D36B35E78; Sat, 5 Sep 2020 15:11:07 +0200 (CEST) Authentication-Results: lucaswerkmeister.de; dmarc=fail (p=none dis=none) header.from=lucaswerkmeister.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lucaswerkmeister.de; s=mail; t=1599311467; bh=hJoCAOUN4YmhHAzRIPWC/iFzLqguvSXskqnZMPwYDuw=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type:Content-Transfer-Encoding:From:Reply-To: Subject:Date:To:Cc:In-Reply-To:References:Message-Id:Sender: Content-Type:Content-Transfer-Encoding:Content-Disposition: Mime-Version; b=fYdFavIMrtxfRjNUSlU9+F8Kz/yp4kXui509Mpmf1hSnpEFKwdLvTY3FZa9DMCNfn WGFxj6UcJqp1I+D9QooGI1GhEEQ+ls57c5gZnd98BvnS6SCdztIf5HuDWbxgJrPbhq KiWC5PAyWZePXnUdeFojARvY5pMFcCd0y2PxhzdU= In-Reply-To: Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:187234 Archived-At: On 05.09.20 12:42, Stefan Kangas wrote: > Lucas Werkmeister writes: > >> * lisp/textmodes/sgml-mode.el (sgml-basic-offset): Add :safe. >> --- >> lisp/textmodes/sgml-mode.el | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/lisp/textmodes/sgml-mode.el b/lisp/textmodes/sgml-mode.el >> index 1672dce4f2..04f1dddf5f 100644 >> --- a/lisp/textmodes/sgml-mode.el >> +++ b/lisp/textmodes/sgml-mode.el >> @@ -46,7 +46,8 @@ sgml >> >> (defcustom sgml-basic-offset 2 >> "Specifies the basic indentation level for `sgml-indent-line'." >> - :type 'integer) >> + :type 'integer >> + :safe #'integerp) > > Thanks for the patch. > > Could you explain a bit about the rationale for this change, why it is > needed and how to test it? > The patch lets users customize the sgml-basic-offset variable (which controls indentation of sgml-mode and derived modes like (m)html-mode). To test it, you can set the variable to an integer value, for example: ; .dir-locals.el ((sgml-mode . ((sgml-basic-offset . 4)))) Then try to edit an HTML file in the same directory. Without this patch, Emacs will ask if the local variable should be applied or not, because it can’t be determined to be safe. This patch fixes that.