From: "Andreas Röhler" <andreas.roehler@easy-emacs.de>
To: Noam Postavsky <npostavs@gmail.com>
Cc: 35708@debbugs.gnu.org
Subject: bug#35708: [27.0.50]: thingatpt.el, thing-at-point-looking-at redundant
Date: Mon, 13 May 2019 20:31:54 +0200 [thread overview]
Message-ID: <1bbebe25-9c4e-2563-701b-9bed85fcabb0@easy-emacs.de> (raw)
In-Reply-To: <87ftpih6hs.fsf@gmail.com>
On 13.05.19 14:41, Noam Postavsky wrote:
> Andreas Röhler <andreas.roehler@easy-emacs.de> writes:
>
>> as result of ‘thing-at-point-looking-at’ finally is delivered by
>> ‘looking-at’,
>> don't see any sense in calling ‘re-search-forward’ first.
> The test added below fails if the re-search-forward in
> thing-at-point-looking-at is commented out. Does that tell you what the
> "sense" is?
>
Thought at something like below, which should pass the test:
(defun ar-thing-at-point-looking-at (regexp)
"Return t if regexp matches at or before point, nil otherwise."
(save-excursion
(while (not (or (looking-at regexp)(bolp)))
(forward-char -1))
(looking-at regexp)))
next prev parent reply other threads:[~2019-05-13 18:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-13 7:19 bug#35708: [27.0.50]: thingatpt.el, thing-at-point-looking-at redundant Andreas Röhler
2019-05-13 12:41 ` Noam Postavsky
2019-05-13 18:31 ` Andreas Röhler [this message]
2019-05-13 19:25 ` npostavs
2019-05-14 10:02 ` Andreas Röhler
2019-05-14 10:49 ` Andreas Röhler
2019-05-14 14:34 ` npostavs
2019-05-15 6:59 ` Andreas Röhler
2019-05-15 10:11 ` Andreas Röhler
2019-05-20 17:17 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1bbebe25-9c4e-2563-701b-9bed85fcabb0@easy-emacs.de \
--to=andreas.roehler@easy-emacs.de \
--cc=35708@debbugs.gnu.org \
--cc=npostavs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).