From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Augustin =?UTF-8?Q?Ch=C3=A9neau?= (BTuin) Newsgroups: gmane.emacs.bugs Subject: bug#66152: 30.0.50; Missing indent rules in c-ts-mode Date: Tue, 26 Sep 2023 14:29:07 +0200 Message-ID: <1bb29ad2-270d-4b19-8d5f-90f23b9fd100@mailo.com> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------MWqV9IU0X9E49Vv5q3TdQEoA" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34706"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird To: 66152@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 26 14:30:12 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ql7Ce-0008pl-Ge for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 26 Sep 2023 14:30:12 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ql7CP-0007Vo-1E; Tue, 26 Sep 2023 08:29:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ql7CH-0007Ui-Lx for bug-gnu-emacs@gnu.org; Tue, 26 Sep 2023 08:29:50 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ql7CH-0005Xs-DO for bug-gnu-emacs@gnu.org; Tue, 26 Sep 2023 08:29:49 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ql7CT-0000LF-OO for bug-gnu-emacs@gnu.org; Tue, 26 Sep 2023 08:30:01 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Augustin =?UTF-8?Q?Ch=C3=A9neau?= (BTuin) Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 26 Sep 2023 12:30:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66152 X-GNU-PR-Package: emacs Original-Received: via spool by 66152-submit@debbugs.gnu.org id=B66152.16957313711233 (code B ref 66152); Tue, 26 Sep 2023 12:30:01 +0000 Original-Received: (at 66152) by debbugs.gnu.org; 26 Sep 2023 12:29:31 +0000 Original-Received: from localhost ([127.0.0.1]:47567 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ql7By-0000Jp-LN for submit@debbugs.gnu.org; Tue, 26 Sep 2023 08:29:31 -0400 Original-Received: from msg-4.mailo.com ([213.182.54.15]:56966) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ql7Bw-0000JU-0M for 66152@debbugs.gnu.org; Tue, 26 Sep 2023 08:29:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1695731348; bh=2Wj//do6w610pKVviShqlFzMowauiCQBxasbRWTswCs=; h=X-EA-Auth:Content-Type:Message-ID:Date:MIME-Version:To:From: Subject; b=kv5NwlmJPUWbwuEtV3WPA+UUxUOEdO5hiTy6XCdry5+9Z96ySFAFwAe/Kd3R+YLLA +GfHnUxJ2G7u4BRgQ8yj8g7EYq6gqpgQQu/4lhOSudEbaEAoqSjMsFBDO1PkLN3HJr eUZo7fEFFb5tWcrQajmu1ygZutyvGaSJn432KO6A= Original-Received: by b221-3.in.mailobj.net [192.168.90.23] with ESMTP via ip-20.mailobj.net [213.182.54.20] Tue, 26 Sep 2023 14:29:08 +0200 (CEST) X-EA-Auth: rNihbNY98tcCsjFTubEwrWyFbaihnVUT+Yr6P2RVCH6GsZgN0dTc9GhyizPw6fgb/IzvC68sWUMSvnNgtvZt+HB1x2ydYV8q Content-Language: fr, en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271373 Archived-At: This is a multi-part message in MIME format. --------------MWqV9IU0X9E49Vv5q3TdQEoA Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit I found some more issues. First, there is no rule for an element in an else clause: if (true) do_something(); else do_something_else(); "do_something_else" is not indented. There is also something weird with the bsd indent style. It indents do_something and do_something_else to parent-bol with 0 offset, so the result is: if (true) do_something(); else do_something_else(); It is very different from the bsd style from c-mode, which produces this: if (true) do_something(); else do_something_else(); By looking at random files from OpenBSD, they do indent their expressions inside if and else: (lines 277, 484, and 527) Also there is a second patch which tries to handle specific types of comments. I don't know how popular it is, but some people use these kind of comments: /*---------. | %param. | `---------*/ Here we want the vertical bar ("|") to be indented at the same column as the first "/". Currently the result is this: /*---------. | %param. | `---------*/ This patch is a just proof of concept. If this new behavior is indeed wanted, I would clean it up and adapt other modes. --------------MWqV9IU0X9E49Vv5q3TdQEoA Content-Type: text/x-patch; charset=UTF-8; name="0001-c-ts-mode-Add-indentation-rule-for-else_clause.patch" Content-Disposition: attachment; filename*0="0001-c-ts-mode-Add-indentation-rule-for-else_clause.patch" Content-Transfer-Encoding: base64 RnJvbSBkMDUwNjE5NzQzYjI2MDRkZmEzYjEzNDJmYTEyZWU5OWE0YWE1NTBhIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/QXVndXN0aW49MjBDaD1DMz1BOW5l YXU/PSA8YnR1aW5AbWFpbG8uY29tPgpEYXRlOiBUdWUsIDI2IFNlcCAyMDIzIDE0OjAzOjE4 ICswMjAwClN1YmplY3Q6IFtQQVRDSCAxLzJdIGMtdHMtbW9kZTogQWRkIGluZGVudGF0aW9u IHJ1bGUgZm9yIGVsc2VfY2xhdXNlCgotLS0KIGxpc3AvcHJvZ21vZGVzL2MtdHMtbW9kZS5l bCB8IDEgKwogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspCgpkaWZmIC0tZ2l0IGEv bGlzcC9wcm9nbW9kZXMvYy10cy1tb2RlLmVsIGIvbGlzcC9wcm9nbW9kZXMvYy10cy1tb2Rl LmVsCmluZGV4IDMxNGYzN2Y3ZWM1Li5jYjIzNjQ0NzM2OCAxMDA2NDQKLS0tIGEvbGlzcC9w cm9nbW9kZXMvYy10cy1tb2RlLmVsCisrKyBiL2xpc3AvcHJvZ21vZGVzL2MtdHMtbW9kZS5l bApAQCAtNDU1LDYgKzQ1NSw3IEBAIGMtdHMtbW9kZS0taW5kZW50LXN0eWxlcwogICAgICAg ICAgICA7OyBUaGVzZSBydWxlcyBhcmUgZm9yIGNhc2VzIHdoZXJlIHRoZSBib2R5IGlzIGJy YWNrZXRsZXNzLgogICAgICAgICAgICA7OyBUZXN0ZWQgYnkgdGhlICJCcmFja2V0bGVzcyBT aW1wbGUgU3RhdGVtZW50IiB0ZXN0LgogICAgICAgICAgICAoKHBhcmVudC1pcyAiaWZfc3Rh dGVtZW50Iikgc3RhbmRhbG9uZS1wYXJlbnQgYy10cy1tb2RlLWluZGVudC1vZmZzZXQpCisg ICAgICAgICAgICgocGFyZW50LWlzICJlbHNlX2NsYXVzZSIpIHN0YW5kYWxvbmUtcGFyZW50 IGMtdHMtbW9kZS1pbmRlbnQtb2Zmc2V0KQogICAgICAgICAgICAoKHBhcmVudC1pcyAiZm9y X3N0YXRlbWVudCIpIHN0YW5kYWxvbmUtcGFyZW50IGMtdHMtbW9kZS1pbmRlbnQtb2Zmc2V0 KQogICAgICAgICAgICAoKHBhcmVudC1pcyAid2hpbGVfc3RhdGVtZW50Iikgc3RhbmRhbG9u ZS1wYXJlbnQgYy10cy1tb2RlLWluZGVudC1vZmZzZXQpCiAgICAgICAgICAgICgocGFyZW50 LWlzICJkb19zdGF0ZW1lbnQiKSBzdGFuZGFsb25lLXBhcmVudCBjLXRzLW1vZGUtaW5kZW50 LW9mZnNldCkKLS0gCjIuNDIuMAoK --------------MWqV9IU0X9E49Vv5q3TdQEoA Content-Type: text/x-patch; charset=UTF-8; name="0002-c-ts-mode-handle-specific-comment-formatting.patch" Content-Disposition: attachment; filename="0002-c-ts-mode-handle-specific-comment-formatting.patch" Content-Transfer-Encoding: base64 RnJvbSAwMDc0ZGI0MjI0YjQyNjllZWM0NjRhYzAwZWI3NTFkOTE5YWVjNDA4IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/QXVndXN0aW49MjBDaD1DMz1BOW5l YXU/PSA8YnR1aW5AbWFpbG8uY29tPgpEYXRlOiBUdWUsIDI2IFNlcCAyMDIzIDE0OjEwOjQw ICswMjAwClN1YmplY3Q6IFtQQVRDSCAyLzJdIGMtdHMtbW9kZTogaGFuZGxlIHNwZWNpZmlj IGNvbW1lbnQgZm9ybWF0dGluZwoKLS0tCiBsaXNwL3Byb2dtb2Rlcy9jLXRzLWNvbW1vbi5l bCB8IDExICsrKysrKysrKysrCiBsaXNwL3Byb2dtb2Rlcy9jLXRzLW1vZGUuZWwgICB8ICA0 ICsrKy0KIDIgZmlsZXMgY2hhbmdlZCwgMTQgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigt KQoKZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL2MtdHMtY29tbW9uLmVsIGIvbGlzcC9w cm9nbW9kZXMvYy10cy1jb21tb24uZWwKaW5kZXggM2IwODE0OTcwYWQuLjFlYTQxMjYwYWI4 IDEwMDY0NAotLS0gYS9saXNwL3Byb2dtb2Rlcy9jLXRzLWNvbW1vbi5lbAorKysgYi9saXNw L3Byb2dtb2Rlcy9jLXRzLWNvbW1vbi5lbApAQCAtNTYsNiArNTYsMTcgQEAKIAogOzs7IENv bW1lbnQgaW5kZW50YXRpb24gYW5kIGZpbGxpbmcKIAorCisoZGVmdW4gYy10cy1jb21tb24t bG9va2luZy1hdCAoY2hhciAmcmVzdCBjaGFycykKKyAgKGxhbWJkYSAoX24gX3AgYm9sICZy ZXN0IF8pCisgICAgKGxldCAoKHJlcyBuaWwpKQorICAgICAgKHNldHEgcmVzIChlcSAoY2hh ci1hZnRlciBib2wpIGNoYXIpKQorICAgICAgKHdoaWxlIChhbmQgY2hhcnMgKG5vdCByZXMp KQorICAgICAgICAoc2V0cSBjaGFyIChjYXIgY2hhcnMpCisgICAgICAgICAgICAgIGNoYXJz IChjZHIgY2hhcnMpCisgICAgICAgICAgICAgIHJlcyAoZXEgKGNoYXItYWZ0ZXIgYm9sKSBj aGFyKSkpCisgICAgICByZXMpKSkKKwogKGRlZnVuIGMtdHMtY29tbW9uLWxvb2tpbmctYXQt c3RhciAoX24gX3AgYm9sICZyZXN0IF8pCiAgICJBIHRyZWUtc2l0dGVyIHNpbXBsZSBpbmRl bnQgbWF0Y2hlci4KIE1hdGNoZXMgaWYgdGhlcmUgaXMgYSBcIipcIiBhZnRlciBCT0wuIgpk aWZmIC0tZ2l0IGEvbGlzcC9wcm9nbW9kZXMvYy10cy1tb2RlLmVsIGIvbGlzcC9wcm9nbW9k ZXMvYy10cy1tb2RlLmVsCmluZGV4IGNiMjM2NDQ3MzY4Li43NmNiYWQ1MGQwNiAxMDA2NDQK LS0tIGEvbGlzcC9wcm9nbW9kZXMvYy10cy1tb2RlLmVsCisrKyBiL2xpc3AvcHJvZ21vZGVz L2MtdHMtbW9kZS5lbApAQCAtMzcxLDggKzM3MSwxMCBAQCBjLXRzLW1vZGUtLWluZGVudC1z dHlsZXMKICAgICAgICAgICAgKChub2RlLWlzICJwcmVwcm9jX2FyZyIpIG5vLWluZGVudCkK ICAgICAgICAgICAgOzsgYGMtdHMtY29tbW9uLWxvb2tpbmctYXQtc3RhcicgaGFzIHRvIGNv bWUgYmVmb3JlCiAgICAgICAgICAgIDs7IGBjLXRzLWNvbW1vbi1jb21tZW50LTJuZC1saW5l LW1hdGNoZXInLgotICAgICAgICAgICAoKGFuZCAocGFyZW50LWlzICJjb21tZW50IikgYy10 cy1jb21tb24tbG9va2luZy1hdC1zdGFyKQorICAgICAgICAgICAoKGFuZCAocGFyZW50LWlz ICJjb21tZW50IikgYy10cy1jb21tb24tbG9va2luZy1hdCA/KikKICAgICAgICAgICAgIGMt dHMtY29tbW9uLWNvbW1lbnQtc3RhcnQtYWZ0ZXItZmlyc3Qtc3RhciAtMSkKKyAgICAgICAg ICAgKChhbmQgKHBhcmVudC1pcyAiY29tbWVudCIpIChjLXRzLWNvbW1vbi1sb29raW5nLWF0 ID98ID9cXCA/YCkpCisgICAgICAgICAgICBjLXRzLWNvbW1vbi1jb21tZW50LXN0YXJ0LWFm dGVyLWZpcnN0LXN0YXIgLTIpCiAgICAgICAgICAgIChjLXRzLWNvbW1vbi1jb21tZW50LTJu ZC1saW5lLW1hdGNoZXIKICAgICAgICAgICAgIGMtdHMtY29tbW9uLWNvbW1lbnQtMm5kLWxp bmUtYW5jaG9yCiAgICAgICAgICAgICAxKQotLSAKMi40Mi4wCgo= --------------MWqV9IU0X9E49Vv5q3TdQEoA--