From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Maxim Nikulin Newsgroups: gmane.emacs.bugs Subject: bug#23847: KDE and etc/images/help icon Date: Tue, 2 Jun 2020 19:44:40 +0700 Message-ID: <1b7968af-f4cd-1243-94c7-d1d9374e2f21@gmail.com> References: <576E5215.2050405@laposte.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="118103"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 To: 23847@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 02 17:03:14 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jg8Rd-000UYZ-Br for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Jun 2020 17:03:13 +0200 Original-Received: from localhost ([::1]:39168 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jg8Rc-0003Xc-3p for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Jun 2020 11:03:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46864) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jg8RS-0003XP-C9 for bug-gnu-emacs@gnu.org; Tue, 02 Jun 2020 11:03:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57266) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jg8RS-00027b-2f for bug-gnu-emacs@gnu.org; Tue, 02 Jun 2020 11:03:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jg8RR-0007hB-VK for bug-gnu-emacs@gnu.org; Tue, 02 Jun 2020 11:03:01 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <576E5215.2050405@laposte.net> Resent-From: Maxim Nikulin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Jun 2020 15:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23847 X-GNU-PR-Package: emacs Original-Received: via spool by 23847-submit@debbugs.gnu.org id=B23847.159111017129564 (code B ref 23847); Tue, 02 Jun 2020 15:03:01 +0000 Original-Received: (at 23847) by debbugs.gnu.org; 2 Jun 2020 15:02:51 +0000 Original-Received: from localhost ([127.0.0.1]:40579 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jg8RH-0007gm-9i for submit@debbugs.gnu.org; Tue, 02 Jun 2020 11:02:51 -0400 Original-Received: from mail-lj1-f176.google.com ([209.85.208.176]:33124) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jg6Hq-0003Q5-Bz for 23847@debbugs.gnu.org; Tue, 02 Jun 2020 08:44:58 -0400 Original-Received: by mail-lj1-f176.google.com with SMTP id s1so12419717ljo.0 for <23847@debbugs.gnu.org>; Tue, 02 Jun 2020 05:44:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:message-id:date:user-agent:mime-version :content-language:content-transfer-encoding; bh=rVVF8FzfiOzgOvtmUUqPi6Bl87JJWiwHM8hHTB6WB7o=; b=GsSlvdZYwGc5m9vVRFwzD1B69cDRKFqLsxKBG+C1OiUPFb2c3sbFQJ4nR/pGX41gp+ s9QKQMOu29P8APyxioo2oWHWhvkNBSZ2ILt4oKbuGAy+pvMCDX0m5c/nrQKz71rgrqzI x7xQYuizu+kt7aUvFE3You56v27GhDhc/JqOLEzWRCcM9J0hq8ubgDOiWxXG/g0Zo5K+ ElBsP1R74LeYJ8QAKMORciYgNKdTkAXY6nyloHLzweNWwFjmlWf0OiqVEu2LYBycdwjY 1KoVZHfQkiCA40EGljxsN+zuZ4pFNbflrkWRzzhPhKfVP4aTMkkjihCPCSwmdcKyM1Ia hYOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:message-id:date:user-agent :mime-version:content-language:content-transfer-encoding; bh=rVVF8FzfiOzgOvtmUUqPi6Bl87JJWiwHM8hHTB6WB7o=; b=uER8bpxstF8WzmgXUk6ftd3c/Ntz7174e09k0jUbXHpwdmPLQo/mL2epUog3T604Ej 8NyicfaX+9Q07/pJmecxC81I1uqIhdpbAyll8uKBEKh1j5f/z32gO+edQTIOkOLrLktH LSj4QA4jyiVz/9e81fXBd3LTRCRyaYI1loiNVw8QkKC2VXLzW6Fe0LKeWqk2Y5h5KzLG H2PTLN3B3KwdCXYPWbWrgF3dPZi+J0OpDkhL/WdN1Re78CrjGlachuyu5FE0nr2v9Mhs rgh5tmM9bBKSQbsU1s0QK/WMktV/JR1DFZv2ikFFJye+cBnrArdxqVAxT5Iixyg6ZrMo jrXQ== X-Gm-Message-State: AOAM531O3XwVnBXCn9MFYBgmUFrJjrFfvJMHB273yReJYp0TjmarEkqW a3HUm0HW25demRsrC8YOQuYVaDm+ X-Google-Smtp-Source: ABdhPJzD+3pP4DSJiZE7HedKvW1Y1rgaCZvhmjEpdKAE3xc5BbZOyk53FnYcyZ0R+jYf2qLmygZf0Q== X-Received: by 2002:a2e:9586:: with SMTP id w6mr12655417ljh.274.1591101891847; Tue, 02 Jun 2020 05:44:51 -0700 (PDT) Original-Received: from [192.168.0.101] (nat-0-0.nsk.sibset.net. [5.44.169.181]) by smtp.googlemail.com with ESMTPSA id 10sm516856ljw.134.2020.06.02.05.44.50 for <23847@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Jun 2020 05:44:51 -0700 (PDT) X-Google-Original-From: Maxim Nikulin Content-Language: en-US X-Mailman-Approved-At: Tue, 02 Jun 2020 11:02:50 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:181401 Archived-At: It seems that "n:system-file-manager" is not the only problem icon in the emacs toolbar. I faced the problem with the Breeze KDE theme and emacs-25.2 in Ubuntu-18.04. Is there a particular reason of the choice for the help icon that appears e.g. for customize mode? - ("etc/images/help" . ("help-browser" "gtk-help")) Would not it better to use "n:help-contents" for help? Unlike "help-browser" that comes from apps, "help-contents" belongs to the Actions category, so its style is uniform with other toolbar icons. Unfortunately I could not suggest an equivalent for "diropen", e.g. "n:folder-new" could be misleading. Maybe I have missed something but it looks like as a quite sour story. KDE developers believes that the problem should be fixed in emacs, see https://bugs.kde.org/show_bug.cgi?id=353496 https://debbugs.gnu.org/cgi/bugreport.cgi?bug=21659 I am not familiar with Gtk so I am unaware if it is possible to adjust breeze gtk theme to override compiled-in icon size (22px as default in KDE theme vs. 24px used by Gtk). I am really puzzled by the following statement, I could not get where related user preferences could be set: https://developer.gnome.org/gtk3/stable/GtkToolbar.html#gtk-toolbar-set-icon-size > gtk_toolbar_set_icon_size () > ... > This should only be used for special-purpose toolbars, > normal application toolbars should respect > the user preferences for the size of icons. Preferences in settings.ini are ignored, see https://developer.gnome.org/gtk3/stable/GtkSettings.html#GtkSettings--gtk-icon-sizes Likely it is impossible to override GtkToolbar icon-size though theme CSS as well. Obviously KDE-specific hints in index.theme are not taken into account by Gtk ToolbarDefault=22 ToolbarSizes=16,22,32,48 It looks like that it is completely up to the particular application if icon sizes other than compiled-in defaults should be used. I would expect some high-level API in Gtk that ensures reasonable icon sizes across displays of various sizes with minimal efforts of developers of an application but from the first glance I have not noticed any traces of code that runs behind the scene ensuring meaningful defaults. Maybe there is no simple way to properly handle screens with significantly different resolution connected to the same box, so such work must be done in every application. Other application experienced similar problems as well, e.g. inkscape and gparted. They were solved by adding dedicated icons, adjusting Breeze theme to allow scaling of icons in some directories, or by modifying application code to force desired size through explicit scaling. I do not know if using of gtk_icon_theme_load_icon() with GTK_ICON_LOOKUP_FORCE_SIZE is a viable approach for emacs. Are there any objections against "help-contents" icon for help? P.S. GtkToolbar has been removed from the Gtk master branch.