unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Noam Postavsky <npostavs@gmail.com>
Cc: 41087@debbugs.gnu.org
Subject: bug#41087: 27.0.91; How to remove Emacs 27 changes to minibuffer?
Date: Tue, 5 May 2020 11:10:39 -0700 (PDT)	[thread overview]
Message-ID: <1b1632e1-2669-44c3-b6c1-1d8da519a91b@default> (raw)
In-Reply-To: <85imhah1kt.fsf@gmail.com>

> > I think that some of the problems come from the changes to minibuffer
> > and echo-area behavior.  Regardless of whether that is the case, I
> > want to undo those changes.  Is there an option for that? (I hope so.)
> > If not, what changes do I need to make from Lisp, to get back the prior
> > behavior?
> 
> Here's my guesses (none tested) about each item you list.  Of course,
> these particular may or may not be the cause of your troubles (whatever
> they are).

Thanks, Noam, for going to all the trouble you did.
I'll try them, at least once I get past the main
problem of minibuffer input-focus loss.

> > *** A new user option, 'minibuffer-beginning-of-buffer-movement', has
> > been introduced to allow controlling how the 'M-<' command works in
> > the minibuffer.  If non-nil, point will move to the end of the prompt
> > (if point is after the end of the prompt).
> 
> AFAICT, this one is already disabled by default (i.e.,
> minibuffer-beginning-of-buffer-movement is nil by default).

I doubt that's related.  But OK.

BTW, why a user option for that?  Why not just bind
`M-<' to a different command in the minibuffer maps?
(Doesn't matter to me.  Just wondering.)

> > *** When the minibuffer is active, echo-area messages are displayed
> > at the end of the minibuffer instead of hiding the minibuffer by the
> > echo area display.  The new user option 'minibuffer-message-clear-timeout'
> > controls how messages displayed in this situation are removed from
> > the minibuffer.

I saw that.  I'll take a closer look, but a priori
I'm not interested in controlling _HOW_ msgs are
displayed in this situation (the situation being
that they're shown automatically, at the end of the
minibuffer).  I'm interested in not having that
situation at all - not how they're displayed at the
end of the minibuffer but how to not have that
happen at all.  I want the old behavior (since
Emacs Day One).

> (setq set-message-function nil)
> (setq clear-message-function nil)

Thanks; that's probably it.  If it is, I think
NEWS should say explicitly that setting these
to nil removes the new behavior of "When the
minibuffer is active, echo-area messages are ...".

That is, section "** Minibuffer" should tell you
how to revert to the previous Emacs behavior.

In particular, where it says this:

"Minibuffer now uses 'minibuffer-message' to display
error messages at the end of the active minibuffer."

it should tell you how to disable that new behavior.

(And isn't it about all echo-area messages, not just
"error messages"?)

> New variable set-message-function to show message at the end of the
> minibuffer
> 
> https://urldefense.com/v3/__https://git.savannah.gnu.org/cgit/emacs.git
> /commit/?id=485b423e8f0df2711a850be7f254665f64ab0bdb__;!!GqivPVa7Brio!L
> G_VudrPxJ8CU6VhuvBVOW0-LlUGAuEG9l125HX6QQ9ReoJg1Gg3NCe430S9TyOY$

Great; thanks.  It would be good for the NEWS mention
of that variable to link to the manual explanation.

> > *** Minibuffer now uses 'minibuffer-message' to display error
> > messages at the end of the active minibuffer.
> 
> (remove-hook 'minibuffer-setup-hook 'minibuffer-error-initialize)

Good.  Pity there's not a simple user option to revert
the new behavior.  And it would be good for NEWS to
explicitly show all such code for reverting this
echo-area msgs change in one place.

>   User-friendly display of error messages at the end of minibuffer
> 
> https://urldefense.com/v3/__https://git.savannah.gnu.org/cgit/emacs.git
> /commit/?id=2aae063055283ee64ecf339c812a1fe6d1cb106e__;!!GqivPVa7Brio!L
> G_VudrPxJ8CU6VhuvBVOW0-LlUGAuEG9l125HX6QQ9ReoJg1Gg3NCe43zpNUlIi$

Thanks.  I do recall lots of traffic in the bug list
about Juri's proposed changes.  I expressed my
disagreement in detail at the time, to no avail.
But if it's easy enough to revert them all then
that's great, and all one can ask for, I guess.

I do think the doc, and NEWS, could help by
clearly saying how to revert the changes.  Maybe
it does so sufficiently; I haven't studied it.


>
> 
> > +++
> > *** 'y-or-n-p' now uses the minibuffer to read 'y' or 'n' answer.
> 
> You'd have to evaluate the old lisp code of y-or-n-p.
> 
> [a26a8cc1c85]: 2019-11-10 00:04:13 +0200
>   'y-or-n-p' now uses the minibuffer to read 'y' or 'n' answer
> (bug#38076)
> 
> https://urldefense.com/v3/__https://git.savannah.gnu.org/cgit/emacs.git
> /commit/?id=a26a8cc1c85f29fb11209c16d53a8ae4e4ab7ced__;!!GqivPVa7Brio!L
> G_VudrPxJ8CU6VhuvBVOW0-LlUGAuEG9l125HX6QQ9ReoJg1Gg3NCe438q6MbCM$
> 
> > ---
> > *** Some commands that previously used 'read-char-choice' now read
> > a character using the minibuffer by 'read-char-from-minibuffer'.
> 
> You'd have to evaluate the old lisp of files--ask-user-about-large-file
> and hack-local-variables-confirm.
> 
> [027f218ad22]: 2019-11-10 00:32:09 +0200
>   hack-local-variables-confirm uses the minibuffer to read answer
> (bug#38076)
> 
> https://urldefense.com/v3/__https://git.savannah.gnu.org/cgit/emacs.git
> /commit/?id=027f218ad227c3966df94b22566c2e89a307362d__;!!GqivPVa7Brio!L
> G_VudrPxJ8CU6VhuvBVOW0-LlUGAuEG9l125HX6QQ9ReoJg1Gg3NCe436x220-7$
> 





  reply	other threads:[~2020-05-05 18:10 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-04 21:07 bug#41087: 27.0.91; How to remove Emacs 27 changes to minibuffer? Drew Adams
2020-05-05  2:22 ` Eli Zaretskii
2020-05-05 14:57 ` Noam Postavsky
2020-05-05 18:10   ` Drew Adams [this message]
2020-05-12 22:50     ` Juri Linkov
2020-05-12 23:56       ` Drew Adams
2020-05-13  2:09         ` Drew Adams
2020-05-13  2:25         ` Eli Zaretskii
     [not found] <<da68d511-3682-4661-b1a1-4323d0ab50cb@default>
     [not found] ` <<83lfm7m871.fsf@gnu.org>
2020-05-05  4:35   ` Drew Adams
2020-05-05 14:23     ` Eli Zaretskii
     [not found] ` <<85imhah1kt.fsf@gmail.com>
     [not found]   ` <<1b1632e1-2669-44c3-b6c1-1d8da519a91b@default>
     [not found]     ` <<87tv0klsvt.fsf@mail.linkov.net>
     [not found]       ` <<4575d23f-e3b5-4c44-8907-5ba8324dec91@default>
     [not found]         ` <<83r1vo7eqe.fsf@gnu.org>
2020-05-13  2:36           ` Drew Adams
2020-05-13 14:48             ` Eli Zaretskii
     [not found] <<<da68d511-3682-4661-b1a1-4323d0ab50cb@default>
     [not found] ` <<<83lfm7m871.fsf@gnu.org>
     [not found]   ` <<a1812925-7f61-4aa3-87fd-c673c06b97c3@default>
     [not found]     ` <<83bln2mpf8.fsf@gnu.org>
2020-05-05 17:46       ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1b1632e1-2669-44c3-b6c1-1d8da519a91b@default \
    --to=drew.adams@oracle.com \
    --cc=41087@debbugs.gnu.org \
    --cc=npostavs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).