From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#62162: 29.0.60; xref.el doesn't compile on Emacs 26, because multi-pair setq-local Date: Tue, 14 Mar 2023 02:29:37 +0200 Message-ID: <1a4c5f8b-3119-6417-81db-72975a970ec1@yandex.ru> References: <87bkkwpxms.fsf@gmail.com> <86fsa835yf.fsf@mail.linkov.net> <877cvkp6gh.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28471"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Cc: 62162@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Mar 14 01:30:37 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pbsYn-0007AE-2y for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 14 Mar 2023 01:30:37 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pbsYQ-00016R-G1; Mon, 13 Mar 2023 20:30:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pbsYE-00016C-TB for bug-gnu-emacs@gnu.org; Mon, 13 Mar 2023 20:30:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pbsYE-00027s-JA for bug-gnu-emacs@gnu.org; Mon, 13 Mar 2023 20:30:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pbsYE-0005DN-9U for bug-gnu-emacs@gnu.org; Mon, 13 Mar 2023 20:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 Mar 2023 00:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62162 X-GNU-PR-Package: emacs Original-Received: via spool by 62162-submit@debbugs.gnu.org id=B62162.167875378819988 (code B ref 62162); Tue, 14 Mar 2023 00:30:02 +0000 Original-Received: (at 62162) by debbugs.gnu.org; 14 Mar 2023 00:29:48 +0000 Original-Received: from localhost ([127.0.0.1]:35847 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pbsXz-0005CK-SB for submit@debbugs.gnu.org; Mon, 13 Mar 2023 20:29:48 -0400 Original-Received: from mail-wm1-f51.google.com ([209.85.128.51]:52941) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pbsXy-0005C1-1H for 62162@debbugs.gnu.org; Mon, 13 Mar 2023 20:29:46 -0400 Original-Received: by mail-wm1-f51.google.com with SMTP id j3so9160161wms.2 for <62162@debbugs.gnu.org>; Mon, 13 Mar 2023 17:29:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678753780; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=sP5e9lFTLNANlZtDzw4m0DqOqfr7TO0o1AxReCiUTcQ=; b=Yncjm+LxlcclZJbUTEit7xT2F2hmsxS3Lr8tFv0pOpA5KHSzxKyEF+i4wB1UnqWwyT 87xYRagIMzYnClq2mY8OZqP4E7Wp5PFX/l34G0EkVTYU31nDuK00vnvXNvaN95ovuKoF tR2V2E1mJAzggaaDPP4KmZt1phCDQ/ZVNf4yPoMPSEltNnMJfXgECxBkcTwrjJ5vflyE IeuB/VrIHKzIZnKGVnuPY+/xbAu8KvG0D667y/JveKa4jbRxdTvP4AUWSuVJK7I+ZRUi VJksYm6K4vGzjZd2P7xDC9BknI6yGy5vPdS2ys0/g7CJQYx7F4FsrqWvn2QjVFvFvvyr HSSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678753780; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sP5e9lFTLNANlZtDzw4m0DqOqfr7TO0o1AxReCiUTcQ=; b=oSL//xTMfrwRm2sRLQUMh8bmzavWAyRuFG60HezLbv9KfaCRAZaGEO3410Q62hTkjM IFTEyFk5BB6fqs2uRju5HK7kV/utJX7akdnmyR/CJkqxMt9FN3X7LBJKlF8Z7dBURh+n vVNetDow5I8/ujEfhclpZ/sAMHlAQXZTM6jBBCjqTnlTeMgyh38V2FKAv84EqFwkzszo mS6aPJubXfPTXqwMbLeZdUul2EqZZWOpggDvK7uix/1+Afy7j1bWMUJNQaZ19PPP8htn gsVTuzTB3VUgPj8pHCdagvvV9e1hOjGS9EIblSSNnGAJ6cIDy4jN3rt2tGG9jmi+QZX+ 7o0w== X-Gm-Message-State: AO0yUKU2ruD1HIVzeoVQt/VQMJX0vjkaoo0GQxVKg37vjDjbw7kEttA9 6ogBPws+QgtvCkaiH5DhxKo= X-Google-Smtp-Source: AK7set/7B8YtIFNzG9YjrrWLBmdD3tFTyaBwW5sTS8TZjBuMg3PdT/GNxf4eLn2GPcnv/T5F1DLX8A== X-Received: by 2002:a05:600c:a4c:b0:3dc:d5c:76d9 with SMTP id c12-20020a05600c0a4c00b003dc0d5c76d9mr13382717wmq.0.1678753779948; Mon, 13 Mar 2023 17:29:39 -0700 (PDT) Original-Received: from [192.168.0.2] ([85.132.229.92]) by smtp.googlemail.com with ESMTPSA id bg7-20020a05600c3c8700b003eb2e33f327sm240111wmb.2.2023.03.13.17.29.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Mar 2023 17:29:39 -0700 (PDT) Content-Language: en-US In-Reply-To: <877cvkp6gh.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257921 Archived-At: On 14/03/2023 01:38, João Távora wrote: > reopen 62162 > thanks > > Juri Linkov writes: > >> close 62162 29.0.60 >> thanks >> >>> I'm reasonably sure that one of the failures has to do with a multi-pair >>> call to `setq-local` in xref.el which appeared in this commit >>> >>> commit 3573ebfa6d94411257ffefdf9eb72f508dbe502c >>> Author: Juri Linkov >>> Date: Wed Nov 23 10:38:28 2022 +0200 >>> >>> That construct should not be used in xref.el because it isn't available >>> on Emacs 26, which xref purports to require. In turn, this breaks Eglot >>> (and any other packge requiring xref) on those platforms. >> >> Now this is fixed in emacs-29. > > Thanks but, I think this should have been fixed in master instead, > because that's where the :core packages are built from, AFAIK, and > emacs-29 doesn't have a problem with that construct. It'll make no > difference soon enough, hopefully. True enough, on both counts. >> I hope Dmitry will decide when to bump the xref package version. > > I think you could have bumped the version, too. Is there any reason not > to? Extra courtesy never hurts, and after I responded (on emacs-devel) Juri bumped the version 40 minutes after the commit with the fix. > Closing this is premature, as the problem stands: the upcoming Eglot > 1.12 will have this problem on Emacs 26. Re-opening. I'll bump xref.el > myself in a day or so if no-one beats me to it, and then close. We're now waiting for the changes to be merged to master. You could do it yourself, if you are in a hurry.