From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#51941: Detect duplication of ERT tests Date: Fri, 19 Nov 2021 10:33:42 +0100 Message-ID: <1EA3587F-ED28-48F1-B149-0E78B662D5CC@acm.org> References: <21CD2DED-354E-4C46-9794-07172E3BD5F1@acm.org> <87fsrtkayn.fsf@gnus.org> <87mtm1z7dc.fsf@gnus.org> <977035C0-5706-419C-A7D8-88FC9F3B890F@acm.org> <6pk0h5axic.fsf@fencepost.gnu.org> <87y25kyars.fsf@gnus.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15049"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Glenn Morris , Philipp , 51941@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 19 10:36:21 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mo0Jh-0003aE-Qh for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 19 Nov 2021 10:36:21 +0100 Original-Received: from localhost ([::1]:43046 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mo0Jg-0007mx-Ft for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 19 Nov 2021 04:36:20 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:40074) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mo0HT-0005WL-3x for bug-gnu-emacs@gnu.org; Fri, 19 Nov 2021 04:34:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54717) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mo0HS-00088L-Rv for bug-gnu-emacs@gnu.org; Fri, 19 Nov 2021 04:34:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mo0HS-00008U-IW for bug-gnu-emacs@gnu.org; Fri, 19 Nov 2021 04:34:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 19 Nov 2021 09:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51941 X-GNU-PR-Package: emacs Original-Received: via spool by 51941-submit@debbugs.gnu.org id=B51941.1637314429492 (code B ref 51941); Fri, 19 Nov 2021 09:34:02 +0000 Original-Received: (at 51941) by debbugs.gnu.org; 19 Nov 2021 09:33:49 +0000 Original-Received: from localhost ([127.0.0.1]:38029 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mo0HF-00007s-9m for submit@debbugs.gnu.org; Fri, 19 Nov 2021 04:33:49 -0500 Original-Received: from mail177c50.megamailservers.eu ([91.136.10.187]:47560 helo=mail51c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mo0HD-00007h-8v for 51941@debbugs.gnu.org; Fri, 19 Nov 2021 04:33:48 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1637314425; bh=ieXOidVtL1m5DEyYljjIv5nTaeXwFLs6xJni89K4f+o=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=oLLGGfZGcU1m3hQrN9koVEWPclglvMNPnljrU+SHRUJPZXb7Z6Hn0fEZXvnrHVlgk BLzuMPLX/JErpWuc7wGgQ2orQMAnk0fIN4mNn4sEM3msZAUmUeneLN/nr3mTkNt63t rxx85TAlgGSP6jI1JIP9c/9Q8TMfda+h8gnTNh1M= Feedback-ID: mattiase@acm.or Original-Received: from [192.168.0.4] (c188-150-171-71.bredband.tele2.se [188.150.171.71]) (authenticated bits=0) by mail51c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 1AJ9Xg7T004302; Fri, 19 Nov 2021 09:33:44 +0000 In-Reply-To: <87y25kyars.fsf@gnus.org> X-Mailer: Apple Mail (2.3445.104.21) X-CTCH-RefID: str=0001.0A742F1D.61976F79.0001, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.4 cv=W4xb6Tak c=1 sm=1 tr=0 ts=61976f79 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=OocQHUDgAAAA:8 a=mDV3o1hIAAAA:8 a=4Mw3bMPI2c_f47NrHiwA:9 a=CjuIK1q_8ugA:10 a=xUZTl98r3Qw_uB5NK3jt:22 a=_FVE-zBwftR9WsbkzFJk:22 X-Origin-Country: SE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:220402 Archived-At: 19 nov. 2021 kl. 06.28 skrev Lars Ingebrigtsen : >> Seems to me that making "should" only be defined within tests would = have >> flagged these (https://debbugs.gnu.org/28385). >=20 > But like I said there, using `should' outside tests is really = convenient > when developing. You are both right -- apart from the development convenience, functions = form an important abstraction mechanism in Lisp and they can be valuable = for decomposing test code (although I don't think I've ever done so = myself). On the other hand, disallowing them outside `ert-deftest` might = help eliminate the mistakes that we are talking about. A quick scan finds 365 occurrences of `should`, `should-not` and = `should-error` inside defuns in the test/ subtree.