From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Bozhidar Batsov Newsgroups: gmane.emacs.bugs Subject: bug#16182: Acknowledgement (24.3.50; ruby-mode: Indentation style of multiline literals with hanging open paren inside other parens) Date: Thu, 19 Dec 2013 11:08:55 +0200 Message-ID: <1E72CA8B046B46A6B320EBB9A71FF8CA@gmail.com> References: <874n66byoo.fsf@yandex.ru> <52B11F12.4070109@yandex.ru> <490C2BFA3C624DB6AB057CD2AA393D9C@gmail.com> <87txe5v4ol.fsf@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="52b2b7a7_2e22fbb7_206" X-Trace: ger.gmane.org 1387444150 31913 80.91.229.3 (19 Dec 2013 09:09:10 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 19 Dec 2013 09:09:10 +0000 (UTC) Cc: Steve Purcell , Adam Sokolnicki To: 16182@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 19 10:09:16 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VtZbX-0004Pw-HO for geb-bug-gnu-emacs@m.gmane.org; Thu, 19 Dec 2013 10:09:15 +0100 Original-Received: from localhost ([::1]:42859 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtZbW-0008Rw-Vp for geb-bug-gnu-emacs@m.gmane.org; Thu, 19 Dec 2013 04:09:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42753) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtZbP-0008NY-Re for bug-gnu-emacs@gnu.org; Thu, 19 Dec 2013 04:09:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VtZbK-0000Wc-PK for bug-gnu-emacs@gnu.org; Thu, 19 Dec 2013 04:09:07 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:44183) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtZbK-0000WW-L6 for bug-gnu-emacs@gnu.org; Thu, 19 Dec 2013 04:09:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VtZbJ-0004oK-Uk for bug-gnu-emacs@gnu.org; Thu, 19 Dec 2013 04:09:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Bozhidar Batsov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 19 Dec 2013 09:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16182 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16182-submit@debbugs.gnu.org id=B16182.138744408518408 (code B ref 16182); Thu, 19 Dec 2013 09:09:01 +0000 Original-Received: (at 16182) by debbugs.gnu.org; 19 Dec 2013 09:08:05 +0000 Original-Received: from localhost ([127.0.0.1]:58200 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VtZaP-0004mp-8a for submit@debbugs.gnu.org; Thu, 19 Dec 2013 04:08:05 -0500 Original-Received: from mail-ee0-f48.google.com ([74.125.83.48]:64094) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VtZaM-0004mO-AF for 16182@debbugs.gnu.org; Thu, 19 Dec 2013 04:08:03 -0500 Original-Received: by mail-ee0-f48.google.com with SMTP id e49so318426eek.7 for <16182@debbugs.gnu.org>; Thu, 19 Dec 2013 01:08:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:message-id:in-reply-to:references:subject :mime-version:content-type; bh=Tdxsi2NOyWtXjsjdi7O1i4M9Vg4AO8g7cQs+unnmpGg=; b=wGDHYV1jMx3WVLAu14gQdp95wzftWlXgcBRGSpXEiZ2YRcYJpcJQ8nxceLzo3qP613 ukc6xvp4gTe/6vEQ7m4v3BuSWCzHHVsZuZmi5jv9LKIByq5+T9PH6L9g5xV1WNNCBdNP wd4dW45XtKnwCHgUW0IsIOBC0I/E9ZIbztYur6oX8J9cfqtDhwOP8JFm6e9kD17XvpV7 NjDh5uBDLC1yxhEYc9WtU/Dfi/vbB9Ig8sfjhe6VxO5lu7QovSxOmzQvHHyc0F+8ZhFd U7HlcszwcJMDr4x2umb0r1yzJzq5LZa9/+KzayR9Y2qiDByBf4+sRqohtJFKvSuqIOF2 gEvg== X-Received: by 10.15.73.134 with SMTP id h6mr547752eey.90.1387444081564; Thu, 19 Dec 2013 01:08:01 -0800 (PST) Original-Received: from [10.0.1.3] (93-152-182-45.ddns.onlinedirect.bg. [93.152.182.45]) by mx.google.com with ESMTPSA id p45sm7572593eeg.1.2013.12.19.01.07.59 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 19 Dec 2013 01:08:00 -0800 (PST) In-Reply-To: <87txe5v4ol.fsf@yandex.ru> X-Mailer: sparrow 1.6.4 (build 1178) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:82212 Archived-At: --52b2b7a7_2e22fbb7_206 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Thursday, December 19, 2013 at 6:35 AM, Dmitry Gutov wrote: > Bozhidar Batsov = writes: > =20 > > Personally I dislike this style, because you=E2=80=99re basically it = obscures > > the semantics of the method arguments, but I acknowledge that I=E2=80= =99ve > > seen it the wild. > > =20 > =20 > =20 > Ok, that's a -1, then. > =20 > > =46or me it would be more beneficial if we supported a > > variant of the style: > > =20 > > methods.each do =7Cmethod=7C > > route=5Fset.add=5Froute( > > self, =7B > > path=5Finfo: route.route=5Fcompiled, > > request=5Fmethod: method, > > =7D, route=5Finfo: route > > ) > > end > > =20 > =20 > =20 > Should work now, with revision 115602. > =20 > > Something that=E2=80=99s not mentioned here, but it=E2=80=99s a bigge= r problem for the > > users is probably the fact that we don=E2=80=99t support the followin= g > > indentation style: > > =20 > > x =3D if something > > do=5Fsomething > > end > > =20 > > Even if I don=E2=80=99t use and (and the majority of Ruby hackers A=46= AIK) it=E2=80=99s > > still fairly popular. > > =20 > =20 > =20 > It's actually easy to do now, but the old engine doesn't support that > either. That should be takes as evidence that Emacs Rubyists don't care= > about this variant much (I didn't see it in feature requests either). > =20 > So I'd rather wait for a request from someone who actually would use it= . > If you'd like to add it now, please propose the name of the user option= . > =20 > =20 I recall seeing StackOverflow questions about this in Emacs, but as I nei= ther practice nor promote this style I=E2=80=99m indifferent to supportin= g it in Emacs. I do, however, support it in RuboCop (https://github.com/b= batsov/rubocop/issues/661). If we decide to have it in Emacs we might use= a similar name for the config variable - =60ruby-end-alignment=E2=80=99 = with two options - =E2=80=98keword and =E2=80=98assignment. =20 --52b2b7a7_2e22fbb7_206 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline
On Th= ursday, December 19, 2013 at 6:35 AM, Dmitry Gutov wrote:
Bozhidar Batsov <bozhidar=40batsov.com> writes:

Personally I dis= like this style, because you=E2=80=99re basically it obscures
t= he semantics of the method arguments, but I acknowledge that I=E2=80=99ve=
seen it the wild.

= Ok, that's a -1, then.

=
=46or me it would be more beneficial if we supported a
variant of the style:

methods.each do =7Cmetho= d=7C
route=5Fset.add=5Froute(
self, =7B
path=5Finfo: route.route=5Fcompiled,
request=5Fm= ethod: method,
=7D, route=5Finfo: route
)
=
end

Should work now, wit= h revision 115602.

Something that=E2=80=99s not mentioned here, but it=E2=80=99s a big= ger problem for the
users is probably the fact that we don=E2=80= =99t support the following
indentation style:

x =3D if something
do=5Fsomething
end

Even if I don=E2=80=99t use and (and the majority of Ru= by hackers A=46AIK) it=E2=80=99s
still fairly popular.

It's actually easy to do now, but the= old engine doesn't support that
either. That should be takes a= s evidence that Emacs Rubyists don't care
about this variant mu= ch (I didn't see it in feature requests either).

So I'd rather wait for a request from someone who actually would use it.=
If you'd like to add it now, please propose the name of the us= er option.
=20 =20 =20 =20 =20
I recall seeing StackOverflow questions about th= is in Emacs, but as I neither practice nor promote this style I=E2=80=99m= indifferent to supporting it in Emacs. I do, however, support it in Rubo= Cop (https://github.com/bbatsov/rubocop/issues/= 661). If we decide to have it in Emacs we might use a similar name fo= r the config variable - =60ruby-end-alignment=E2=80=99 with two options -= =E2=80=98keword and =E2=80=98assignment.  

--52b2b7a7_2e22fbb7_206--