From: tsuucat via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: 43428@debbugs.gnu.org
Subject: bug#43428: [PATCH] Minor fix for nsxwidget patch
Date: Wed, 16 Sep 2020 01:58:02 +0900 [thread overview]
Message-ID: <1D3147D7-5450-42AB-9093-8EF9BA8D3705@icloud.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 101 bytes --]
Hi,
I made a minor patch for nsxwidget patch which is introduced in master
a month ago.
--
tsuucat
[-- Attachment #2: 0001-Minor-fix-for-nsxwidget-patch.patch --]
[-- Type: application/octet-stream, Size: 2234 bytes --]
From 34b12b559333d7f70d4930d0db20fb5f61a16d8c Mon Sep 17 00:00:00 2001
From: Masahiro Nakamura <tsuucat@icloud.com>
Date: Tue, 15 Sep 2020 15:35:32 +0900
Subject: [PATCH] ; Minor fix for nsxwidget patch
* lisp/xwdget.el (xwidget-webkit-download-dir)
(xwidget-webkit-save-as-file): Set version to 28.1 because the patch
was introduced in Emacs 28.0.50.
* src/nsxwidget.m: Fix typo.
---
lisp/xwidget.el | 4 ++--
src/nsxwidget.m | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/lisp/xwidget.el b/lisp/xwidget.el
index 074320855c..e5c1b47f3b 100644
--- a/lisp/xwidget.el
+++ b/lisp/xwidget.el
@@ -318,7 +318,7 @@ xwidget-webkit-mode
(defcustom xwidget-webkit-download-dir "~/Downloads/"
"Directory where download file saved."
- :version "27.1"
+ :version "28.1"
:type 'file)
(defun xwidget-webkit-save-as-file (url mime-type file-name)
@@ -348,7 +348,7 @@ xwidget-webkit-bookmark-jump-new-session
Otherwise, it will use `xwidget-webkit-last-session'.
When you set this variable to nil, consider further customization with
`xwidget-webkit-last-session-buffer'."
- :version "27.1"
+ :version "28.1"
:type 'boolean)
(defun xwidget-webkit-bookmark-make-record ()
diff --git a/src/nsxwidget.m b/src/nsxwidget.m
index 370abee395..c9651c87d5 100644
--- a/src/nsxwidget.m
+++ b/src/nsxwidget.m
@@ -33,14 +33,14 @@
/* Thoughts on NS Cocoa xwidget and webkit2:
Webkit2 process architecture seems to be very hostile for offscreen
- rendering techniques, which is used by GTK xwiget implementation;
+ rendering techniques, which is used by GTK xwidget implementation;
Specifically NSView level view sharing / copying is not working.
*** So only one view can be associcated with a model. ***
With this decision, implementation is plain and can expect best out
of webkit2's rationale. But process and session structures will
- diverge from GTK xwiget. Though, cosmetically similar usages can
+ diverge from GTK xwidget. Though, cosmetically similar usages can
be presented and will be preferred, if agreeable.
For other widget types, OSR seems possible, but will not care for a
--
2.28.0
next reply other threads:[~2020-09-15 16:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 16:58 tsuucat via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2020-09-15 23:54 ` bug#43428: [PATCH] Minor fix for nsxwidget patch Alan Third
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1D3147D7-5450-42AB-9093-8EF9BA8D3705@icloud.com \
--to=bug-gnu-emacs@gnu.org \
--cc=43428@debbugs.gnu.org \
--cc=tsuucat@icloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).