From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#72830: Big rectangular selections are slow Date: Fri, 30 Aug 2024 17:20:34 +0200 Message-ID: <1B4E9D0B-2223-42D9-BA22-17A5F6F49F84@gmail.com> References: <3F6C6CAB-8CD1-4336-B1D1-949E716139FE@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31113"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Michael Heerdegen , Eli Zaretskii , 72830@debbugs.gnu.org, Juri Linkov To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 30 17:22:45 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sk3SW-0007wU-D7 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 30 Aug 2024 17:22:44 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sk3Rw-0007RU-3T; Fri, 30 Aug 2024 11:22:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sk3Ru-0007RB-1P for bug-gnu-emacs@gnu.org; Fri, 30 Aug 2024 11:22:06 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sk3Rt-0007Ru-NP for bug-gnu-emacs@gnu.org; Fri, 30 Aug 2024 11:22:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:Date:In-Reply-To:From:Mime-Version:To:Subject; bh=ewsZqznCyPlr646BOxzfb2zmRnamrFLLXtnfvDLA6Ks=; b=BX94lKfAwN7hFnCZ/iCIyFJGdoQfzZA5y2ekrFUBcPLCCgvOwSKo0/6ewAVUUmtbD9Y+Wy5u7sBgMXKlmNAwwa8laE/UB1nTSovbPIOl6/tXuyfAkAzSo+Oz5LeOIgBO3vHUYgO9yZg0dawCBs6LxzOuObl3wFPTqggFjK+3e0H+K14uR6VdfB6MHgXJTxWkjN+0BbVrAC7TwQDpBZkhy32SoBE/yZQ13oEFlw5thWjfK3iwyDVFCfW81eRa7DfOl6FgSgr8Lb9O/DLBQ/uAK+1V5cb1AQV9LNqR0xqwa3+A4iWtzY0PzrIdpPlsh0YsFYJwFt/V1bWCjBe1KhQXyw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sk3So-00025x-4v for bug-gnu-emacs@gnu.org; Fri, 30 Aug 2024 11:23:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Aug 2024 15:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72830 X-GNU-PR-Package: emacs Original-Received: via spool by 72830-submit@debbugs.gnu.org id=B72830.17250313638019 (code B ref 72830); Fri, 30 Aug 2024 15:23:02 +0000 Original-Received: (at 72830) by debbugs.gnu.org; 30 Aug 2024 15:22:43 +0000 Original-Received: from localhost ([127.0.0.1]:53334 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sk3SV-00025G-29 for submit@debbugs.gnu.org; Fri, 30 Aug 2024 11:22:43 -0400 Original-Received: from mail-lj1-f170.google.com ([209.85.208.170]:61916) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sk3SR-00024v-Gc for 72830@debbugs.gnu.org; Fri, 30 Aug 2024 11:22:42 -0400 Original-Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-2f51b67e16dso22118491fa.3 for <72830@debbugs.gnu.org>; Fri, 30 Aug 2024 08:21:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725031236; x=1725636036; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=ewsZqznCyPlr646BOxzfb2zmRnamrFLLXtnfvDLA6Ks=; b=JvV03AbbyXZ87CoRYXeTVqpQKw9j+m+qfD9e6K4J/AiU5STP+Ogyg3dRkpnjg5QNDR Ahv+XuFVqRUwmuzjYIwWy/CsJvuBpOvkXq9l/gR/dGuqT0hni9aw+UakipjJVhcn2c70 INQPwdkY+HqWcyxZ/I5SvwHxtT/2Hv1yv6jttuJIncv9cfIDx094iNQp7EYNDYqXT/Jw FiqS9pxXDWVbFrOESzOxcVz0hjOvl443wUNfVnxcoD9+5xshg1ebYcP6T7NPofjUAo0J MwIyOo7epzH4v1OIkUXQDOIG79px1cLVdIkHtcX3EDK98QQ91OdXnE1Hoa6etBS6vMrT J2QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725031236; x=1725636036; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ewsZqznCyPlr646BOxzfb2zmRnamrFLLXtnfvDLA6Ks=; b=ir/X2CkGr9FXYQ7nzHzmmsyYtmleWaJrfoxDOHLMmxO3ATMfi0Q68unU1auNQ+UOUF ogFkwF4l2WyWy3zlkY1cpsZ/gIeg4LjPwM93JYfjIL4OfHf3MXgaqGKsIK4onZ0b0dxL aDmUH8OOB3vP59y/aL+8aHdOcQkHmK6tta/+5R/fWoG1LkJQdfi8PwmBbmKRIM1kFPfy 7VQuoqganr70mEDLlhqj8K30OOjoXED/8noZAT0jQoA2zT3otYLQzrvemuMGMvE/mmte 6DAPnG7zzhv095xKrLd6zBNNpsdYUdYqZvwPbdOJPzCYEPlVglisuvn6u3oRcq7YM7N8 D+kA== X-Forwarded-Encrypted: i=1; AJvYcCU3zjIRCf4c4QQ30yVol8Xjp3MwKyM+y+Y9lrGrVC8dH0vh0WEkgLolYL9EOaJJGLGtUZadVg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzRo3BNmBW67gP+DXYvrEhWw4+XfKuwX/Sz6U5tN8IPKGSZw25Z vwbidLUNmOApHjbT8dlELohbGqSsiLO5RBCpA9QCg7XIsMvVYnMq X-Google-Smtp-Source: AGHT+IF08vDdjHGs8EBGNSZZBmKNQVn0G8UVcCFlwWJRnSLllhYOnYegbrHH59xlHqx0S8KHeCPFOQ== X-Received: by 2002:a05:651c:199f:b0:2f0:198e:cf86 with SMTP id 38308e7fff4ca-2f6108908bamr58709251fa.33.1725031235975; Fri, 30 Aug 2024 08:20:35 -0700 (PDT) Original-Received: from smtpclient.apple (c188-150-191-82.bredband.tele2.se. [188.150.191.82]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-2f614f23a93sm7105071fa.51.2024.08.30.08.20.34 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 30 Aug 2024 08:20:34 -0700 (PDT) In-Reply-To: X-Mailer: Apple Mail (2.3654.120.0.1.15) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:290967 Archived-At: 29 aug. 2024 kl. 22.04 skrev Stefan Monnier > We should investigate the case(s) where it doesn't work well and fix > them (not by changing your `pre-redisplay-function` but by re-running > that hook), because these cases likely affect other users of this hook > (such as the normal region highlighting). What would the problem be for normal (contiguous) region highlighting? = There is a single overlay, so there should be no particular cost for = large selections. Is there? The latest patch posted seems to work well enough and all but eliminates = the problem (when `select-active-regions` is nil, anyway), so that it = outweighs some rare cosmetic issues. (Those cosmetic issues may occur when a rectangular selection straddles = invisible text, because this invalidates the assumption that the other = end of the selection is at most (window-height) away. But the selection = still operate on the invisible test, so I don't think it's a problem in = practice.) I think the patch is good enough for master. If you have an even better = solution, perhaps it could be made as a subsequent improvement?