From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#19399: js mode comment-filling fixlet Date: Thu, 12 Jan 2017 05:12:00 +0300 Message-ID: <19da0b6f-a9eb-dbd0-a968-9aab53a61b8d@yandex.ru> References: <877f662krq.fsf@tromey.com> <8760lq2jg1.fsf@users.sourceforge.net> <87wpe6149s.fsf@tromey.com> <87k2a31t29.fsf@tromey.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1484191722 976 195.159.176.226 (12 Jan 2017 03:28:42 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 12 Jan 2017 03:28:42 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:50.0) Gecko/20100101 Thunderbird/50.0 Cc: 19399@debbugs.gnu.org, Daniel Colascione , npostavs@users.sourceforge.net To: Tom Tromey Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jan 12 04:28:37 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cRW3l-0006hP-MQ for geb-bug-gnu-emacs@m.gmane.org; Thu, 12 Jan 2017 04:28:17 +0100 Original-Received: from localhost ([::1]:59168 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cRW3q-0007si-25 for geb-bug-gnu-emacs@m.gmane.org; Wed, 11 Jan 2017 22:28:22 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48726) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cRUt0-0004tC-1G for bug-gnu-emacs@gnu.org; Wed, 11 Jan 2017 21:13:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cRUsw-0001Ck-SY for bug-gnu-emacs@gnu.org; Wed, 11 Jan 2017 21:13:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35184) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cRUsw-0001Cd-Oy for bug-gnu-emacs@gnu.org; Wed, 11 Jan 2017 21:13:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cRUsw-0001hJ-Ge for bug-gnu-emacs@gnu.org; Wed, 11 Jan 2017 21:13:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 12 Jan 2017 02:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19399 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19399-submit@debbugs.gnu.org id=B19399.14841871306454 (code B ref 19399); Thu, 12 Jan 2017 02:13:02 +0000 Original-Received: (at 19399) by debbugs.gnu.org; 12 Jan 2017 02:12:10 +0000 Original-Received: from localhost ([127.0.0.1]:50582 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cRUs5-0001g2-S7 for submit@debbugs.gnu.org; Wed, 11 Jan 2017 21:12:10 -0500 Original-Received: from mail-lf0-f66.google.com ([209.85.215.66]:32775) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cRUs3-0001fo-Tp for 19399@debbugs.gnu.org; Wed, 11 Jan 2017 21:12:08 -0500 Original-Received: by mail-lf0-f66.google.com with SMTP id k62so469438lfg.0 for <19399@debbugs.gnu.org>; Wed, 11 Jan 2017 18:12:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=HA2KIzubEcowZUvDQiWaeR2yeBscDp3QoR0Yg8+A1ys=; b=JjvcJOWk/CCbvhPnaed/aJPg/OGkuVJMxYOeaOpvf7Bn/rGSZvljzCDiFlSoO1JOM5 suNZDVfvhSK1XbOulq5Jt1ctaVI1S6827kA2d4ebfvCxga8fmU1LG4sQhQuyakJKFXvC Eoks0JvxOog0jx5BLR5QN41+6mPRfu8mOS3+VYkaZBMjjCaRyEU88xPGbXjD63QTyyC5 cy+otXI8v6isnDpsK1OKMxH3PQEZ0B5m4l+0/plzLy8PTsj3B2zWKfM+9xJAKAjX3vKK J6CGFYaPRmAyRcc0VY53TPu6OfiLZJPczlS2KcSRourpHOQGErk0euZXNP1lQ+5Ciks3 k2jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=HA2KIzubEcowZUvDQiWaeR2yeBscDp3QoR0Yg8+A1ys=; b=PVmI01o1p8VrRpfWyeC1kfCSb/ymV63CXO5lS4GX20K22QQTTETNaZ4l2IxudGx4/3 P1hf755k97NEW7KStTz1PepJJFEZ+WhmZMA12tnJ6r4t5I1+vhwZNQvYhDFfOKMigfk8 K3J14CvlZ+fcS5AHBpAHkriRCgBOMb19D/KRNM9vjAS9n5RgJpaas6PiL9uQyH50cqeI krXobY64oP/lreOSCV4ZoxmKWYUQPOQ8TBcKi3cFPolwRDm6OTRHqQ2tA/VmtBhZVc9c 8cg5dFNDZBtNZRVE3L7w0JuHN6ny7VTwxv4ft1l39gQ2rMKpIXhOoU1MNX632gvvHbtV 5xGw== X-Gm-Message-State: AIkVDXKgOXNJULSZ9kePqmQxlyMAqYcaGjAfCljqDxg7KyozNEOUB/ZItFKdvsD5stIBQw== X-Received: by 10.25.38.1 with SMTP id m1mr4686099lfm.102.1484187122074; Wed, 11 Jan 2017 18:12:02 -0800 (PST) Original-Received: from [192.168.1.174] ([178.252.127.239]) by smtp.googlemail.com with ESMTPSA id y26sm1871315lja.22.2017.01.11.18.12.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Jan 2017 18:12:01 -0800 (PST) In-Reply-To: <87k2a31t29.fsf@tromey.com> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:128027 Archived-At: On 10.01.2017 06:40, Tom Tromey wrote: > Tom> I think I should perhaps write some tests for this patch. > > Here's the patch with tests. I couldn't actually find a way to make the > contents of c-block-comment-start-regexp matter. Thanks for the tests (here using ERT seems appropriate). But if the contents of the variable don't matter, why not skip on setting it in js-mode?