unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Gemini Lasswell <gazally@runbox.com>,
	Noam Postavsky <npostavs@gmail.com>
Cc: 31688@debbugs.gnu.org
Subject: bug#31688: 26.1.50; Byte compiler confuses two string variables
Date: Sat, 2 Jun 2018 17:40:47 -0700 (PDT)	[thread overview]
Message-ID: <197f6fee-36ae-4c55-bf9d-229146343937@default> (raw)
In-Reply-To: <87o9gsztqg.fsf@runbox.com>

> just searched the Elisp reference
> looking for any any warnings not to use destructive functions on
> literals, and didn't find anything. 

It's not really about destructive functions.

It's about the fact that you might not have two different
strings, and you should not assume that you do.

It's about `eq'.  For the Emacs byte-compiler, apparently,
multiple occurrences of a string literal in the code are
compiled to the same string object.  Thinking you have two
separate strings is the problem.  Anything you might want
to think or say about the use of "destructive" functions
follows from the fact that you have a single string.







  parent reply	other threads:[~2018-06-03  0:40 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-02 17:51 bug#31688: 26.1.50; Byte compiler confuses two string variables Gemini Lasswell
2018-06-02 18:02 ` Noam Postavsky
2018-06-02 22:52   ` Gemini Lasswell
2018-06-02 23:25     ` Noam Postavsky
2018-06-03  0:40     ` Drew Adams [this message]
2018-06-02 23:03   ` Drew Adams
2018-06-02 23:38   ` Phil Sainty
2018-06-02 23:54     ` Noam Postavsky
2018-06-03 12:32       ` Phil Sainty
2018-06-03 13:05         ` Andreas Schwab
2018-06-04 10:02           ` Phil Sainty
2018-06-04 15:58             ` Eli Zaretskii
2018-06-04 17:01             ` Andreas Schwab
2018-06-08 15:09               ` Eli Zaretskii
2018-06-03  0:02     ` Michael Heerdegen
2018-06-03  0:46       ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=197f6fee-36ae-4c55-bf9d-229146343937@default \
    --to=drew.adams@oracle.com \
    --cc=31688@debbugs.gnu.org \
    --cc=gazally@runbox.com \
    --cc=npostavs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).