* bug#12460: 24.2.50; toggling read-only interactively: echo new state
@ 2012-09-17 15:37 Drew Adams
2012-09-17 16:05 ` Drew Adams
0 siblings, 1 reply; 4+ messages in thread
From: Drew Adams @ 2012-09-17 15:37 UTC (permalink / raw)
To: 12460
For `toggle-read-only' and similar commands: Please add an optional,
boolean MSGP parameter which when non-nil echoes the new state. Make
the argument non-nil when the command is called interactively.
In GNU Emacs 24.2.50.1 (i386-mingw-nt5.1.2600)
of 2012-09-17 on MARVIN
Bzr revision: 110062 cyd@gnu.org-20120917054104-r93rtwkrtva73ewe
Windowing system distributor `Microsoft Corp.', version 5.1.2600
Configured using:
`configure --with-gcc (4.7) --no-opt --enable-checking --cflags
-ID:/devel/emacs/libs/libXpm-3.5.8/include
-ID:/devel/emacs/libs/libXpm-3.5.8/src
-ID:/devel/emacs/libs/libpng-dev_1.4.3-1/include
-ID:/devel/emacs/libs/zlib-dev_1.2.5-2/include
-ID:/devel/emacs/libs/giflib-4.1.4-1/include
-ID:/devel/emacs/libs/jpeg-6b-4/include
-ID:/devel/emacs/libs/tiff-3.8.2-1/include
-ID:/devel/emacs/libs/gnutls-3.0.9/include
-ID:/devel/emacs/libs/libiconv-1.13.1-1-dev/include
-ID:/devel/emacs/libs/libxml2-2.7.8/include/libxml2'
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#12460: 24.2.50; toggling read-only interactively: echo new state
2012-09-17 15:37 bug#12460: 24.2.50; toggling read-only interactively: echo new state Drew Adams
@ 2012-09-17 16:05 ` Drew Adams
2012-09-17 17:32 ` Stefan Monnier
0 siblings, 1 reply; 4+ messages in thread
From: Drew Adams @ 2012-09-17 16:05 UTC (permalink / raw)
To: 12460
And since you've now made `toggle-read-only' obsolete (though it is still
invoked by `C-x C-q' - see bug #12462), please make `read-only-mode' echo the
new state as well. It too should provide a Boolean arg or equivalent to control
the display of the new-state message from Lisp.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#12460: 24.2.50; toggling read-only interactively: echo new state
2012-09-17 16:05 ` Drew Adams
@ 2012-09-17 17:32 ` Stefan Monnier
2012-09-17 17:44 ` Drew Adams
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Monnier @ 2012-09-17 17:32 UTC (permalink / raw)
To: Drew Adams; +Cc: 12460
> And since you've now made `toggle-read-only' obsolete (though it is
> still invoked by `C-x C-q' - see bug #12462), please make
> `read-only-mode' echo the new state as well. It too should provide
> a Boolean arg or equivalent to control the display of the new-state
> message from Lisp.
All minor modes follow the same rule and use `called-interactively-p'
rather than an extra argument. So if we want to change it it's in
easy-mmode.el and will apply to all minor modes.
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#12460: 24.2.50; toggling read-only interactively: echo new state
2012-09-17 17:32 ` Stefan Monnier
@ 2012-09-17 17:44 ` Drew Adams
0 siblings, 0 replies; 4+ messages in thread
From: Drew Adams @ 2012-09-17 17:44 UTC (permalink / raw)
To: 'Stefan Monnier'; +Cc: 12460
> > And since you've now made `toggle-read-only' obsolete (though it is
> > still invoked by `C-x C-q' - see bug #12462), please make
> > `read-only-mode' echo the new state as well. It too should provide
> > a Boolean arg or equivalent to control the display of the new-state
> > message from Lisp.
>
> All minor modes follow the same rule and use `called-interactively-p'
> rather than an extra argument. So if we want to change it it's in
> easy-mmode.el and will apply to all minor modes.
I see. And I see that `read-only-mode' already does echo the new state when
invoked interactively. I guess this can be closed - I'll do that. But please
update the doc (bug #12462).
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-09-17 17:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-17 15:37 bug#12460: 24.2.50; toggling read-only interactively: echo new state Drew Adams
2012-09-17 16:05 ` Drew Adams
2012-09-17 17:32 ` Stefan Monnier
2012-09-17 17:44 ` Drew Adams
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).