* bug#7349: 24.0.50; "e" should work in vc-dir-mode
@ 2010-11-06 21:20 rogers-emacs
2011-03-03 7:32 ` Glenn Morris
0 siblings, 1 reply; 5+ messages in thread
From: rogers-emacs @ 2010-11-06 21:20 UTC (permalink / raw)
To: 7349
It has long annoyed me that "e" finds the file in dired-mode, but
just beeps in vc-dir-mode. The patch below rectifies the situation.
-- Bob Rogers
http://www.rgrjr.com/
------------------------------------------------------------------------
diff --git a/lisp/vc/vc-dir.el b/lisp/vc/vc-dir.el
index 4397251..5c8b690 100644
--- a/lisp/vc/vc-dir.el
+++ b/lisp/vc/vc-dir.el
@@ -266,6 +266,7 @@ See `run-hooks'."
(define-key map [C-up] 'vc-dir-previous-directory)
;; The remainder.
(define-key map "f" 'vc-dir-find-file)
+ (define-key map "e" 'vc-dir-find-file) ;; dired-mode compatibility.
(define-key map "\C-m" 'vc-dir-find-file)
(define-key map "o" 'vc-dir-find-file-other-window)
(define-key map "\C-c\C-c" 'vc-dir-kill-dir-status-process)
^ permalink raw reply related [flat|nested] 5+ messages in thread
* bug#7349: 24.0.50; "e" should work in vc-dir-mode
2010-11-06 21:20 bug#7349: 24.0.50; "e" should work in vc-dir-mode rogers-emacs
@ 2011-03-03 7:32 ` Glenn Morris
2011-03-04 4:33 ` Stefan Monnier
0 siblings, 1 reply; 5+ messages in thread
From: Glenn Morris @ 2011-03-03 7:32 UTC (permalink / raw)
To: 7349-done
Version: 24.1
rogers-emacs@rgrjr.dyndns.org wrote:
> It has long annoyed me that "e" finds the file in dired-mode, but
> just beeps in vc-dir-mode. The patch below rectifies the situation.
OK, be annoyed no longer.
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#7349: 24.0.50; "e" should work in vc-dir-mode
2011-03-03 7:32 ` Glenn Morris
@ 2011-03-04 4:33 ` Stefan Monnier
2011-03-04 5:08 ` Glenn Morris
0 siblings, 1 reply; 5+ messages in thread
From: Stefan Monnier @ 2011-03-04 4:33 UTC (permalink / raw)
To: 7349
>> It has long annoyed me that "e" finds the file in dired-mode, but
>> just beeps in vc-dir-mode.
vc-dir-mode lacks many of dired bindings. That's one of the reasons to
have a different mode.
Stefan
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#7349: 24.0.50; "e" should work in vc-dir-mode
2011-03-04 4:33 ` Stefan Monnier
@ 2011-03-04 5:08 ` Glenn Morris
2011-03-05 3:59 ` Stefan Monnier
0 siblings, 1 reply; 5+ messages in thread
From: Glenn Morris @ 2011-03-04 5:08 UTC (permalink / raw)
To: Stefan Monnier; +Cc: 7349
Stefan Monnier wrote:
> vc-dir-mode lacks many of dired bindings. That's one of the reasons to
> have a different mode.
Don't know what that means. Feel free to revert and tag this wontfix.
(Being small-minded, I like consistency.)
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#7349: 24.0.50; "e" should work in vc-dir-mode
2011-03-04 5:08 ` Glenn Morris
@ 2011-03-05 3:59 ` Stefan Monnier
0 siblings, 0 replies; 5+ messages in thread
From: Stefan Monnier @ 2011-03-05 3:59 UTC (permalink / raw)
To: Glenn Morris; +Cc: 7349
>> vc-dir-mode lacks many of dired bindings. That's one of the reasons to
>> have a different mode.
> Don't know what that means. Feel free to revert and tag this wontfix.
> (Being small-minded, I like consistency.)
That it's also good to keep keys open for future use.
I'm not asking to revert the change, just pointing out that we should
not do those things too lightly. VC-dir hasn't seen much improvement
and is still *very* primitive, sadly, but there's a lot of room for
improvement and this might end up wanting a lot of keys.
Stefan
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-03-05 3:59 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-06 21:20 bug#7349: 24.0.50; "e" should work in vc-dir-mode rogers-emacs
2011-03-03 7:32 ` Glenn Morris
2011-03-04 4:33 ` Stefan Monnier
2011-03-04 5:08 ` Glenn Morris
2011-03-05 3:59 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).