From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#47894: 28.0.50; isearch does not work if enable-recursive-minibuffers is on and some input method is set. Date: Wed, 21 Apr 2021 07:49:28 +0000 Message-ID: <192e82f20f92affaec0e@heytings.org> References: <87eef6p8bh.fsf@gmail.com> <874kg0d8ui.fsf@mail.linkov.net> <192e82f20f7e5133aaea@heytings.org> <6f6e4aa5-9fdf-b4e6-04d5-c43448d67623@gmx.at> Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26702"; mail-complaints-to="usenet@ciao.gmane.io" Cc: max.brieiev@gmail.com, 47894@debbugs.gnu.org, Juri Linkov To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 21 09:50:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lZ7ci-0006pz-Jo for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 21 Apr 2021 09:50:12 +0200 Original-Received: from localhost ([::1]:57010 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lZ7ch-0005G2-Jo for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 21 Apr 2021 03:50:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48660) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZ7cY-0005Fm-2L for bug-gnu-emacs@gnu.org; Wed, 21 Apr 2021 03:50:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45332) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lZ7cX-0000ss-Ql for bug-gnu-emacs@gnu.org; Wed, 21 Apr 2021 03:50:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lZ7cX-0002P6-Ne; Wed, 21 Apr 2021 03:50:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Wed, 21 Apr 2021 07:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47894 X-GNU-PR-Package: emacs,gnus Original-Received: via spool by 47894-submit@debbugs.gnu.org id=B47894.16189913719199 (code B ref 47894); Wed, 21 Apr 2021 07:50:01 +0000 Original-Received: (at 47894) by debbugs.gnu.org; 21 Apr 2021 07:49:31 +0000 Original-Received: from localhost ([127.0.0.1]:56878 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZ7c3-0002OJ-EH for submit@debbugs.gnu.org; Wed, 21 Apr 2021 03:49:31 -0400 Original-Received: from heytings.org ([95.142.160.155]:46964) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZ7c1-0002O8-S7 for 47894@debbugs.gnu.org; Wed, 21 Apr 2021 03:49:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1618991368; bh=eJrTUJv8GvBUhgKJtkFH4ibs/avnIRttVflckyb1oSc=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=jcvH067HIP7Gf/GQGaVdoNr2LyS6SIlWWhQqNdBEq7iHhuhuHrSqmMQbL3p28rs6c Wu5NTU/zpS9DUF9FNJ39JgcCmhwppGNTLJCcFtfZwgP5Ntdjw3DDOLDi9uOnvn0efv XxvQZP4MdPqYECujAEufaYJmoIdQna8Ia/s7QzpIwDf3uXzPloU02V4wcs02zeZMfz 8xceCSQoOQ3QD81CpGiotQn1WYzwjCtEbv95YOoHlCz75ToeCoFWc9UQFi/FPx/aAw zzNt6HDGNzrN96gKGBtuq2TcFiLzvfYMVeQ62nWDjv9iGMoGa1biR4AufcM4SgIPni GaS0T01EA2e8Q== In-Reply-To: <6f6e4aa5-9fdf-b4e6-04d5-c43448d67623@gmx.at> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:204583 Archived-At: >> Okay, thanks for the clarification. IIUC the right way to determine >> what the "current buffer" is (from a user's point of view: in which >> buffer will "a" be added if I press "a") is what I do: (window-buffer >> (selected-window)) and not what I did: (current-buffer)? > > For users (eq (current-buffer) (window-buffer)) _should_ be invariant. > When and if an application temporarily violates that invariant, it > should reestablish it before the user can see it. So if an application > calls `display-buffer' in a state where the invariant does not hold, it > should handle that case including the complication that `display-buffer' > might have selected another window. And it goes without saying that a > display buffer action should never violate that invariant. > I see. So in this case the bug was elsewhere as I thought, it's display-buffer-select which was wrong (as you said it should have used pop-to-buffer) and not the code I added in isearch-post-command-hook. Anyway using (window-buffer (selected-window)) should not harm, and is an extra safety against display buffer actions doing something weird.