unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: nickrob@snap.net.nz (Nick Roberts)
To: Michael Welsh Duggan <md5i@md5i.com>, 5060@emacsbugs.donarmstrong.com
Subject: bug#5060: More debugging information
Date: Sun, 29 Nov 2009 13:36:05 +1300	[thread overview]
Message-ID: <19217.49653.913430.150725@totara.tehura.co.nz> (raw)
In-Reply-To: <874oofl2aq.fsf@maru.md5i.com>

 > Shortly before the failure occurs, gdb-frame-handler is called.  In the
 > context of the failure, the frame variable is set to:
 > 
 >   ((line . "29") (file . "longjmp.c") (func . "__libc_siglongjmp") 
 >    (addr . "0xb79ef6c1") (level . "0"))
 > 
 > gdb-selected-file is nil, since there is no 'fullname.
 > gdb-selected-line gets 29.  So, gud-last-frame is '(nil . 29).
 > gud-display-frame is then called, which calls gud-display-line with the
 > args from gud-last frame.  I.e., (gud-display-frame nil 29).  This nil
 > is what is later causing problems when gud-find-file is called.
 > 
 > My guess is that gud-display-frame should not be called if
 > gdb-selected-file is nil.  But I do not understand the code well enough
 > to know that this is the case.

That sounds right.  Using gdb-frame-handler to get the current line is a bit of
a hack because gdb doesn't always print the location when it stops.  This code
doesn't look quite right.  Does the patch below work?

-- 
Nick                                           http://users.snap.net.nz/~nickrob


*** gdb-mi.el.~1.53.~	2009-11-03 19:06:46.000000000 +1300
--- gdb-mi.el	2009-11-29 00:41:01.000000000 +1300
*************** overlay arrow in source buffer."
*** 3754,3762 ****
        (setq gdb-frame-number (bindat-get-field frame 'level))
        (setq gdb-frame-address (bindat-get-field frame 'addr))
        (let ((line (bindat-get-field frame 'line)))
!         (setq gdb-selected-line (or (and line (string-to-number line))
!                                     nil)) ; don't fail if line is nil
!         (when line ; obey the current file only if we have line info
            (setq gud-last-frame (cons gdb-selected-file gdb-selected-line))
            (gud-display-frame)))
        (if gud-overlay-arrow-position
--- 3754,3761 ----
        (setq gdb-frame-number (bindat-get-field frame 'level))
        (setq gdb-frame-address (bindat-get-field frame 'addr))
        (let ((line (bindat-get-field frame 'line)))
!         (setq gdb-selected-line (and line (string-to-number line)))
!         (when (and gdb-selected-file gdb-selected-line)
            (setq gud-last-frame (cons gdb-selected-file gdb-selected-line))
            (gud-display-frame)))
        (if gud-overlay-arrow-position





  reply	other threads:[~2009-11-29  0:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-28  4:07 bug#5060: More debugging information Michael Welsh Duggan
2009-11-29  0:36 ` Nick Roberts [this message]
2009-11-30  3:59   ` Michael Welsh Duggan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19217.49653.913430.150725@totara.tehura.co.nz \
    --to=nickrob@snap.net.nz \
    --cc=5060@emacsbugs.donarmstrong.com \
    --cc=md5i@md5i.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).