From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Barzilay Newsgroups: gmane.emacs.bugs Subject: bug#4117: 23.1; isearch + isearch-allow-scroll loses shift Date: Wed, 12 Aug 2009 19:59:11 -0400 Message-ID: <19075.22351.611859.436166@winooski.ccs.neu.edu> References: <19073.19554.183166.905858@winooski.ccs.neu.edu> <87bpmkhcdb.fsf@mail.jurta.org> Reply-To: Eli Barzilay , 4117@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1250122031 31149 80.91.229.12 (13 Aug 2009 00:07:11 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 13 Aug 2009 00:07:11 +0000 (UTC) Cc: 4117@emacsbugs.donarmstrong.com To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Aug 13 02:07:04 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MbNqQ-0005SA-Jl for geb-bug-gnu-emacs@m.gmane.org; Thu, 13 Aug 2009 02:07:02 +0200 Original-Received: from localhost ([127.0.0.1]:38017 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MbNqO-0004BL-6y for geb-bug-gnu-emacs@m.gmane.org; Wed, 12 Aug 2009 20:07:00 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MbNqJ-0004B6-IB for bug-gnu-emacs@gnu.org; Wed, 12 Aug 2009 20:06:55 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MbNqF-000481-PD for bug-gnu-emacs@gnu.org; Wed, 12 Aug 2009 20:06:55 -0400 Original-Received: from [199.232.76.173] (port=55194 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MbNqF-00047y-MC for bug-gnu-emacs@gnu.org; Wed, 12 Aug 2009 20:06:51 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:51512) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MbNqF-0003Fr-1C for bug-gnu-emacs@gnu.org; Wed, 12 Aug 2009 20:06:51 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7D06n0X017002; Wed, 12 Aug 2009 17:06:49 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n7D055EU016274; Wed, 12 Aug 2009 17:05:05 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Eli Barzilay Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Thu, 13 Aug 2009 00:05:05 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 4117 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 4117-submit@emacsbugs.donarmstrong.com id=B4117.125012155415163 (code B ref 4117); Thu, 13 Aug 2009 00:05:05 +0000 Original-Received: (at 4117) by emacsbugs.donarmstrong.com; 12 Aug 2009 23:59:14 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from barzilay.org (winooski.ccs.neu.edu [129.10.115.117]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7CNxCOP015157 for <4117@emacsbugs.donarmstrong.com>; Wed, 12 Aug 2009 16:59:13 -0700 Original-Received: from eli by barzilay.org with local (Exim 4.66) (envelope-from ) id 1MbNip-0001VO-K3; Wed, 12 Aug 2009 19:59:11 -0400 In-Reply-To: <87bpmkhcdb.fsf@mail.jurta.org> X-Mailer: VM 7.19 under Emacs 22.1.1 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Wed, 12 Aug 2009 20:06:55 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:30138 Archived-At: On Aug 12, Juri Linkov wrote: > > When `isearch-allow-scroll' is turned on, then exiting isearch with > > a movement command loses its "shift" status. To see this, use > > isearch and look for some string, then hit C-S-right a few times and > > you will see that the first one does not starts a selection. > > When `isearch-allow-scroll' is non-nil, then > `isearch-other-meta-char' calls > `isearch-reread-key-sequence-naturally', but `read-key-sequence' in > the latter function removes the shift modifier and sets > `this-command-keys-shift-translated' to t. Yes, I hacked around it with my own version of `isearch-other-meta-char'. (But I don't think that it's a good hack...) > This is just an analysis. I currently don't know what is the right > way to fix this. Maybe simply add the shift modifier back to the > key when `this-command-keys-shift-translated' to t after > `read-key-sequence'. This sounds like a good strategy, given that shift is now very useful in general. -- ((lambda (x) (x x)) (lambda (x) (x x))) Eli Barzilay: http://barzilay.org/ Maze is Life!