From: Dmitry Gutov <dmitry@gutov.dev>
To: Eli Zaretskii <eliz@gnu.org>
Cc: jporterbugs@gmail.com, 71525-done@debbugs.gnu.org, steven@stebalien.com
Subject: bug#71525: 30.0.50; Spin in delete-region/interval_deletion_adjustment Spin in delete-region/interval_deletion_adjustment)
Date: Fri, 14 Jun 2024 22:13:37 +0300 [thread overview]
Message-ID: <18ff92ba-02a5-4c3d-aa8b-fd94cb270528@gutov.dev> (raw)
In-Reply-To: <86v82bwef4.fsf@gnu.org>
On 14/06/2024 21:46, Eli Zaretskii wrote:
>> Date: Fri, 14 Jun 2024 21:17:22 +0300
>> Cc:steven@stebalien.com,jporterbugs@gmail.com,71525@debbugs.gnu.org
>> From: Dmitry Gutov<dmitry@gutov.dev>
>>
>> On 14/06/2024 10:13, Eli Zaretskii wrote:
>>>> /* Insert a sequence of NCHARS chars which occupy NBYTES bytes
>>>> starting at GAP_END_ADDR - NBYTES (if text_at_gap_tail) and at
>>>> - GPT_ADDR (if not text_at_gap_tail). */
>>>> + GPT_ADDR (if not text_at_gap_tail).
>>>> +
>>>> + If BEFORE_MARKERS is true, insert before markers. */
>>> This commentary should also mention process.c as the single caller
>>> using this facility in unconventional ways.
>> Also note that I did make some effort to make the field
>> coding->insert_before_markers used consistently: in the changeset, it's
>> not just obeyed on the code path that decode_coding_c_string goes
>> through - it's used anywhere where insert_from_gap is called and a
>> coding_system structure is available - e.g. in encode_coding.
>>
>> Also in decode_coding_gap, but that one seems to only have one caller
>> (insert-file-contents), so that choice is moot.
>>
>> Something else I've noticed (a bit off topic): insert_from_gap_1's
>> comments says that it "does not invalidate any cache, nor update any
>> markers, nor record any buffer modification information of any sort",
>> but then it calls treesit_record_change when available. Not sure we need
>> to change that, but maybe we should update the comment, at least.
> Thanks, done.
>
> I think we can now close this bug.
Thanks everyone! I think we've now crash-debugged every new code path. ;-)
next prev parent reply other threads:[~2024-06-14 19:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-12 19:20 bug#71525: 30.0.50; Spin in delete-region/interval_deletion_adjustment Steven Allen via Bug reports for GNU Emacs, the Swiss army knife of text editors
[not found] ` <handler.71525.B.171822007123849.ack@debbugs.gnu.org>
2024-06-13 5:14 ` bug#71525: Acknowledgement (30.0.50; Spin in delete-region/interval_deletion_adjustment) Steven Allen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-13 5:52 ` bug#71525: 30.0.50; Spin in delete-region/interval_deletion_adjustment " Eli Zaretskii
2024-06-13 15:32 ` Steven Allen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-13 15:52 ` Eli Zaretskii
2024-06-13 16:00 ` Steven Allen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-13 16:06 ` Steven Allen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-13 16:31 ` Eli Zaretskii
2024-06-13 21:47 ` Dmitry Gutov
2024-06-13 23:41 ` Dmitry Gutov
2024-06-14 7:13 ` Eli Zaretskii
2024-06-14 16:51 ` Dmitry Gutov
2024-06-14 18:14 ` Steven Allen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-14 18:17 ` Dmitry Gutov
2024-06-14 18:46 ` Eli Zaretskii
2024-06-14 19:13 ` Dmitry Gutov [this message]
2024-06-13 19:18 ` Jim Porter
2024-06-13 19:42 ` Steven Allen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-13 5:49 ` bug#71525: 30.0.50; Spin in delete-region/interval_deletion_adjustment Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18ff92ba-02a5-4c3d-aa8b-fd94cb270528@gutov.dev \
--to=dmitry@gutov.dev \
--cc=71525-done@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=jporterbugs@gmail.com \
--cc=steven@stebalien.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).