From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#38343: 27.0.50; vc git: Cannot edit outgoing log (like git commit --amend) Date: Wed, 27 Nov 2019 02:10:33 +0200 Message-ID: <18f1bbf5-46ad-99e5-51dc-1bd9ddfece33@yandex.ru> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="129518"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 Cc: 38343@debbugs.gnu.org To: Fredrik Nyqvist Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 27 01:11:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iZkvH-000XY4-5W for geb-bug-gnu-emacs@m.gmane.org; Wed, 27 Nov 2019 01:11:11 +0100 Original-Received: from localhost ([::1]:60228 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZkvG-0007bN-1d for geb-bug-gnu-emacs@m.gmane.org; Tue, 26 Nov 2019 19:11:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39951) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZkv9-0007bC-TV for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2019 19:11:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iZkv7-0005CF-QO for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2019 19:11:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47244) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iZkv7-0005C9-MP for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2019 19:11:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iZkv7-000590-Ip for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2019 19:11:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 27 Nov 2019 00:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38343 X-GNU-PR-Package: emacs Original-Received: via spool by 38343-submit@debbugs.gnu.org id=B38343.157481344419746 (code B ref 38343); Wed, 27 Nov 2019 00:11:01 +0000 Original-Received: (at 38343) by debbugs.gnu.org; 27 Nov 2019 00:10:44 +0000 Original-Received: from localhost ([127.0.0.1]:53217 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZkuq-00058P-Iz for submit@debbugs.gnu.org; Tue, 26 Nov 2019 19:10:44 -0500 Original-Received: from mail-wr1-f42.google.com ([209.85.221.42]:41494) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZkuo-000589-IF for 38343@debbugs.gnu.org; Tue, 26 Nov 2019 19:10:42 -0500 Original-Received: by mail-wr1-f42.google.com with SMTP id b18so24577597wrj.8 for <38343@debbugs.gnu.org>; Tue, 26 Nov 2019 16:10:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=e6gupd+f7XhCfUTjnRgV+r9ZZ1b79RLV3SwGxtM/BHs=; b=qkFuPQa5FlCpAcPx+YvvtyJ73oALDnUpQPZ0d3wOvq/J+teXybR5Z9SXjPBtcO0hcU 9n3OPI1m7MeHWyHThp6IrTKS8MHulJDxt3VtyiaofxvDLO777fzgJAtKYUii8iVyKVqm TybCxkPOgD0jHu7XZ/ReOmen5Bayx14r2gepfLB+Zu5Awd+gRHl+Dn+wLDh2Ute/xyBG Gk4dP9nwQIqCdyA1z08guJ6oAnoIm5ztGy7uwudolrFh2O0KeAtce5VJtTTr+SqrvvIK +7J+071GQ8rM5dGNGcMdzovYaMib3n4S5Q7Ksu7BocOTUup7IetU/9K23IaaQBwdBfrN P/FQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=e6gupd+f7XhCfUTjnRgV+r9ZZ1b79RLV3SwGxtM/BHs=; b=FNpAXE9KxKdChdOPOg9GboTIgcNMn97XQMkHb3j843/Kn8I/n5WZFeABUF3HG23l3h aGwPeK9EONWUbLXkZZnHajW1wN9FOGik/yRKAx6UsW6Aq40doUxVQrDNbotbmqSniN9l eLsPts/DbdNTXMZYqoKihzz5J4G+/D8Pg+dh/v54VkCZtQAxf8yWUwWRVHodP155CEAk 3z5C474JWLUgy/JQe1FUl8jEw5ZDhbGLGgUPuqGt+7SPGhF7TvNwlHxhS5VUqj7MqMTx gdwtoErfOtohdJ8OQRh7ETzx1n65RHMKTQUNQ4fqhSGbUbvy1BSTmXTUoa9YaPRn8QLl 8FAg== X-Gm-Message-State: APjAAAWSKYCfluweKuG7b4m78c15iF96qF4mZ/WK6bQXzJ1vm8n1Fw2F Kgmw4WcaSvgR3hk3NrWQNT/KmzwP X-Google-Smtp-Source: APXvYqyq7aMGu76cF13VkrVjXkydKn6ZnFk6phS3ABB7Mg+vKz+k2v1BAuPMQXyddAwI8dWbqAtNig== X-Received: by 2002:a5d:4085:: with SMTP id o5mr3620662wrp.321.1574813436694; Tue, 26 Nov 2019 16:10:36 -0800 (PST) Original-Received: from [192.168.0.5] ([212.50.117.215]) by smtp.googlemail.com with ESMTPSA id c15sm17030908wrx.78.2019.11.26.16.10.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Nov 2019 16:10:35 -0800 (PST) In-Reply-To: Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172507 Archived-At: On 26.11.2019 22:43, Fredrik Nyqvist wrote: > Den mån 25 nov. 2019 kl 23:49 skrev Dmitry Gutov >: > > On 25.11.2019 22:16, Fredrik Nyqvist wrote: > > Yes, I have tried the option you mention to edit the last commit > with > > C-x C-e and it is working fine. > > But It seems that it only allows amending the last commit if I have > > edited a file. > > Yes. Not sure how to change an arbitrary commit in Git anyway (without > interactive rebase). The best approximation looks like this: > > https://stackoverflow.com/a/48999882/615245 > > > I am not sure how to do it in a good way either. Maybe the option to > edit an > older commit message could be skipped for vc-git. And then just allow amend > on the latest one. The question is how to skip. Error in the end, after the user has already written the new commit message? Or add a backend predicate action, like "can edit revision ##". That's one more action, though.