bug#42906: [feature/native-comp] out-of-tree build process broken

bug#42906: [feature/native-comp] out-of-tree build process broken

[Ovidiu Toader]

When feature/native-comp branch is built out-of-tree, emacs cannot find the .eln files during start.

The patch below fixes this issue. The problem is caused by the fact that during an out-of-tree build, default-directory points inside the build tree while the .eln files are found in the source tree and because of that the subsequent replace-regexp-in-string fails to adjust the file path of the compilation unit.


modified   lisp/loadup.el
@@ -454,7 +454,7 @@
   ;; when installed or if the source directory got moved.  This is set to be
   ;; a pair in the form: (rel-path-from-install-bin . rel-path-from-local-bin).
   (let ((h (make-hash-table :test #'eq))
-        (lisp-src-dir (expand-file-name (concat default-directory "../lisp")))
+        (lisp-src-dir (expand-file-name "lisp" source-directory))
         (bin-dest-dir (cadr (member "--bin-dest" command-line-args)))
         (lisp-dest-dir (cadr (member "--lisp-dest" command-line-args))))
     (mapatoms (lambda (s)

bug#42906: [feature/native-comp] out-of-tree build process broken

[Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Ovidiu Toader <ovi@phas.ubc.ca> writes:

> When feature/native-comp branch is built out-of-tree, emacs cannot find the .eln files during start.
>
> The patch below fixes this issue. The problem is caused by the fact
> that during an out-of-tree build, default-directory points inside the
> build tree while the .eln files are found in the source tree and
> because of that the subsequent replace-regexp-in-string fails to
> adjust the file path of the compilation unit.

Hi Ovidiu,

thanks for the feedback and the patch!

I just pushed this evening a branch that reworks also the eln file
placement on the file-system and partially this mechanism.

https://lists.gnu.org/archive/html/emacs-devel/2020-08/msg00535.html

It should cure also this problem.

It would be great if you cold try it out and give a feedback if it works
for you.

Thanks!

  Andrea

-- 
akrl@sdf.org

bug#42906: [feature/native-comp] out-of-tree build process broken

[Ovidiu Toader]

On 2020-08-17 11:49 a.m., Andrea Corallo wrote:
> It would be great if you cold try it out and give a feedback if it works
> for you.

I confirm that the new version works well with an out-of-tree build.


Thank you for all the great work!

Ovidiu

bug#42906: [feature/native-comp] out-of-tree build process broken

[Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Ovidiu Toader <ovi@phas.ubc.ca> writes:

> On 2020-08-17 11:49 a.m., Andrea Corallo wrote:
>> It would be great if you cold try it out and give a feedback if it works
>> for you.
>
> I confirm that the new version works well with an out-of-tree build.

Great, closing it.

Thanks!

  Andrea

-- 
akrl@sdf.org