From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Ilya N. Golubev" Newsgroups: gmane.emacs.bugs,gmane.emacs.xemacs.beta Subject: viper portability [Re: Viper hoses describe-key{, -briefly} in xemacs] Date: Thu, 14 Jun 2007 22:32:32 +0400 Message-ID: <18d4zywfnj.fsf@mo.msk.ru> References: <22309.1181843643@cs.sunysb.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1181845977 1933 80.91.229.12 (14 Jun 2007 18:32:57 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 14 Jun 2007 18:32:57 +0000 (UTC) Cc: bug-gnu-emacs@gnu.org, xemacs-beta@xemacs.org To: kifer@cs.sunysb.edu (Michael Kifer), Chong Yidong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jun 14 20:32:55 2007 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Hyu7r-0002xU-Mq for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Jun 2007 20:32:55 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Hyu7r-0003w5-9T for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Jun 2007 14:32:55 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Hyu7p-0003vp-6D for bug-gnu-emacs@gnu.org; Thu, 14 Jun 2007 14:32:53 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Hyu7o-0003vd-F6 for bug-gnu-emacs@gnu.org; Thu, 14 Jun 2007 14:32:52 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Hyu7o-0003va-8g for bug-gnu-emacs@gnu.org; Thu, 14 Jun 2007 14:32:52 -0400 Original-Received: from n52p66.unassigned.ch.govorit.ru ([213.145.52.66] helo=d-fens.mopniei.ru) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Hyu7n-0007wt-M9 for bug-gnu-emacs@gnu.org; Thu, 14 Jun 2007 14:32:52 -0400 Original-Received: from d-fens.mopniei.ru (localhost.localdomain [127.0.0.1]) by d-fens.mopniei.ru (8.13.7/8.13.7) with ESMTP id l5EIWXOp016095 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 14 Jun 2007 22:32:33 +0400 Original-Received: (from gin@localhost) by d-fens.mopniei.ru (8.13.7/8.13.7/Submit) id l5EIWW5i016094; Thu, 14 Jun 2007 22:32:32 +0400 X-Authentication-Warning: d-fens.mopniei.ru: gin set sender to gin@mo.msk.ru using -f In-Reply-To: <22309.1181843643@cs.sunysb.edu> (Michael Kifer's message of "Thu, 14 Jun 2007 13:54:03 -0400") User-Agent: Gnus/5.1008 (Gnus v5.10.8) XEmacs/21.4.20 (linux) X-detected-kernel: Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:15882 gmane.emacs.xemacs.beta:25018 Archived-At: > This change was done by somebody in the emacs trunk. That is, by Chong Yidong (whom cc-ing), recorded as 2007-03-21 one in emacs `ChangeLog', `viper.el' revision 1.101 of 2007-03-21 16:18:25 +0000. Whoever do changes like this, they must understand the following. > I did not test it on xemacs when I merged this with my changes. That is, changes of viper code in emacs cvs can easily go into xemacs package cvs without any checks. In other words, the code in emacs cvs has to be portable to xemacs also, it is normally expected to work in both emacs and xemacs. Nothing states that explicitly, as a requirement for (or at least a request to) developers. Only comment in `viper.el' says that the software is for Emacs and XEmacs Comments in many other viper `.el' files do not mention even that. What might help is `README' file in emacs cvs stating explicitly that the development sources of viper are intended to be portable as above. Another issue is updating xemacs package change log. Certainly if some upstream (emacs cvs in this case) changes are merged there, adding relevant upstream change log entries is also appropriate (in the same file or in a separate one is a matter of taste). The very glance at entries for changes one is going to merge can help detect the appearance of non- portable code, so that one can at least delay merging that particular change.