From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Win Treese Newsgroups: gmane.emacs.bugs Subject: bug#34762: Acknowledgement (26.1.92; objc[27300]: Invalid or prematurely-freed autorelease pool 0x1040021e0.) Date: Tue, 8 Sep 2020 15:38:08 -0400 Message-ID: <18D22571-6BEE-4635-A4CE-36F9AB4E1628@acm.org> References: <5E4CFA2E-BF8D-4F32-9FDA-80A004192288@acm.org> <20200905200250.GC93185@breton.holly.idiocy.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.15\)) Content-Type: multipart/mixed; boundary="Apple-Mail=_DFA9B1CD-7C03-45F9-A051-70145D193EA0" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34973"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 34762@debbugs.gnu.org To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 08 21:39:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kFjSR-000902-8G for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Sep 2020 21:39:11 +0200 Original-Received: from localhost ([::1]:57338 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kFjSQ-000102-AQ for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Sep 2020 15:39:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38222) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kFjSI-0000zK-Ug for bug-gnu-emacs@gnu.org; Tue, 08 Sep 2020 15:39:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44950) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kFjSI-0001Fn-M1 for bug-gnu-emacs@gnu.org; Tue, 08 Sep 2020 15:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kFjSI-0005he-Ia for bug-gnu-emacs@gnu.org; Tue, 08 Sep 2020 15:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Win Treese Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Sep 2020 19:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34762 X-GNU-PR-Package: emacs Original-Received: via spool by 34762-submit@debbugs.gnu.org id=B34762.159959389921871 (code B ref 34762); Tue, 08 Sep 2020 19:39:02 +0000 Original-Received: (at 34762) by debbugs.gnu.org; 8 Sep 2020 19:38:19 +0000 Original-Received: from localhost ([127.0.0.1]:56496 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFjRa-0005gh-T3 for submit@debbugs.gnu.org; Tue, 08 Sep 2020 15:38:19 -0400 Original-Received: from wforward1-smtp.messagingengine.com ([64.147.123.30]:34795) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFjRZ-0005gU-05 for 34762@debbugs.gnu.org; Tue, 08 Sep 2020 15:38:18 -0400 Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailforward.west.internal (Postfix) with ESMTP id E336B11F0; Tue, 8 Sep 2020 15:38:10 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 08 Sep 2020 15:38:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=/HGqFP APg64RPvryIZS3jIF76+7RK95LHUbM971djtI=; b=Zf1cMc78EuQDhe67wkwmWC EwC2gzQwO4axFRL6p6TpSv2GepMdpsJmmM0DvvegefWrpAupPedwRfBbnca/KUDZ SpNBtDm/hzPO1q1W42VINcx0LnL066ExKoOwkkHNI8XO7m9xLlHO9h8DXWiSj2FV hZO5ghXaGB4IP0rWo1DA3JiE1iYjcZ6YlJcPJ5jJBT7UcDgz1MMPZcSesfTmggCT MmfpEHwlqXbuRtu5Vq3lYUyxTfEP01P+J1REtIEGnvXA4XTu+LH+tdpmFjfZfjc6 NRvLDfZfRntv5UdxDbZ3NFT0z3iuP8d1VjqyNyOR68r7C3+ihWSdPRRb/S7Frl5Q == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrudehfedguddvgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpegtggfuhfgjfffkfhfvofesmhdtmherhhdtjeenucfhrhhomhephghinhcu vfhrvggvshgvuceothhrvggvshgvsegrtghmrdhorhhgqeenucggtffrrghtthgvrhhnpe eihfehudekvdffleekjedtfffhveevudekfffgffehuefhvdfhudeukeeluefgvdenucfk phepuddtkedrgeelrdduhedurddufeelnecuvehluhhsthgvrhfuihiivgeptdenucfrrg hrrghmpehmrghilhhfrhhomhepthhrvggvshgvsegrtghmrdhorhhg X-ME-Proxy: Original-Received: from cirocco.treese.org (pool-108-49-151-139.bstnma.fios.verizon.net [108.49.151.139]) by mail.messagingengine.com (Postfix) with ESMTPA id ADA913280068; Tue, 8 Sep 2020 15:38:09 -0400 (EDT) In-Reply-To: <20200905200250.GC93185@breton.holly.idiocy.org> X-Mao-Original-Outgoing-Id: 621286688.681916-f1c2dac3d8e0ee1dcbf9010244352277 X-Mailer: Apple Mail (2.3445.104.15) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:187591 Archived-At: --Apple-Mail=_DFA9B1CD-7C03-45F9-A051-70145D193EA0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Sep 5, 2020, at 4:02 PM, Alan Third wrote: >=20 > Thanks for looking at this. I'm not super clear about how and why the > pools work myself, but I think you're probably right. >=20 > Can you please remove the changelog entry (the changelog files are > automatically generated now), and put it in the git commit message > instead, then use 'git format-patch' as described in CONTRIBUTE? >=20 > Have you completed the copyright paperwork? Sorry, read the wrong info about submitting it! Here=E2=80=99s a second attempt. Let me know if it=E2=80=99s not quite = right. Yes, I submitted copyright paperwork for Emacs a while back. - Win --Apple-Mail=_DFA9B1CD-7C03-45F9-A051-70145D193EA0 Content-Disposition: attachment; filename=0001-Fix-crash-from-clicking-on-menu-bar-bug-34762-bug-26.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Fix-crash-from-clicking-on-menu-bar-bug-34762-bug-26.patch" Content-Transfer-Encoding: quoted-printable =46rom=2035e33ee7b283b831598224f150b9c7a402d28b22=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20Win=20Treese=20=0ADate:=20Tue,=20= 8=20Sep=202020=2015:32:15=20-0400=0ASubject:=20[PATCH]=20Fix=20crash=20= from=20clicking=20on=20menu=20bar=20(bug#34762,=20bug#26982).=0A=0A*=20= src/nsmenu.m=20(ns_update_menubar):=20Remove=20extraneous=20use=20of=0A= autorelease=20pool.=0A---=0A=20src/nsmenu.m=20|=206=20------=0A=201=20= file=20changed,=206=20deletions(-)=0A=0Adiff=20--git=20a/src/nsmenu.m=20= b/src/nsmenu.m=0Aindex=20e313fc03f4..a286a80da1=20100644=0A---=20= a/src/nsmenu.m=0A+++=20b/src/nsmenu.m=0A@@=20-122,7=20+122,6=20@@=0A=20= /*fprintf=20(stderr,=20"ns_update_menubar:=20frame:=20%p\tdeep:=20= %d\tsub:=20%p\n",=20f,=20deep_p,=20submenu);=20*/=0A=20=0A=20=20=20= block_input=20();=0A-=20=20pool=20=3D=20[[NSAutoreleasePool=20alloc]=20= init];=0A=20=0A=20=20=20/*=20Menu=20may=20have=20been=20created=20= automatically;=20if=20so,=20discard=20it.=20=20*/=0A=20=20=20if=20([menu=20= isKindOfClass:=20[EmacsMenu=20class]]=20=3D=3D=20NO)=0A@@=20-240,7=20= +239,6=20@@=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= [[submenu=20title]=20UTF8String]);=0A=20=09=20=20discard_menu_items=20= ();=0A=20=09=20=20unbind_to=20(specpdl_count,=20Qnil);=0A-=20=20=20=20=20= =20=20=20=20=20[pool=20release];=0A=20=20=20=20=20=20=20=20=20=20=20= unblock_input=20();=0A=20=09=20=20return;=0A=20=20=20=20=20=20=20=20=20}=0A= @@=20-298,7=20+296,6=20@@=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= free_menubar_widget_value_tree=20(first_wv);=0A=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20discard_menu_items=20();=0A=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20unbind_to=20(specpdl_count,=20Qnil);=0A-=20=20=20=20=20=20= =20=20=20=20=20=20=20=20[pool=20release];=0A=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20unblock_input=20();=0A=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20return;=0A=20=20=20=20=20=20=20=20=20=20=20=20=20}=0A@@=20= -364,7=20+361,6=20@@=0A=20=20=20=20=20=20=20if=20(NILP=20(items))=0A=20=20= =20=20=20=20=20=20=20{=0A=20=20=20=20=20=20=20=20=20=20=20= free_menubar_widget_value_tree=20(first_wv);=0A-=20=20=20=20=20=20=20=20=20= =20[pool=20release];=0A=20=20=20=20=20=20=20=20=20=20=20unblock_input=20= ();=0A=20=20=20=20=20=20=20=20=20=20=20return;=0A=20=20=20=20=20=20=20=20= =20}=0A@@=20-395,7=20+391,6=20@@=0A=20=20=20=20=20=20=20=20=20=20=20if=20= (i=20=3D=3D=20n)=0A=20=20=20=20=20=20=20=20=20=20=20=20=20{=0A=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20free_menubar_widget_value_tree=20= (first_wv);=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20=20[pool=20= release];=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20unblock_input=20= ();=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20return;=0A=20=20=20=20= =20=20=20=20=20=20=20=20=20}=0A@@=20-454,7=20+449,6=20@@=0A=20=20=20if=20= (needsSet)=0A=20=20=20=20=20[NSApp=20setMainMenu:=20menu];=0A=20=0A-=20=20= [pool=20release];=0A=20=20=20unblock_input=20();=0A=20=0A=20}=0A--=20=0A= 2.21.1=20(Apple=20Git-122.3)=0A=0A= --Apple-Mail=_DFA9B1CD-7C03-45F9-A051-70145D193EA0--