From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nick Roberts Newsgroups: gmane.emacs.bugs,gmane.emacs.pretest.bugs Subject: bug#2092: 23.0.60; vc-svn-diff Date: Thu, 5 Feb 2009 00:03:01 +1300 Message-ID: <18825.30181.243954.921791@kahikatea.snap.net.nz> References: <20090128063434.74C018FC6D@kahikatea.snap.net.nz> Reply-To: Nick Roberts , 2092@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1233750346 26541 80.91.229.12 (4 Feb 2009 12:25:46 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 4 Feb 2009 12:25:46 +0000 (UTC) Cc: 2092-done@emacsbugs.donarmstrong.com, emacs-pretest-bug@gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Feb 04 13:27:00 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LUgqH-0004Iv-9I for geb-bug-gnu-emacs@m.gmane.org; Wed, 04 Feb 2009 13:26:57 +0100 Original-Received: from localhost ([127.0.0.1]:41430 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LUgoy-0007vG-45 for geb-bug-gnu-emacs@m.gmane.org; Wed, 04 Feb 2009 07:25:36 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LUgn6-0007Th-Lh for bug-gnu-emacs@gnu.org; Wed, 04 Feb 2009 07:23:40 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LUgn2-0007TJ-Cj for bug-gnu-emacs@gnu.org; Wed, 04 Feb 2009 07:23:39 -0500 Original-Received: from [199.232.76.173] (port=51606 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LUgn0-0007TD-CH for bug-gnu-emacs@gnu.org; Wed, 04 Feb 2009 07:23:34 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:45970) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LUgmz-0007UL-Vw for bug-gnu-emacs@gnu.org; Wed, 04 Feb 2009 07:23:34 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n14CNVVk005879; Wed, 4 Feb 2009 04:23:31 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n14CF2Po003565; Wed, 4 Feb 2009 04:15:02 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Nick Roberts Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Wed, 04 Feb 2009 12:15:02 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 2092 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by submit@emacsbugs.donarmstrong.com id=B.12337491612241 (code B ref -1); Wed, 04 Feb 2009 12:15:02 +0000 Original-Received: (at submit) by emacsbugs.donarmstrong.com; 4 Feb 2009 12:06:01 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n14C5sdc002235 for ; Wed, 4 Feb 2009 04:05:55 -0800 Original-Received: from mx10.gnu.org ([199.232.76.166]:52914) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1LUgU9-0003P6-1G for emacs-pretest-bug@gnu.org; Wed, 04 Feb 2009 07:04:05 -0500 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1LUgVr-00068m-Ux for emacs-pretest-bug@gnu.org; Wed, 04 Feb 2009 07:05:52 -0500 Original-Received: from viper.snap.net.nz ([202.37.101.23]:35201) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LUgVr-00067W-Ev for emacs-pretest-bug@gnu.org; Wed, 04 Feb 2009 07:05:51 -0500 Original-Received: from kahikatea.snap.net.nz (113.29.255.123.dynamic.snap.net.nz [123.255.29.113]) by viper.snap.net.nz (Postfix) with ESMTP id 628F73D9F9A; Thu, 5 Feb 2009 00:03:04 +1300 (NZDT) Original-Received: by kahikatea.snap.net.nz (Postfix, from userid 1000) id 7759D8FC6D; Thu, 5 Feb 2009 00:03:02 +1300 (NZDT) In-Reply-To: X-Mailer: VM 7.19 under Emacs 22.3.1 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.4-2.6 X-CrossAssassin-Score: 2 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Wed, 04 Feb 2009 07:23:38 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:24931 gmane.emacs.pretest.bugs:23843 Archived-At: > > vc-svn-diff fails when oldvers equals (vc-working-revision f). > > In that case "svn diff" executes with no -r argument and only gives > > a diff if the file is locally modified. > > That's the right behavior when newvers is nil, isn't it? > > > I don't see how it could ever work (please note that I'm not saying that > > it could never work just that I don't see how it could). > > I think it was written assuming (incorrectly) that "newvers == nil". > Is the bug fixed if you add (null newvers) to the conjunction? > > > Stefan > > > PS: I see you've already removed this code, but I remember we added > specifically upon request from some users, so it would be better to fix > it than to remove it. OK, I've looked through the archives. I find it odd because: 1) I think that svn should be able to work out whether it can handle a request locally (a bug in svn?). 2) If you do "C-x v =" there is no problem. 3) I can only see a problem with "C-u C-x v =" with the default values which is eqivalent to 2). So it looks very much like a corner case. Anyway I've done as you say. -- Nick http://www.inet.net.nz/~nickrob