From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ulrich Mueller Newsgroups: gmane.emacs.bugs,gmane.emacs.pretest.bugs Subject: bug#1797: 23.0.60; completing-read breaks backwards compatibility Date: Tue, 6 Jan 2009 00:53:31 +0100 Message-ID: <18786.40315.242106.507079@a1ihome1.kph.uni-mainz.de> Reply-To: Ulrich Mueller , 1797@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1231200295 16588 80.91.229.12 (6 Jan 2009 00:04:55 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 6 Jan 2009 00:04:55 +0000 (UTC) To: emacs-pretest-bug@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 06 01:06:03 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LJzSK-0006lL-00 for geb-bug-gnu-emacs@m.gmane.org; Tue, 06 Jan 2009 01:06:00 +0100 Original-Received: from localhost ([127.0.0.1]:34336 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LJzR4-0007aA-Kz for geb-bug-gnu-emacs@m.gmane.org; Mon, 05 Jan 2009 19:04:42 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LJzPs-00072X-Cq for bug-gnu-emacs@gnu.org; Mon, 05 Jan 2009 19:03:28 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LJzPq-00071h-Q3 for bug-gnu-emacs@gnu.org; Mon, 05 Jan 2009 19:03:28 -0500 Original-Received: from [199.232.76.173] (port=46355 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LJzPq-00071W-FE for bug-gnu-emacs@gnu.org; Mon, 05 Jan 2009 19:03:26 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:37800) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LJzPp-0000xn-Ll for bug-gnu-emacs@gnu.org; Mon, 05 Jan 2009 19:03:25 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0603NPf009808; Mon, 5 Jan 2009 16:03:23 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n06002on008656; Mon, 5 Jan 2009 16:00:02 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Ulrich Mueller Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Tue, 06 Jan 2009 00:00:02 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: report 1797 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by submit@emacsbugs.donarmstrong.com id=B.12311996237442 (code B ref -1); Tue, 06 Jan 2009 00:00:02 +0000 Original-Received: (at submit) by emacsbugs.donarmstrong.com; 5 Jan 2009 23:53:43 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n05NrdcU007436 for ; Mon, 5 Jan 2009 15:53:40 -0800 Original-Received: from mail.gnu.org ([199.232.76.166]:39292 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1LJzFF-0007BN-Fp for emacs-pretest-bug@gnu.org; Mon, 05 Jan 2009 18:52:29 -0500 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1LJzGM-0000Dq-9I for emacs-pretest-bug@gnu.org; Mon, 05 Jan 2009 18:53:38 -0500 Original-Received: from a1iwww1.kph.uni-mainz.de ([134.93.134.1]:54357) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LJzGL-0000DK-Rm for emacs-pretest-bug@gnu.org; Mon, 05 Jan 2009 18:53:38 -0500 Original-Received: from a1ihome1.kph.uni-mainz.de (a1ihome1.kph.uni-mainz.de [134.93.134.75]) by a1iwww1.kph.uni-mainz.de (8.14.0/8.13.4) with ESMTP id n05NrVXL019652 for ; Tue, 6 Jan 2009 00:53:31 +0100 Original-Received: from a1ihome1.kph.uni-mainz.de (localhost [127.0.0.1]) by a1ihome1.kph.uni-mainz.de (8.14.0/8.14.1) with ESMTP id n05NrVo3025998; Tue, 6 Jan 2009 00:53:31 +0100 Original-Received: (from ulm@localhost) by a1ihome1.kph.uni-mainz.de (8.14.0/8.14.0/Submit) id n05NrVdR025993; Tue, 6 Jan 2009 00:53:31 +0100 X-Mailer: VM 8.0.2-487 under Emacs 22.2.1 (i686-pc-linux-gnu) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Mon, 05 Jan 2009 19:03:28 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:23808 gmane.emacs.pretest.bugs:23618 Archived-At: >>>>> On Mon, 05 Jan 2009, Stefan Monnier wrote: >> Also, the different behaviour of `completing-read' breaks backwards >> compatibility. In fact, I stumbled across this because of some lisp >> code doing "programmed completion", which doesn't work properly >> with Emacs 23 anymore (because it accounts only for nil, t, and >> `lambda'). > The intention is for it to 100% backwards compatible. So please > report this bug. Here we go. To reproduce the problem, eval the following code: (defvar my-keywords '("foo" "bar" "baz" "quux" "quuux")) (defun my-complete (s pred mode) (string-match "^\\(.*\\s-\\)?\\(.*\\)$" s) (let* ((s1 (match-string 1 s)) (s2 (match-string 2 s)) (c2 (funcall (cond ((null mode) 'try-completion) ((eq mode t) 'all-completions) ((eq mode 'lambda) (if (fboundp 'test-completion) 'test-completion ;; XEmacs doesn't have test-completion (lambda (&rest args) (eq (apply 'try-completion args) t)))) (t 'ignore)) s2 (mapcar (lambda (x) (list (concat x " "))) my-keywords) pred))) (if (stringp c2) (concat s1 c2) c2))) (completing-read "Type some keywords: " 'my-complete) Now type at the minibuffer prompt: f TAB b TAB TAB Emacs 21/22 (and XEmacs) behaviour: Minibuffer: "Type some keywords: foo ba" *Completions* buffer offers "bar" and "baz" as completions. Emacs 23.0.60 behaviour: Minibuffer: "Type some keywords: foo ba [No completions]" (and no *Completions* buffer appears)