From: Daniel Colascione <dancol@dancol.org>
To: Alan Mackenzie <acm@muc.de>
Cc: 62339@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>
Subject: bug#62339: cc-mode fontifies variables incorrectly when const follows type
Date: Wed, 05 Apr 2023 23:16:16 -0400 [thread overview]
Message-ID: <18754903670.2829.cc5b3318d7e9908e2c46732289705cb0@dancol.org> (raw)
In-Reply-To: <ZC2ZixQ6uVFEqlhC@ACM>
[-- Attachment #1: Type: text/plain, Size: 1177 bytes --]
On April 5, 2023 11:53:54 Alan Mackenzie <acm@muc.de> wrote:
> Hello, Daniel.
>
> On Thu, Mar 23, 2023 at 14:40:23 +0000, Alan Mackenzie wrote:
>> On Wed, Mar 22, 2023 at 18:17:05 -0400, Daniel Colascione wrote:
>
>>>>>> This problem reproduces for me on latest master with emacs -Q:
>
>>>>>> ```
>>>>>> TEST(Foo, Bar) {
>>>>>> NamedTemporaryDirectory const test_directory;
>>>>>> }
>>>>>> ```
>
>>>>> Thanks. What I see with Emacs built from master is that
>>>>> test_directory in the above example gets font-lock-type-face in
>>>>> c++-mode (but not in c-mode). With Emacs built from emacs-29, both
>>>>> modes produce correct fontification.
>
>>>>> Alan, can you please look into this?
>
> [ .... ]
>
>> It turned out that the bug was caused by a single missing line of code, a
>> (c-forward-syntactic-ws) in c-forward-type, so the fix wasn't too
>> difficult. I've taken the opportunity also to fix some minor other
>> innaccuracies in c-forward-type.
>
>> Please try the following patch, and either confirm to me that it appears
>> to fix the bug, or say what's still wrong. Thanks!
>
> Ping?
Works for me. Thanks!
>
> --
> Alan Mackenzie (Nuremberg, Germany).
[-- Attachment #2: Type: text/html, Size: 5772 bytes --]
next prev parent reply other threads:[~2023-04-06 3:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 15:14 bug#62339: cc-mode fontifies variables incorrectly when const follows type Daniel Colascione
2023-03-21 17:39 ` Eli Zaretskii
2023-03-22 14:19 ` Daniel Colascione
2023-03-22 15:12 ` Eli Zaretskii
2023-03-22 22:14 ` Alan Mackenzie
2023-03-22 22:17 ` Daniel Colascione
2023-03-23 0:42 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-23 2:02 ` Daniel Colascione
2023-03-23 5:45 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-23 7:22 ` Eli Zaretskii
2023-03-23 14:40 ` Alan Mackenzie
2023-04-05 15:53 ` Alan Mackenzie
2023-04-06 3:16 ` Daniel Colascione [this message]
2023-04-06 9:26 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18754903670.2829.cc5b3318d7e9908e2c46732289705cb0@dancol.org \
--to=dancol@dancol.org \
--cc=62339@debbugs.gnu.org \
--cc=acm@muc.de \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).