From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#47012: xref copies keymap properties to minibuffer Date: Wed, 31 Mar 2021 18:47:30 +0300 Message-ID: <186b46fa-3716-a76d-db85-09638d7805c7@yandex.ru> References: <87czw9tnu9.fsf@mail.linkov.net> <3aad442a-7319-5db5-2fc6-560bb032c34d@yandex.ru> <87a6r9v24b.fsf@mail.linkov.net> <87sg4kb839.fsf@mail.linkov.net> <871rc3bls6.fsf@mail.linkov.net> <871rc2ly7x.fsf@mail.linkov.net> <4228b128-039c-2bcd-002c-5ac830d7a4d3@yandex.ru> <87pmzgtr80.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1093"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 Cc: 47012@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Mar 31 17:54:40 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lRdB2-00008y-D4 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 31 Mar 2021 17:54:40 +0200 Original-Received: from localhost ([::1]:54148 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lRdB1-000159-Do for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 31 Mar 2021 11:54:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60498) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lRd4c-0002N2-JO for bug-gnu-emacs@gnu.org; Wed, 31 Mar 2021 11:48:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43702) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lRd4c-0003HZ-As for bug-gnu-emacs@gnu.org; Wed, 31 Mar 2021 11:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lRd4c-0000Tp-7l for bug-gnu-emacs@gnu.org; Wed, 31 Mar 2021 11:48:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 31 Mar 2021 15:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47012 X-GNU-PR-Package: emacs Original-Received: via spool by 47012-submit@debbugs.gnu.org id=B47012.16172056611815 (code B ref 47012); Wed, 31 Mar 2021 15:48:02 +0000 Original-Received: (at 47012) by debbugs.gnu.org; 31 Mar 2021 15:47:41 +0000 Original-Received: from localhost ([127.0.0.1]:55248 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lRd4G-0000TB-Vt for submit@debbugs.gnu.org; Wed, 31 Mar 2021 11:47:41 -0400 Original-Received: from mail-ej1-f54.google.com ([209.85.218.54]:46772) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lRd4F-0000Sy-8h for 47012@debbugs.gnu.org; Wed, 31 Mar 2021 11:47:39 -0400 Original-Received: by mail-ej1-f54.google.com with SMTP id u21so30727748ejo.13 for <47012@debbugs.gnu.org>; Wed, 31 Mar 2021 08:47:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=aqTIi7ZjhBUGJ+bm2fW5bl8umYR+MfdoHGeI+qfSeXc=; b=CjpgvwP0i7ePxim0tgMVa1ZlQ0jTKku+eGPf59u/ETGO1T1gQnlumRECCD3M9Ay5Pq apLOEWagKF5w9w+DQ5UBYhcQofI438p+t6pYuPhFpLYcet4PKY8DO6+aQNINC1QGfdDL B/O4VcwVO9FBLQOmDI204XjC9Eib6tKrIJ8JRkamL6fETruinSV9hWgUcmyNpTHmtsjE H+PERPsGCypsNXJSpNGe4uEhRmpfkKRvxfAPiREIaECceL+VXFuln388sh4zL8qje1Qb 8sEEpORzbWSjoeV+jjcKHb7S1bs6d+gznG9LEs1mUYqLLDn5zdUmifbIt7OKtZJtNffT z+0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=aqTIi7ZjhBUGJ+bm2fW5bl8umYR+MfdoHGeI+qfSeXc=; b=i2Omo93lqkoaCNBcTXNS42qptRe7+hcBtzreoXihSORiP87zCpBXRaFf0KjemnRawI bZXvJ92MDyGl2Cxd+sU2/SY/sXDHMtqaNnuvDycstv7ehxYzGpeTdkT/qiF/7cjKdSe0 CZNUcFI4RbPnFw4b8YAmvr92z3ppFgiliGOLqQxGQ3isVoqzhKj6iiTFt+50Oygf68Cz fQbOAxNJMyYRpLuIfpWv9i8lS3ea1ek/PDQ00UinFl+Of8mpyVwHnE3Y6tLFzT4jiUor 91aKJ0L4rbIkQTGdg99b4GnpE4rdgznj8q9x4faLAqIZK8THz8kfC1puX58YRpSG+Ait cBQg== X-Gm-Message-State: AOAM532eYSZi3uuLWmFJ3WyN7Qk81FOO3ujAM0CVhbvZLoxkAsif4bin PixRueiL4Z4uYalEpoXvzazCbC94fho= X-Google-Smtp-Source: ABdhPJzibnFmGdsjolI3brgvgNcr4zIqJKaRMXxfW/pPzn+vnlt1fi1bnotDhAA09wJQlub8Pr66Eg== X-Received: by 2002:a17:907:3f96:: with SMTP id hr22mr4128259ejc.427.1617205653368; Wed, 31 Mar 2021 08:47:33 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id jj15sm1438171ejc.99.2021.03.31.08.47.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 Mar 2021 08:47:32 -0700 (PDT) In-Reply-To: <87pmzgtr80.fsf@mail.linkov.net> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:203370 Archived-At: On 30.03.2021 22:16, Juri Linkov wrote: > Using the same solution of 'diff-header' and > 'diff-file-header' for 'xref-file-header' > improves the readability significantly: > > #+begin_src diff > diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el > index ea52befec5..f2aa8bfba4 100644 > --- a/lisp/progmodes/xref.el > +++ b/lisp/progmodes/xref.el > @@ -513,7 +513,7 @@ xref-pop-to-location > (defconst xref-buffer-name "*xref*" > "The name of the buffer to show xrefs.") > > -(defface xref-file-header '((t :inherit compilation-info)) > +(defface xref-file-header '((t :background "grey90" :extend t)) > "Face used to highlight file header in the xref buffer." > :version "27.1") > #+end_src Hi Juri, I'm not sure I like the result. Simply applying your change to the face results in a color-less buffer with grey spots for both file headers and match highlights (at least, with my current theme). It's less of a problem with diff-mode because its basic background is grey already. I've also considered something like: (defface xref-file-header '((t :background "grey90" :extend t :inherit compilation-info)) "Face used to highlight file header in the xref buffer." :version "27.1") ...but it makes the file names harder to read because of the reduced contrast. Then I've tried to see what others do, for instance https://github.com/Wilfred/deadgrep, which I'd heard people praise usability of. The only distinction it adds to file names is "bold :t". And diff-mode also does that, actually. So... how do you like this simple change? (defface xref-file-header '((t :bold t :inherit compilation-info)) "Face used to highlight file header in the xref buffer." :version "27.1")