From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#47832: 28.0.50; define-fringe-bitmap and emacs --daemon Date: Sat, 17 Apr 2021 12:52:08 +0000 Message-ID: <1869622e16270efbc7e8@heytings.org> References: <7dee3f4235cf450a3254@heytings.org> <83mttxwgm8.fsf@gnu.org> <1869622e16688e6aedec@heytings.org> <83h7k5w54l.fsf@gnu.org> <83fszpw40t.fsf@gnu.org> <1869622e16c60dc2ce0d@heytings.org> <83eef9w0xd.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="B7fHCgR0Yd" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31391"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 47832@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 17 14:53:08 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lXkRg-00083o-NG for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 17 Apr 2021 14:53:08 +0200 Original-Received: from localhost ([::1]:60778 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lXkRf-0006sz-QY for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 17 Apr 2021 08:53:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51540) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lXkRa-0006st-3A for bug-gnu-emacs@gnu.org; Sat, 17 Apr 2021 08:53:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59142) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lXkRZ-0004PZ-R7 for bug-gnu-emacs@gnu.org; Sat, 17 Apr 2021 08:53:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lXkRZ-0007N4-Oa for bug-gnu-emacs@gnu.org; Sat, 17 Apr 2021 08:53:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Apr 2021 12:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47832 X-GNU-PR-Package: emacs Original-Received: via spool by 47832-submit@debbugs.gnu.org id=B47832.161866393128268 (code B ref 47832); Sat, 17 Apr 2021 12:53:01 +0000 Original-Received: (at 47832) by debbugs.gnu.org; 17 Apr 2021 12:52:11 +0000 Original-Received: from localhost ([127.0.0.1]:42455 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXkQl-0007Ls-Es for submit@debbugs.gnu.org; Sat, 17 Apr 2021 08:52:11 -0400 Original-Received: from heytings.org ([95.142.160.155]:41654) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXkQj-0007Lj-Hn for 47832@debbugs.gnu.org; Sat, 17 Apr 2021 08:52:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1618663928; bh=Cv6ba5yg6wMkxb+0Hg5CackgerrB0bWnuCUh1RxUSt0=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=QLNxVkAMg02RKSm1euXjCkuf44R0rT1+BPWq0XNHHa2yNHtB4FmoXT93HYEMGvA7K 1NYK7XSCU20TfFNVHRiYFxVv0iClM2H8eq9AHJP4ul5rdEVI3RLNvQUBX3EVSTPaS9 LFLaboGci1L4qRO7PCTGwMfP/Af4MgaLiKNe4NqZNCRFfJk1TKl0zdA43arO9tUsAw U3Oho5UI2A0s4X2mQzDzBdsN6bHZjc5K1Ef/ksPeaikBb7xYkRMHH3zNF9v7I7Ql4T uUpfm6cJ9SWpYPppxJtz1oXV/dzMgzJBl+AHG1IGmcjSLgKvE7Yz+acRgGE2qpoC5q 2q9pQAnFv97sw== In-Reply-To: <83eef9w0xd.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:204197 Archived-At: --B7fHCgR0Yd Content-Type: text/plain; format=flowed; charset=us-ascii >>> And in any case, the patch for gui_init_fringe is sub-optimal: it >>> unnecessarily loops over the standard bitmaps that were superseded. It >>> is better to leave the first loop go over the standard bitmaps, >>> whether superseded or not, and the second loop go over non-standard >>> bitmaps only. >> >> It is not sub-optimal, rif->define_fringe_bitmap will only be called >> for those standard bitmaps that were superseded. For the >> non-superseded ones, fringe_bitmaps[bt] is NULL. > > I meant the first loop, not the second one. > Okay, the patch was meant only to fix the bug, but indeed the small optimization you mention makes sense. Updated patch attached. --B7fHCgR0Yd Content-Type: text/x-diff; name=Consider-all-user-defined-bitmaps-in-gui_init_fringe.patch Content-Transfer-Encoding: base64 Content-ID: <1869622e163a73965b25@heytings.org> Content-Description: Content-Disposition: attachment; filename=Consider-all-user-defined-bitmaps-in-gui_init_fringe.patch RnJvbSBkMDJhZjJjNzAwN2IyYmEyZmZhNmMwZmI0N2UzM2U2NTExNjgwOGM0 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQ0KRnJvbTogR3JlZ29yeSBIZXl0 aW5ncyA8Z3JlZ29yeUBoZXl0aW5ncy5vcmc+DQpEYXRlOiBTYXQsIDE3IEFw ciAyMDIxIDEyOjQ4OjQ4ICswMDAwDQpTdWJqZWN0OiBbUEFUQ0hdIENvbnNp ZGVyIGFsbCB1c2VyLWRlZmluZWQgYml0bWFwcyBpbiBndWlfaW5pdF9mcmlu Z2UoKQ0KDQoqIHNyYy9mcmluZ2UuYyAoZ3VpX2luaXRfZnJpbmdlKTogQ29u c2lkZXIgdXNlci1kZWZpbmVkIGJpdG1hcHMgdGhhdA0Kb3ZlcnJpZGUgZGVm YXVsdCBvbmVzIChCdWcjNDc4MzIpLg0KLS0tDQogc3JjL2ZyaW5nZS5jIHwg NSArKystLQ0KIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKyksIDIg ZGVsZXRpb25zKC0pDQoNCmRpZmYgLS1naXQgYS9zcmMvZnJpbmdlLmMgYi9z cmMvZnJpbmdlLmMNCmluZGV4IDY1YzlhODRhYzkuLjQ3NjE1ZjUxZjkgMTAw NjQ0DQotLS0gYS9zcmMvZnJpbmdlLmMNCisrKyBiL3NyYy9mcmluZ2UuYw0K QEAgLTE3NzYsMTQgKzE3NzYsMTUgQEAgZ3VpX2luaXRfZnJpbmdlIChzdHJ1 Y3QgcmVkaXNwbGF5X2ludGVyZmFjZSAqcmlmKQ0KICAgZm9yIChidCA9IE5P X0ZSSU5HRV9CSVRNQVAgKyAxOyBidCA8IE1BWF9TVEFOREFSRF9GUklOR0Vf QklUTUFQUzsgYnQrKykNCiAgICAgew0KICAgICAgIHN0cnVjdCBmcmluZ2Vf Yml0bWFwICpmYiA9ICZzdGFuZGFyZF9iaXRtYXBzW2J0XTsNCi0gICAgICBy aWYtPmRlZmluZV9mcmluZ2VfYml0bWFwIChidCwgZmItPmJpdHMsIGZiLT5o ZWlnaHQsIGZiLT53aWR0aCk7DQorICAgICAgaWYgKCFmcmluZ2VfYml0bWFw c1tidF0pDQorICAgICAgICByaWYtPmRlZmluZV9mcmluZ2VfYml0bWFwIChi dCwgZmItPmJpdHMsIGZiLT5oZWlnaHQsIGZiLT53aWR0aCk7DQogICAgIH0N CiANCiAgIC8qIFNldCB1cCB1c2VyLWRlZmluZWQgZnJpbmdlIGJpdG1hcHMg dGhhdCBtaWdodCBoYXZlIGJlZW4gZGVmaW5lZA0KICAgICAgYmVmb3JlIHRo ZSBmcmFtZSBvZiB0aGlzIGtpbmQgd2FzIGluaXRpYWxpemVkLiAgVGhpcyBj YW4gaGFwcGVuDQogICAgICBpZiBFbWFjcyBpcyBzdGFydGVkIGFzIGEgZGFl bW9uIGFuZCB0aGUgaW5pdCBmaWxlcyBkZWZpbmUgZnJpbmdlDQogICAgICBi aXRtYXBzLiAgKi8NCi0gIGZvciAoIDsgYnQgPCBtYXhfdXNlZF9mcmluZ2Vf Yml0bWFwOyBidCsrKQ0KKyAgZm9yIChidCA9IE5PX0ZSSU5HRV9CSVRNQVAg KyAxOyBidCA8IG1heF91c2VkX2ZyaW5nZV9iaXRtYXA7IGJ0KyspDQogICAg IHsNCiAgICAgICBzdHJ1Y3QgZnJpbmdlX2JpdG1hcCAqZmIgPSBmcmluZ2Vf Yml0bWFwc1tidF07DQogICAgICAgaWYgKGZiKQ0KLS0gDQoyLjMwLjINCg0K --B7fHCgR0Yd--