bug#1048: 23.0.60; No Mouse 2 (Cocoa Emacs)

bug#1048: 23.0.60; No Mouse 2 (Cocoa Emacs)

[Nick Roberts]

Using "configure --with-ns" on Leopard:

I have a mighty mouse(?) and Cocoa Emacs doesn't seem to register a click
from the mouse-2 (the scroll ball) although it does scroll if I roll the
ball.


-- 
Nick                                           http://www.inet.net.nz/~nickrob

bug#1357: 23.0.60; Mouse button 2 is not recognized (on Mac; --with-ns)

[Harald Hanche-Olsen]

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

Pressing mouse button 2 produces no response in any buffer. C-h c
<button 2> does nothing (until I press some other key or mouse button,
in which case the binding of that key is described). Buttons 1 and 3
work fine, as does the scroll wheel.

In GNU Emacs 23.0.60.1 (powerpc-apple-darwin9.5.0, NS apple-appkit-949.35)
 of 2008-11-14 on macknife
Windowing system distributor `Apple', version 97.112.112.108.101.45.97.112.112.107.105.116.45.57.52.57.46.51.53
configured using `configure  '--with-ns' '--without-x''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: nil
  value of $XMODIFIERS: nil
  locale-coding-system: nil
  default-enable-multibyte-characters: t

Major mode: Completion List

Minor modes in effect:
  diff-auto-refine-mode: t
  show-paren-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
C-h c <down-mouse-1> <down-mouse-3> <mouse-3> <mouse-1> 
C-g C-x b * M e s <tab> <return> M-x b u r <tab> <return> 
C-a C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n q M-x M-p 
M-p <return>

Recent messages:
Wrote /Users/hanche/lib/emacs/.emacs
C-g runs the command keyboard-quit
You did not specify a variable
Quit
Making completion list... [2 times]
Quit [2 times]
Mark set
Making completion list...
Quit
<down-mouse-1> at that spot runs the command mouse-drag-region
Quit

bug#1357: Acknowledgement (23.0.60; Mouse button 2 is not recognized (on Mac; --with-ns))

[Harald Hanche-Olsen]

I see now that this bug is a duplicate of #1048.
But my report is a bit more detailed (or noisy).

- Harald

bug#1414: 23.0.60; Middle mouse button does not work in Cocoa port

[Wolfgang Lux]

[-- Attachment #1: Type: text/plain, Size: 670 bytes --]


Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.

Your bug report will be posted to the emacs-pretest-bug@gnu.org  
mailing list.

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

Clicking the middle mouse button does not have an effect. The attached
patch fixes this issue.

In GNU Emacs 23.0.60.1 (powerpc-apple-darwin8.11.0, NS apple- 
appkit-824.48)
  of 2008-11-21 on Onyx.local
Windowing system distributor `Apple', version  
97.112.112.108.101.45.97.112.112.107.105.116.45.56.50.52.46.52.56
configured using `configure  '--with-ns''


[-- Attachment #2: nsterm.patch --]
[-- Type: application/octet-stream, Size: 1692 bytes --]

Index: src/nsterm.m
===================================================================
RCS file: /sources/emacs/emacs/src/nsterm.m,v
retrieving revision 1.35
diff -u -r1.35 nsterm.m
--- src/nsterm.m	15 Nov 2008 05:20:49 -0000	1.35
+++ src/nsterm.m	23 Nov 2008 11:54:29 -0000
@@ -260,9 +260,12 @@
 #define EV_UDMODIFIERS(e)                                      \
     ((([e type] == NSLeftMouseDown) ? down_modifier : 0)       \
      | (([e type] == NSRightMouseDown) ? down_modifier : 0)    \
+     | (([e type] == NSOtherMouseDown) ? down_modifier : 0)    \
      | (([e type] == NSLeftMouseDragged) ? down_modifier : 0)  \
      | (([e type] == NSRightMouseDragged) ? down_modifier : 0) \
+     | (([e type] == NSOtherMouseDragged) ? down_modifier : 0) \
      | (([e type] == NSLeftMouseUp)   ? up_modifier   : 0)     \
+     | (([e type] == NSOtherMouseUp)   ? up_modifier   : 0)     \
      | (([e type] == NSRightMouseUp)   ? up_modifier   : 0))
 
 #define EV_BUTTON(e)                                                         \
@@ -4725,6 +4728,13 @@
 }
 
 
+- (void)otherMouseDown: (NSEvent *)theEvent
+{
+  NSTRACE (otherMouseDown);
+  [self mouseDown: theEvent];
+}
+
+
 - (void)rightMouseUp: (NSEvent *)theEvent
 {
   NSTRACE (rightMouseUp);
@@ -4732,6 +4742,13 @@
 }
 
 
+- (void)otherMouseUp: (NSEvent *)theEvent
+{
+  NSTRACE (otherMouseUp);
+  [self mouseDown: theEvent];
+}
+
+
 - (void) scrollWheel: (NSEvent *)theEvent
 {
   NSTRACE (scrollWheel);
@@ -4800,6 +4817,13 @@
 }
 
 
+- (void)otherMouseDragged: (NSEvent *)e
+{
+  NSTRACE (otherMouseDragged);
+  [self mouseMoved: e];
+}
+
+
 - (BOOL)windowShouldClose: (id)sender
 {
   NSEvent *e =[[self window] currentEvent];

bug#1048: marked as done (23.0.60; No Mouse 2 (Cocoa Emacs))

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 886 bytes --]


Your message dated Mon, 24 Nov 2008 23:14:41 -0500
with message-id <476D6C3A-F61F-42C5-821C-7929DBB31B13@interstitiality.net>
and subject line #1048 - 23.0.60; No Mouse 2 (Cocoa Emacs) - Emacs bug report logs
has caused the Emacs bug report #1048,
regarding 23.0.60; No Mouse 2 (Cocoa Emacs)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)


-- 
1048: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=1048
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 2242 bytes --]

From: Nick Roberts <nickrob@snap.net.nz>
To: emacs-pretest-bug@gnu.org
Subject: 23.0.60; No Mouse 2 (Cocoa Emacs)
Date: Sun, 28 Sep 2008 19:27:55 +1200
Message-ID: <18655.12795.320889.256036@kahikatea.snap.net.nz>


Using "configure --with-ns" on Leopard:

I have a mighty mouse(?) and Cocoa Emacs doesn't seem to register a click
from the mouse-2 (the scroll ball) although it does scroll if I roll the
ball.


-- 
Nick                                           http://www.inet.net.nz/~nickrob



[-- Attachment #3: Type: message/rfc822, Size: 1616 bytes --]

From: Adrian Robert <arobert@interstitiality.net>
To: 1048-done@emacsbugs.donarmstrong.com
Subject: #1048 - 23.0.60; No Mouse 2 (Cocoa Emacs) - Emacs bug report logs
Date: Mon, 24 Nov 2008 23:14:41 -0500
Message-ID: <476D6C3A-F61F-42C5-821C-7929DBB31B13@interstitiality.net>

Closing, applied patch from Wolfgang Lux.

bug#1357: marked as done (23.0.60; Mouse button 2 is not recognized (on Mac; --with-ns))

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 914 bytes --]


Your message dated Mon, 24 Nov 2008 23:14:41 -0500
with message-id <476D6C3A-F61F-42C5-821C-7929DBB31B13@interstitiality.net>
and subject line #1048 - 23.0.60; No Mouse 2 (Cocoa Emacs) - Emacs bug report logs
has caused the Emacs bug report #1048,
regarding 23.0.60; Mouse button 2 is not recognized (on Mac; --with-ns)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)


-- 
1048: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=1048
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 3809 bytes --]

From: Harald Hanche-Olsen <hanche@math.ntnu.no>
To: emacs-pretest-bug@gnu.org
Subject: 23.0.60; Mouse button 2 is not recognized (on Mac; --with-ns)
Date: Sun, 16 Nov 2008 15:35:26 +0100 (CET)
Message-ID: <20081116.153526.39394517.hanche@math.ntnu.no>

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

Pressing mouse button 2 produces no response in any buffer. C-h c
<button 2> does nothing (until I press some other key or mouse button,
in which case the binding of that key is described). Buttons 1 and 3
work fine, as does the scroll wheel.

In GNU Emacs 23.0.60.1 (powerpc-apple-darwin9.5.0, NS apple-appkit-949.35)
 of 2008-11-14 on macknife
Windowing system distributor `Apple', version 97.112.112.108.101.45.97.112.112.107.105.116.45.57.52.57.46.51.53
configured using `configure  '--with-ns' '--without-x''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: nil
  value of $XMODIFIERS: nil
  locale-coding-system: nil
  default-enable-multibyte-characters: t

Major mode: Completion List

Minor modes in effect:
  diff-auto-refine-mode: t
  show-paren-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
C-h c <down-mouse-1> <down-mouse-3> <mouse-3> <mouse-1> 
C-g C-x b * M e s <tab> <return> M-x b u r <tab> <return> 
C-a C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n q M-x M-p 
M-p <return>

Recent messages:
Wrote /Users/hanche/lib/emacs/.emacs
C-g runs the command keyboard-quit
You did not specify a variable
Quit
Making completion list... [2 times]
Quit [2 times]
Mark set
Making completion list...
Quit
<down-mouse-1> at that spot runs the command mouse-drag-region
Quit



[-- Attachment #3: Type: message/rfc822, Size: 1616 bytes --]

From: Adrian Robert <arobert@interstitiality.net>
To: 1048-done@emacsbugs.donarmstrong.com
Subject: #1048 - 23.0.60; No Mouse 2 (Cocoa Emacs) - Emacs bug report logs
Date: Mon, 24 Nov 2008 23:14:41 -0500
Message-ID: <476D6C3A-F61F-42C5-821C-7929DBB31B13@interstitiality.net>

Closing, applied patch from Wolfgang Lux.

bug#1414: marked as done (23.0.60; Middle mouse button does not work in Cocoa port)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 909 bytes --]


Your message dated Mon, 24 Nov 2008 23:14:41 -0500
with message-id <476D6C3A-F61F-42C5-821C-7929DBB31B13@interstitiality.net>
and subject line #1048 - 23.0.60; No Mouse 2 (Cocoa Emacs) - Emacs bug report logs
has caused the Emacs bug report #1048,
regarding 23.0.60; Middle mouse button does not work in Cocoa port
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)


-- 
1048: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=1048
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 5800 bytes --]

[-- Attachment #2.1.1: Type: text/plain, Size: 670 bytes --]


Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.

Your bug report will be posted to the emacs-pretest-bug@gnu.org  
mailing list.

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

Clicking the middle mouse button does not have an effect. The attached
patch fixes this issue.

In GNU Emacs 23.0.60.1 (powerpc-apple-darwin8.11.0, NS apple- 
appkit-824.48)
  of 2008-11-21 on Onyx.local
Windowing system distributor `Apple', version  
97.112.112.108.101.45.97.112.112.107.105.116.45.56.50.52.46.52.56
configured using `configure  '--with-ns''


[-- Attachment #2.1.2: nsterm.patch --]
[-- Type: application/octet-stream, Size: 1692 bytes --]

Index: src/nsterm.m
===================================================================
RCS file: /sources/emacs/emacs/src/nsterm.m,v
retrieving revision 1.35
diff -u -r1.35 nsterm.m
--- src/nsterm.m	15 Nov 2008 05:20:49 -0000	1.35
+++ src/nsterm.m	23 Nov 2008 11:54:29 -0000
@@ -260,9 +260,12 @@
 #define EV_UDMODIFIERS(e)                                      \
     ((([e type] == NSLeftMouseDown) ? down_modifier : 0)       \
      | (([e type] == NSRightMouseDown) ? down_modifier : 0)    \
+     | (([e type] == NSOtherMouseDown) ? down_modifier : 0)    \
      | (([e type] == NSLeftMouseDragged) ? down_modifier : 0)  \
      | (([e type] == NSRightMouseDragged) ? down_modifier : 0) \
+     | (([e type] == NSOtherMouseDragged) ? down_modifier : 0) \
      | (([e type] == NSLeftMouseUp)   ? up_modifier   : 0)     \
+     | (([e type] == NSOtherMouseUp)   ? up_modifier   : 0)     \
      | (([e type] == NSRightMouseUp)   ? up_modifier   : 0))
 
 #define EV_BUTTON(e)                                                         \
@@ -4725,6 +4728,13 @@
 }
 
 
+- (void)otherMouseDown: (NSEvent *)theEvent
+{
+  NSTRACE (otherMouseDown);
+  [self mouseDown: theEvent];
+}
+
+
 - (void)rightMouseUp: (NSEvent *)theEvent
 {
   NSTRACE (rightMouseUp);
@@ -4732,6 +4742,13 @@
 }
 
 
+- (void)otherMouseUp: (NSEvent *)theEvent
+{
+  NSTRACE (otherMouseUp);
+  [self mouseDown: theEvent];
+}
+
+
 - (void) scrollWheel: (NSEvent *)theEvent
 {
   NSTRACE (scrollWheel);
@@ -4800,6 +4817,13 @@
 }
 
 
+- (void)otherMouseDragged: (NSEvent *)e
+{
+  NSTRACE (otherMouseDragged);
+  [self mouseMoved: e];
+}
+
+
 - (BOOL)windowShouldClose: (id)sender
 {
   NSEvent *e =[[self window] currentEvent];

[-- Attachment #3: Type: message/rfc822, Size: 1616 bytes --]

From: Adrian Robert <arobert@interstitiality.net>
To: 1048-done@emacsbugs.donarmstrong.com
Subject: #1048 - 23.0.60; No Mouse 2 (Cocoa Emacs) - Emacs bug report logs
Date: Mon, 24 Nov 2008 23:14:41 -0500
Message-ID: <476D6C3A-F61F-42C5-821C-7929DBB31B13@interstitiality.net>

Closing, applied patch from Wolfgang Lux.