From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Bill Wohler via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#67361: 29.1; MH-E: creating a new folder can sometimes fail with a Lisp error Date: Sat, 30 Dec 2023 15:33:54 -0800 Organization: Newt Software Message-ID: <1851818.1703979234@olgas.newt.com> References: <160446.1700884619@alto> Reply-To: Bill Wohler Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24905"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 67361@debbugs.gnu.org, Chris Siebenmann , Eli Zaretskii To: Mike Kupfer Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 31 00:35:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rJirL-0006GC-S8 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 31 Dec 2023 00:35:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rJirA-0006ee-Sx; Sat, 30 Dec 2023 18:35:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rJir7-0006eO-Qm for bug-gnu-emacs@gnu.org; Sat, 30 Dec 2023 18:35:01 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rJir7-0002Pp-FF for bug-gnu-emacs@gnu.org; Sat, 30 Dec 2023 18:35:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rJir8-00022I-6W for bug-gnu-emacs@gnu.org; Sat, 30 Dec 2023 18:35:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Bill Wohler Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 30 Dec 2023 23:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67361 X-GNU-PR-Package: emacs Original-Received: via spool by 67361-submit@debbugs.gnu.org id=B67361.17039792557767 (code B ref 67361); Sat, 30 Dec 2023 23:35:02 +0000 Original-Received: (at 67361) by debbugs.gnu.org; 30 Dec 2023 23:34:15 +0000 Original-Received: from localhost ([127.0.0.1]:45247 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJiqN-00021C-0w for submit@debbugs.gnu.org; Sat, 30 Dec 2023 18:34:15 -0500 Original-Received: from se3b-lax1.servconfig.com ([192.249.122.52]:36525) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJiqG-00020t-IK for 67361@debbugs.gnu.org; Sat, 30 Dec 2023 18:34:13 -0500 Original-Received: from ecbiz329.inmotionhosting.com ([209.182.198.38]) by se3-lax1.servconfig.com with esmtps (TLSv1.2:AES128-GCM-SHA256:128) (Exim 4.92) (envelope-from ) id 1rJiq6-0006ox-2B; Sat, 30 Dec 2023 18:34:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=newt.com; s=default; h=Message-ID:Date:Content-ID:Content-Type:MIME-Version:References: In-reply-to:Subject:From:cc:To:Sender:Reply-To:Content-Transfer-Encoding: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=PneiwsXbQ0o3oNFcyVWEd5XZiy2u+CuRX8svyO+f0+k=; b=gnT/bivZdgkyHZceBrJner2QZM vfd5I2qMWWfgNX5iMbM6YPiieZZSG0MVM2QrKxQDf/veJEKdWZ2aTBIL/fzjVmn72mXsqW+DL+sh3 nulggkS6mUVJR3JbG14QZ1/MJMf6fAr3dkFGBo5vFcuSS8sswHza8pddPSafcELvvisDZ+FfY/IDW LMRTr4qFfZGZ7xcch3FuEzjqpc7Fg2m9OnrPVI2WmtmAbRAlSFBEYCela4qWyGgCDG+Frd29UkkZU 8TUdCcnQoZWy02ngPrWdpr5sz3t6oZoQ267Zgk9IJC5KKuSjTEoVy2ib+c86RGdO711zQW5p2v1oH oRnbh7zQ==; Original-Received: from [24.4.147.188] (port=42538 helo=olgas.newt.com) by ecbiz329.inmotionhosting.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rJiq3-00B65K-1Z; Sat, 30 Dec 2023 18:33:55 -0500 Original-Received: by olgas.newt.com (Postfix, from userid 1000) id 91E69381F05; Sat, 30 Dec 2023 15:33:54 -0800 (PST) In-reply-to: <160446.1700884619@alto> Comments: In-reply-to Mike Kupfer message dated "Fri, 24 Nov 2023 19:56:59 -0800." X-Mailer: MH-E 8.6+git; nmh 1.8-RC2; Emacs 30.0.50 X-Image-URL: http://www.newt.com/wohler/images/bill-diving.png Content-ID: <1851817.1703979234.1@olgas.newt.com> X-Get-Message-Sender-Via: ecbiz329.inmotionhosting.com: authenticated_id: wohler@newt.com X-Authenticated-Sender: ecbiz329.inmotionhosting.com: wohler@newt.com X-Originating-IP: 209.182.198.38 X-SpamExperts-Domain: ecbiz329.inmotionhosting.com X-SpamExperts-Username: 209.182.198.38 Authentication-Results: servconfig.com; auth=pass smtp.auth=209.182.198.38@ecbiz329.inmotionhosting.com X-SpamExperts-Outgoing-Class: ham X-SpamExperts-Outgoing-Evidence: Combined (0.16) X-Recommended-Action: accept X-Filter-ID: Pt3MvcO5N4iKaDQ5O6lkdGlMVN6RH8bjRMzItlySaT8za+VHhmzvfYlBMrcEySFuPUtbdvnXkggZ 3YnVId/Y5jcf0yeVQAvfjHznO7+bT5wPNj8CRzrsGB7ugNp6dkMIG6S2l0Sq0XyAP7CL22R+h+zb pTmR3UMMzVofDFwaANpMBhQwZ4U+dP0cDUdUHxwFkzGIyEDKB5+tuM/BiYkNNtjLQNCIemmyp7tp LvZV4fGqkaWbbOMJrh1zQUl46B+CYkduHVxMU+FPhTgkrzPHlQK/NzaQ0kU5LIjXaSmvljzrv6uv y67bPy9KnwerIPD7+EJh3GmpTMtirFB1CX1Gmfdp637QXBUN6CLyeuzX+S3o06Pbn32ePf/zaJyv Vrl2ZVV1JLevYUOVh4MQQup+muhEQjf02DvD6NbBWC62Mac2JrO8Qv8RArq2MwWaNnh+UuIF2yn0 3s7TS3ghm2vgBpb5Pn6ftQZVK9K8EAjn37sUg69eDYNe2itClT3S7bjQUCo5PZJsLcY5FmNhp+JD xofgBwPJRy2KP3xL3XdLYqV41APOGyRuqKbOun7vlQzhwfhpspQKRAIBFcUdSV85+USmicW4BKeo lukxoVI4SaNoMMMh30z0ou3Uma6ICBqohxGGNNFI1AuNleg/0I92t9xCHahZfsjvoDKdqQReE7op ol7/zxbDwFIVzeFgpWdBcxw3qqhc+N6cuEg4XWh5Fr6ZVfVJh06xHbGQIHpvkjtIMBrtljuxZklv aEUUFavsuWteB8cJdGGVwL3ei/c5MZpKmLbRp5hwod2JBq60vmYawPUpK3ub+Dr5UYldD3d9Nj+o a4bUWaUNnGyX2uCjMvrx9dCnn+/6G X-Report-Abuse-To: spam@se1-lax1.servconfig.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277113 Archived-At: Chris, you are correct. Even if you start up the speedbar before starting MH-E, MH-E will then update the old speedbar view with an MH view when a MH-E folder becomes active. Mike, if you've been running this patch without problems, I'd say commit it and resolve this issue. Testing for an existing speedbar-buffer seems like a stronger test than mh-speed-folder-map. I just applied the patch and hasn't broken anything thus far. I even used the speedbar :-). Mike Kupfer wrote: > Chris Siebenmann wrote: > > > I believe that if the speedbar is active (which I believe is when > > speedbar-buffer is non-nil) and you're in MH-E, the speedbar will be > > showing your MH folder hierarchy instead of anything else. But I'm not > > 100% sure of this. > > I've lightly tested the patch below and not seen any problems. What do > you guys think about it? > > mike > > diff --git a/lisp/mh-e/mh-funcs.el b/lisp/mh-e/mh-funcs.el > --- a/lisp/mh-e/mh-funcs.el > +++ b/lisp/mh-e/mh-funcs.el > @@ -108,7 +108,7 @@ > (window-config mh-previous-window-config)) > (mh-set-folder-modified-p t) ; lock folder to kill it > (mh-exec-cmd-daemon "rmf" 'mh-rmf-daemon folder) > - (when (boundp 'mh-speed-folder-map) > + (when (and (boundp 'speedbar-buffer) speedbar-buffer) > (mh-speed-invalidate-map folder)) > (mh-remove-from-sub-folders-cache folder) > (mh-set-folder-modified-p nil) ; so kill-buffer doesn't complain > diff --git a/lisp/mh-e/mh-search.el b/lisp/mh-e/mh-search.el > --- a/lisp/mh-e/mh-search.el > +++ b/lisp/mh-e/mh-search.el > @@ -1569,7 +1569,7 @@ > (save-excursion (mh-exec-cmd-quiet nil "rmf" chosen-name)) > (mh-exec-cmd-quiet nil "folder" "-create" "-fast" chosen-name) > (mh-remove-from-sub-folders-cache chosen-name) > - (when (boundp 'mh-speed-folder-map) > + (when (and (boundp 'speedbar-buffer) speedbar-buffer) > (mh-speed-add-folder chosen-name)) > chosen-name)) > > diff --git a/lisp/mh-e/mh-utils.el b/lisp/mh-e/mh-utils.el > --- a/lisp/mh-e/mh-utils.el > +++ b/lisp/mh-e/mh-utils.el > @@ -795,7 +795,7 @@ > (message "Creating %s" folder-name) > (mh-exec-cmd-error nil "folder" folder-name) > (mh-remove-from-sub-folders-cache folder-name) > - (when (boundp 'mh-speed-folder-map) > + (when (and (boundp 'speedbar-buffer) speedbar-buffer) > (mh-speed-add-folder folder-name)) > (message "Creating %s...done" folder-name)) > (new-file-flag > -- Bill Wohler aka http://www.newt.com/wohler/, GnuPG ID:610BD9AD