From: Dmitry Gutov <dgutov@yandex.ru>
To: Tom Tromey <tom@tromey.com>
Cc: 25529@debbugs.gnu.org
Subject: bug#25529: diagnosis and one approach to a fix
Date: Mon, 6 Feb 2017 03:12:31 +0200 [thread overview]
Message-ID: <183374a4-6469-44af-6ae6-fec02874547a@yandex.ru> (raw)
In-Reply-To: <87k2948onb.fsf@tromey.com>
Hey Tom,
On 05.02.2017 20:43, Tom Tromey wrote:
> Tom> Another way is to use a regexp, see appended.
> Tom> I'll try to write a test for this soon.
>
> Now with a test.
This is very good, thank you. Here's just one example I've come so far
that works with the old code, but not with yours:
let x = /[/]/;
And that's probably just because the new js-syntax-propertize-regexp
doesn't move point forward after matching (the current one leaves it
after the closing slash), because the regexp in js-syntax-propertize is
too primitive.
We could try to combine the regexps together, though. Then we'd move the
syntax-ppss status check inside the rule for the opening delimiter, and
use a simple one for the closer.
> + "Regular expression matching the body of a JavaScript regexp literal.")
Maybe remove "the body of". The regexp matches the delimiters as well.
Thanks!
next prev parent reply other threads:[~2017-02-06 1:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-25 7:22 bug#25529: 25.1.90; js-mode: Regexp literal with unbalanced brackets breaks font-lock Mikhail Gusarov
2017-02-05 5:37 ` bug#25529: diagnosis and one approach to a fix Tom Tromey
2017-02-05 6:01 ` Tom Tromey
2017-02-05 18:05 ` Tom Tromey
2017-02-05 18:43 ` Tom Tromey
2017-02-06 1:12 ` Dmitry Gutov [this message]
2017-02-06 17:27 ` Tom Tromey
2017-02-07 2:20 ` Dmitry Gutov
2017-02-07 13:07 ` Tom Tromey
2017-02-07 13:11 ` Dmitry Gutov
2017-02-07 14:56 ` Stefan Monnier
2017-02-11 1:52 ` Tom Tromey
2017-02-11 3:45 ` Stefan Monnier
2017-02-11 4:06 ` Tom Tromey
2017-02-11 4:22 ` Stefan Monnier
2017-02-11 15:27 ` Tom Tromey
2017-02-11 15:41 ` Stefan Monnier
2017-02-11 17:13 ` Tom Tromey
2017-02-11 19:11 ` Dmitry Gutov
2017-02-11 19:37 ` bug#25529: done Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=183374a4-6469-44af-6ae6-fec02874547a@yandex.ru \
--to=dgutov@yandex.ru \
--cc=25529@debbugs.gnu.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).